mesa/src
Benjamin Lee f5763e80f4 panvk: fix sample position when sample shading is disabled
Previous code was assuming that load_sample_id loaded the hardware
sample ID register, which is 32 when sample shading is disabled. The
expectation was that we would read (0.5,0.5) from sample_positions[32].

Because the top 3 bits of the sample ID register are masked out in
bi_load_sample_id_to, we were instead reading the position of the first
sample.

This doesn't affect OpenGL, because opengl never uses
nir_load_sample_pos when sample shading is disabled.

Signed-off-by: Benjamin Lee <benjamin.lee@collabora.com>
Fixes: 60146cc57c ("panvk: implement sampleRateShading")
Reviewed-by: Eric R. Smith <eric.smith@collabora.com>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32601>
2024-12-18 10:04:14 +00:00
..
amd ci/lava: Use CI_JOB_TIMEOUT instead of separate variable 2024-12-18 09:23:27 +00:00
android_stub
asahi agx: optimize scratch access 2024-12-12 21:16:13 +00:00
broadcom broadcom/compiler: fix fp16 conversion operations 2024-12-16 10:56:38 +00:00
c11
compiler pan,nir: introduce load_attribute_pan 2024-12-18 08:33:16 +00:00
drm-shim
egl meson: drop unused variables 2024-11-26 20:45:41 +00:00
etnaviv etnaviv/ci: Convert to deqp-runner suites 2024-12-16 11:27:31 +00:00
freedreno ci/lava: Use CI_JOB_TIMEOUT instead of separate variable 2024-12-18 09:23:27 +00:00
gallium ci/lava: Use CI_JOB_TIMEOUT instead of separate variable 2024-12-18 09:23:27 +00:00
gbm Revert "gbm: mark surface buffers as explicit flushed" 2024-11-27 22:48:04 +00:00
getopt
gfxstream gfxstream: fix issues with VK1.4 build 2024-12-03 20:35:44 +00:00
glx glx: ignore zink check for has_explicit_modifiers and DRI3 on MacOS. 2024-12-13 00:39:16 +00:00
gtest
imagination vulkan: rename depth bias graphics states 2024-12-06 13:48:26 -05:00
imgui
intel ci/lava: Use CI_JOB_TIMEOUT instead of separate variable 2024-12-18 09:23:27 +00:00
loader loader: Fix typo in __DRI_IMAGE_FORMAT_XBGR16161616 definition 2024-10-25 14:18:24 +00:00
mapi meson: remove selinux option 2024-10-21 01:14:35 +00:00
mesa mesa: when blitting between formats clear any unused components 2024-12-05 18:27:37 +00:00
microsoft microsoft/clc: Initialize printf buffer for tests 2024-12-10 19:13:07 +00:00
nouveau ci: uprev vkd3d-proton to c965c1351fd6915a65bb7f647319536252a24a93 2024-12-17 16:00:34 +00:00
panfrost panvk: fix sample position when sample shading is disabled 2024-12-18 10:04:14 +00:00
tool panvk: add u_trace perfetto support 2024-12-17 23:14:26 +00:00
util anv, drirc: Add workaround to speed up Spiderman reg allocation 2024-12-17 17:40:44 +00:00
virtio treewide: Stop putting enum in front of Vulkan enum types 2024-12-02 17:22:49 +00:00
vulkan vulkan: Fix the argument order of update_as 2024-12-12 11:15:08 +00:00
x11 meson: require dri3 modifiers 2024-09-06 17:34:17 +00:00
.clang-format nir: add helpers for precompiled shaders 2024-11-28 17:34:12 +00:00
meson.build meson: simplify logic a bit 2024-11-26 20:45:41 +00:00