mesa/src/broadcom/vulkan/v3dv_cl.c
Iago Toral Quiroga c2601f0690 v3dv: ensure at least V3D_CL_MAX_INSTR_SIZE bytes in last CL instruction
The CLE parser in the sim will read this many bytes for each instruction
in a CL, so we should ensure we have at least that many bytes available
in the BO when reading the last instruction, otherwise we can trigger
a GMP violation. It is not clear whether this behavior applies to real
hardware too.

cc: mesa-stable

Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21162>
2023-02-07 14:06:57 +01:00

145 lines
4.6 KiB
C

/*
* Copyright © 2019 Raspberry Pi Ltd
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
* to deal in the Software without restriction, including without limitation
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
* and/or sell copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice (including the next
* paragraph) shall be included in all copies or substantial portions of the
* Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
* IN THE SOFTWARE.
*/
#include "v3dv_private.h"
/* We don't expect that the packets we use in this file change across hw
* versions, so we just explicitly set the V3D_VERSION and include v3dx_pack
* here
*/
#define V3D_VERSION 33
#include "broadcom/common/v3d_macros.h"
#include "broadcom/cle/v3dx_pack.h"
void
v3dv_cl_init(struct v3dv_job *job, struct v3dv_cl *cl)
{
cl->base = NULL;
cl->next = cl->base;
cl->bo = NULL;
cl->size = 0;
cl->job = job;
list_inithead(&cl->bo_list);
}
void
v3dv_cl_destroy(struct v3dv_cl *cl)
{
list_for_each_entry_safe(struct v3dv_bo, bo, &cl->bo_list, list_link) {
assert(cl->job);
list_del(&bo->list_link);
v3dv_bo_free(cl->job->device, bo);
}
/* Leave the CL in a reset state to catch use after destroy instances */
v3dv_cl_init(NULL, cl);
}
static bool
cl_alloc_bo(struct v3dv_cl *cl, uint32_t space, bool use_branch)
{
/* If we are growing, double the BO allocation size to reduce the number
* of allocations with large command buffers. This has a very significant
* impact on the number of draw calls per second reported by vkoverhead.
*/
space = align(space, 4096);
if (cl->bo)
space = MAX2(cl->bo->size * 2, space);
struct v3dv_bo *bo = v3dv_bo_alloc(cl->job->device, space, "CL", true);
if (!bo) {
fprintf(stderr, "failed to allocate memory for command list\n");
v3dv_flag_oom(NULL, cl->job);
return false;
}
list_addtail(&bo->list_link, &cl->bo_list);
bool ok = v3dv_bo_map(cl->job->device, bo, bo->size);
if (!ok) {
fprintf(stderr, "failed to map command list buffer\n");
v3dv_flag_oom(NULL, cl->job);
return false;
}
/* Chain to the new BO from the old one if requested */
if (use_branch && cl->bo) {
cl_emit(cl, BRANCH, branch) {
branch.address = v3dv_cl_address(bo, 0);
}
} else {
v3dv_job_add_bo_unchecked(cl->job, bo);
}
cl->bo = bo;
cl->base = cl->bo->map;
cl->size = cl->bo->size;
cl->next = cl->base;
return true;
}
uint32_t
v3dv_cl_ensure_space(struct v3dv_cl *cl, uint32_t space, uint32_t alignment)
{
uint32_t offset = align(v3dv_cl_offset(cl), alignment);
if (offset + space <= cl->size) {
cl->next = cl->base + offset;
return offset;
}
cl_alloc_bo(cl, space, false);
return 0;
}
void
v3dv_cl_ensure_space_with_branch(struct v3dv_cl *cl, uint32_t space)
{
/* We do not want to emit branches from secondary command lists, instead,
* we will branch to them when we execute them in a primary using
* 'branch to sub list' commands, expecting each linked secondary to
* end with a 'return from sub list' command.
*/
bool needs_return_from_sub_list = false;
if (cl->job->type == V3DV_JOB_TYPE_GPU_CL_SECONDARY && cl->size > 0)
needs_return_from_sub_list = true;
/*
* The CLE processor in the simulator tries to read V3D_CL_MAX_INSTR_SIZE
* bytes form the CL for each new instruction. If the last instruction in our
* CL is smaller than that, and there are not at least V3D_CL_MAX_INSTR_SIZE
* bytes until the end of the BO, it will read out of bounds and possibly
* cause a GMP violation interrupt to trigger. Ensure we always have at
* least that many bytes available to read with the last instruction.
*/
space += V3D_CL_MAX_INSTR_SIZE;
if (v3dv_cl_offset(cl) + space <= cl->size)
return;
if (needs_return_from_sub_list)
cl_emit(cl, RETURN_FROM_SUB_LIST, ret);
cl_alloc_bo(cl, space, !needs_return_from_sub_list);
}