mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-05-16 22:48:05 +02:00
There's a few things going on here: 1. Vulkan makes the YCbCr model and YCbCr range completely orthogonal. This means that we need to be able to handle an identity transform while still doing range-remapping, so we apply the range mapping and color-transform separately, and let the optimizer clean things up. This is similar to what we did before, but it means it's a bit harder to get completely optimal code out of this. 2. Vulkan defines that the YCbCr inputs come in a bit of an unusual order; Cr, Y, Cb. This means we need to reorder things a bit when applying the YCbCr range and multiplying the YCbCr color-model matrix. This makes the code a little bit confusing to read at times. 3. Because the alpha-channel is passed through this function, we need to expand the matrix to 4x3. This is similar to what we've already been doing, but also a bit unusual. In the future, we might want to keep the alpha-channel out of this code-path, and just work on a vec3 here. I suspect that all of these can be solved by rearranging the code a bit. But I've left that as an excercize for later to make sure we get this right first, with as few modifications as possible. Some people might disagree with this approach, but let's see. Reviewed-by: Eric R. Smith <eric.smith@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/40175> |
||
|---|---|---|
| .. | ||
| anti-lag-layer | ||
| device-select-layer | ||
| overlay-layer | ||
| registry | ||
| runtime | ||
| screenshot-layer | ||
| util | ||
| vram-report-limit-layer | ||
| wsi | ||
| meson.build | ||
| vulkan-android.sym | ||
| vulkan-icd-android-symbols.txt | ||
| vulkan-icd-symbols.txt | ||
| vulkan.sym | ||
| vulkan_api.def.in | ||