Yahan Zhou d6af74d9b0 Handle dependency by VkMemoryDedicatedAllocateInfo ... We have a situation that if an image memory is created with VkMemoryDedicatedAllocateInfo, the following commands that refer to the same image must happen in this exact order: vkCreateImage vkAllocateMemory (with dedicated image memory) vkBindImageMemory vkCreateImageView Our previous dependency graph implementation uses Vulkan objects as nodes and does not haven enough granularity to handle this situation. vkCreateImageView can only be executed after an image is created and bound to memory. Our previous dependency graph does not have the notion of "bound to memory". We worked around it by adding vkBindImageMemory as part of the image initialization steps. To make sure we can bind image at initialization, we marked image to be dependent on the memory it bounds to. When adding the new vkAllocateMemory with dedicated image memory extension into the mix, it introduced a circular dependency. vkAllocateMemory will say the memory has dependency on the image. vkBindImageMemory will say the image has dependency on the memory. To properly resolve the issue, we will need to record the state of an Vulkan object, and declare that vkCreateImageView not only depends on an image, but also requires the image to be bound to memory. We do so by introducing a "State" enum and use the pair <VkObjectHandle, State> as the vertex in the deppendency graph. Currently State is an enum with 2 values: CREATED and BOUND_MEMORY. By default, after a VkCreate* command, an object will be in CREATED state. When calling vkBindImageMemory or vkBindBufferMemory it will transform the image or buffer into BOUND_MEMORY state. Then vkCreateImageView will have dependency with {VkImage, BOUND_MEMORY}. Then we can create a dependency graph that looks like this: VkImageView --> {VkImage,BOUND_MEMORY} --> VkMemory | | | ┌-------------------⅃ v v VkImage No more circular dependency. Reviewed-by: Aaron Ruby <aruby@blackberry.com> Acked-by: Yonggang Luo <luoyonggang@gmail.com> Acked-by: Adam Jackson <ajax@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27246>		2024-09-19 20:06:00 +00:00
..
cereal	Handle dependency by VkMemoryDedicatedAllocateInfo	2024-09-19 20:06:00 +00:00
cerealgenerator.py	Revert "Partial revert of aosp/2858589 to avoid Mesa layer for Android"	2024-09-19 20:06:00 +00:00
cgenerator.py
generator.py	gfxstream: vulkan-docs: track feature type	2024-09-19 20:05:58 +00:00
genvk.py	genvk: options.filename --> args.target	2024-09-19 20:05:59 +00:00
reg.py