mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-05-25 01:48:18 +02:00
3a0d1f83d5
Despite being mathematically equivalent, the following code sequences are not bit-identical under IEEE 754 rules due to differing internal precision: fadd16 r0l, r2, 0.0 z = f2f16 x fadd16 r1h, r0l, r0h w = fadd z, y versus fadd32 r1h, r2, r0h f2f16(w) = fadd x, f2f32(y) This is probably fine under GL's relaxed floating point precision rules, but it's definitely not ok with the more strict OpenCL or Vulkan. It also is a potential problem with GL invariance rules, if we get different results for the same shader depending whether we did a monolithic compile or a fast link. The place for doing inexact transformations is NIR, when we have the information available to do so correctly. By the time we get to the backend, everything we do needs to be bit-exact to preserve sanity. Fixes dEQP-GLES2.functional.shaders.algorithm.rgb_to_hsl_vertex. We believe that this is a CTS bug, but it's a useful one since it uncovered a serious driver bug that would bite us in the much less friendly Vulkan (or god forbid OpenCL) CTS later. It also seems like a magnet for GL app bugs, the fp16 support we do now is uncovering bad enough bugs as it is. shader-db results are pretty abysmal, though :| total instructions in shared programs: 1537964 -> 1571328 (2.17%) instructions in affected programs: 670231 -> 703595 (4.98%) total bytes in shared programs: 10533984 -> 10732316 (1.88%) bytes in affected programs: 4662414 -> 4860746 (4.25%) total halfregs in shared programs: 483448 -> 474541 (-1.84%) halfregs in affected programs: 58867 -> 49960 (-15.13%) Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23480> |
||
|---|---|---|
| .. | ||
| test | ||
| agx_builder.h.py | ||
| agx_compile.c | ||
| agx_compile.h | ||
| agx_compiler.h | ||
| agx_dce.c | ||
| agx_debug.h | ||
| agx_insert_waits.c | ||
| agx_internal_formats.h | ||
| agx_ir.c | ||
| agx_liveness.c | ||
| agx_lower_64bit.c | ||
| agx_lower_parallel_copy.c | ||
| agx_lower_pseudo.c | ||
| agx_lower_uniform_sources.c | ||
| agx_minifloat.h | ||
| agx_nir.h | ||
| agx_nir_algebraic.py | ||
| agx_nir_lower_address.c | ||
| agx_nir_lower_discard_zs_emit.c | ||
| agx_nir_lower_frag_sidefx.c | ||
| agx_nir_lower_load_mask.c | ||
| agx_nir_lower_sample_mask.c | ||
| agx_nir_lower_shared_bitsize.c | ||
| agx_nir_lower_texture.c | ||
| agx_nir_lower_ubo.c | ||
| agx_nir_opt_preamble.c | ||
| agx_opcodes.c.py | ||
| agx_opcodes.h.py | ||
| agx_opcodes.py | ||
| agx_opt_cse.c | ||
| agx_optimizer.c | ||
| agx_pack.c | ||
| agx_performance.c | ||
| agx_print.c | ||
| agx_register_allocate.c | ||
| agx_validate.c | ||
| meson.build | ||