mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2025-12-25 21:40:08 +01:00
read-only mirror of https://gitlab.freedesktop.org/mesa/mesa
bc9b2f3781
It doesn't make sense and was not working anyway. This was spotted by Filip Gawin in https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13978 however the fix there was IMO just papering over the problem. I don't believe that this could manifest as a real issues, because when all of the swizzles were constant the file would be set to RC_FILE_NONE already. So in theory this could lead to an issue only in the close to impossible circumstance that the out of bounds memory read by constant->u.Immediate[swz] would end with the same exact value as another inlineable constant in different channel. However in some circumstances it would lead to following valgrind warnings: Conditional jump or move depends on uninitialised value(s) at 0x5D4E690: ieee_754_to_r300_float (radeon_inline_literals.c:61) by 0x5D4E690: rc_inline_literals (radeon_inline_literals.c:133) by 0x5D3877A: rc_run_compiler_passes (radeon_compiler.c:436) by 0x5D38821: rc_run_compiler (radeon_compiler.c:458) by 0x5D4AF63: r3xx_compile_fragment_program (r3xx_fragprog.c:139) by 0x5D48377: r300_translate_fragment_shader (r300_fs.c:499) by 0x5D491B0: r300_pick_fragment_shader (r300_fs.c:601) by 0x5D2BFEE: r300_create_fs_state (r300_state.c:1072) by 0x57DDC36: st_create_nir_shader (st_program.c:538) by 0x57DF10E: st_create_fp_variant (st_program.c:1056) by 0x57E057C: st_get_fp_variant (st_program.c:1102) by 0x57E0AB1: st_precompile_shader_variant (st_program.c:1287) by 0x57E0AB1: st_finalize_program (st_program.c:1333) by 0x57CB6F3: st_link_nir (st_glsl_to_nir.cpp:958) Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com> Reviewed-by: Filip Gawin <filip@gawin.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16657> |
||
|---|---|---|
| .gitlab/issue_templates | ||
| .gitlab-ci | ||
| android | ||
| bin | ||
| build-support | ||
| docs | ||
| include | ||
| src | ||
| subprojects | ||
| .dir-locals.el | ||
| .editorconfig | ||
| .gitattributes | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| .mailmap | ||
| .travis.yml | ||
| CODEOWNERS | ||
| meson.build | ||
| meson_options.txt | ||
| README.rst | ||
| VERSION | ||
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.