mesa/src/intel
Lionel Landwerlin d4b4d69d4d anv: add transfer usage for color/depth/stencil attachments
We sometimes use anv_layout_to_aux_state() to compute the aux state of
an image during the resolve operations at the end of a render
(sub)pass.

If we're dealing with a multisampled image that is created without a
transfer usage, our internal code might trigger a resolve using the
transfer layout (see genX_cmd_buffer.c:cmd_buffer_end_subpass), for
which the image doesn't the usage bit. The current code tries to AND
the 2 usages which won't have any bit in common, thus skipping all
checks below.

v2: Add the transfer usages depending on attachment usage (Lionel)

v3: Limit to samples > 1 (Jason) && DEPTH_STENCIL_ATTACHMENT_BIT (Lionel)

v4: Add transfer usage at image creation (Jason)

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 54b525caf0 ("anv: Rework anv_layout_to_aux_state")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4037
Reviewed-by: Reviewed-by: Tapani Pälli <tapani.palli@intel.com> (v1)
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8307>
2021-01-14 09:51:31 +02:00
..
blorp intel/blorp: use intrinsic builders 2021-01-06 14:34:41 +00:00
common intel/tools: Decode COMPUTE_WALKER 2021-01-13 13:10:27 -08:00
compiler intel/fs: Emit code for Gen12-HP indirect compute data 2021-01-13 13:10:28 -08:00
dev intel/dev: Add gen_device_info_is_12hp 2020-12-01 19:06:22 +00:00
genxml intel/genxml,anv,iris: Drop the legacy compute path from gen125.xml 2021-01-13 13:10:28 -08:00
isl intel/isl: move get_tile dims/masks to common isl header 2020-12-30 06:06:33 +10:00
perf intel: remove dead code 2020-11-02 19:58:56 +00:00
tools intel/tools/aubinator_error_decode: fix small memory leaks 2020-12-09 12:15:56 +00:00
vulkan anv: add transfer usage for color/depth/stencil attachments 2021-01-14 09:51:31 +02:00
Android.blorp.mk intel: android: remove libdrm_intel requirement 2017-03-30 19:07:23 +01:00
Android.common.mk intel: split driver/device UUID generators 2020-10-07 11:11:23 +03:00
Android.compiler.mk android: fix build issues with brw_nir_trig_workarounds.c 2017-10-04 07:39:05 +03:00
Android.dev.mk intel: add identifier for debug purposes 2020-05-20 15:58:22 +00:00
Android.genxml.mk intel/genxml: Build gen 12.5 2020-12-01 19:06:22 +00:00
Android.isl.mk intel/isl: Build gen 12.5 2020-12-01 19:06:22 +00:00
Android.mk i965: extract performance query metrics 2019-04-17 14:10:42 +01:00
Android.perf.mk i965: extract performance query metrics 2019-04-17 14:10:42 +01:00
Android.vulkan.mk intel/anv: Build gen 12.5 2020-12-01 19:06:22 +00:00
Makefile.perf.am i965: extract performance query metrics 2019-04-17 14:10:42 +01:00
Makefile.sources isl: Fix android build 2020-12-05 11:42:15 +00:00
meson.build meson: only build imgui when needed 2019-11-25 07:51:56 +00:00