mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-05-19 04:58:08 +02:00
70728fce57
Split the monolithic v3dv_private.h (~2600 lines) into self-contained sub-headers so each .c file only includes what it needs: v3dv_common.h, v3dv_device.h, v3dv_image.h, v3dv_pass.h, v3dv_query.h, v3dv_pipeline.h, v3dv_descriptor_set.h, v3dv_cmd_buffer.h, v3dv_version_dispatch.h As part of this commit we remove v3dv_private.h. We keep v3dvx_private.h as it is, because the gain would be really small (a lot of really small sub-headers). In addition to keep things more tidy, we made a quick performance check. We measured how many files are re-compiled and the performance difference when touching one of the headers, compared with keeping just one monolithic header. Header touch (incremental) Split Monolithic Speedup -------------------------- ----- ---------- ------- v3dv_image.h 2369 (24f) 2436 (33f) 1.03x v3dv_query.h 2357 (20f) 2436 (33f) 1.03x v3dv_pass.h 2352 (20f) 2436 (33f) 1.04x v3dv_cmd_buffer.h 2354 (20f) 2436 (33f) 1.03x v3dv_descriptor_set.h 2436 (33f) 2436 (33f) 1.00x v3dv_pipeline.h 2437 (33f) 2436 (33f) 1.00x v3dv_device.h 2418 (31f) 2436 (33f) 1.01x v3dv_common.h 2419 (33f) 2436 (33f) 1.01x v3dv_version_dispatch.h 2371 (26f) 2436 (33f) 1.03x Header touch (incremental) Split Monolithic Speedup -------------------------- ---------- ---------- ------- v3dv_image.h 2377 (24f) 2443 (33f) 1.03x v3dv_query.h 2346 (20f) 2443 (33f) 1.04x v3dv_pass.h 2360 (20f) 2443 (33f) 1.04x v3dv_cmd_buffer.h 2351 (20f) 2443 (33f) 1.04x v3dv_descriptor_set.h 2438 (33f) 2443 (33f) 1.00x v3dv_pipeline.h 2429 (33f) 2443 (33f) 1.01x v3dv_device.h 2418 (31f) 2443 (33f) 1.01x v3dv_common.h 2432 (33f) 2443 (33f) 1.00x v3dv_version_dispatch.h 2373 (26f) 2443 (33f) 1.03x The bigger gain is on the files recompiled for some headers (going from 33 down to 20 in some cases). The performance gain is not so relevant though. Acked-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/40169>
65 lines
2 KiB
C
65 lines
2 KiB
C
/*
|
|
* Copyright © 2026 Raspberry Pi Ltd
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*/
|
|
#ifndef V3DV_VERSION_DISPATCH_H
|
|
#define V3DV_VERSION_DISPATCH_H
|
|
|
|
#include "common/v3d_tiling.h"
|
|
#include "common/v3d_util.h"
|
|
|
|
#ifdef V3D_VERSION
|
|
#include "common/v3d_macros.h"
|
|
#endif
|
|
|
|
struct v3dv_bo;
|
|
struct v3dv_buffer;
|
|
struct v3dv_buffer_view;
|
|
struct v3dv_cmd_buffer;
|
|
struct v3dv_cmd_buffer_attachment_state;
|
|
struct v3dv_device;
|
|
struct v3dv_draw_info;
|
|
struct v3dv_format;
|
|
struct v3dv_format_plane;
|
|
struct v3dv_frame_tiling;
|
|
struct v3dv_framebuffer;
|
|
struct v3dv_image;
|
|
struct v3dv_image_view;
|
|
struct v3dv_job;
|
|
struct v3dv_meta_framebuffer;
|
|
struct v3dv_pipeline;
|
|
struct v3dv_sampler;
|
|
struct v3dv_subpass;
|
|
union v3dv_clear_value;
|
|
|
|
#ifdef v3dX
|
|
# include "v3dvx_private.h"
|
|
#else
|
|
# define v3dX(x) v3d42_##x
|
|
# include "v3dvx_private.h"
|
|
# undef v3dX
|
|
|
|
# define v3dX(x) v3d71_##x
|
|
# include "v3dvx_private.h"
|
|
# undef v3dX
|
|
#endif
|
|
|
|
#endif /* V3DV_VERSION_DISPATCH_H */
|