mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2025-12-24 15:20:10 +01:00
read-only mirror of https://gitlab.freedesktop.org/mesa/mesa
8c6b9b9c92
For some unknown reason, waiting for general slots (at least for memory stores) doesn't work properly on a BARRIER instruction. We need to wait for all general slots right before issuing the BARRIER in addition to the general wait on the BARRIER itself. I don't know if this is a hardware bug or some hideous gate-saving quirk, but I observe the Mali-G78 DDK using the same workaround, which implies this really is necessary. Fixes rare flakes in: dEQP-GLES31.functional.compute.shared_var.work_group_size.float_128_1_1 Note that the flakes from that test are extremely timing dependent. Without this change, that test is racy but we almost always win the race. Reproducing the issue reliably requires high system load (e.g. running the CTS in the background) and simultaneously running that test a large number of times. Minimal shader-db impact. In particular, no cycle count regressions. total instructions in shared programs: 2699419 -> 2699458 (<.01%) instructions in affected programs: 22014 -> 22053 (0.18%) helped: 2 HURT: 25 helped stats (abs) min: 1.0 max: 1.0 x̄: 1.00 x̃: 1 helped stats (rel) min: 0.12% max: 0.12% x̄: 0.12% x̃: 0.12% HURT stats (abs) min: 1.0 max: 3.0 x̄: 1.64 x̃: 1 HURT stats (rel) min: 0.07% max: 2.82% x̄: 0.69% x̃: 0.49% 95% mean confidence interval for instructions value: 1.01 1.87 95% mean confidence interval for instructions %-change: 0.38% 0.88% Instructions are HURT. total cvt in shared programs: 14468.81 -> 14469.42 (<.01%) cvt in affected programs: 221.33 -> 221.94 (0.28%) helped: 2 HURT: 25 helped stats (abs) min: 0.015625 max: 0.015625 x̄: 0.02 x̃: 0 helped stats (rel) min: 0.18% max: 0.18% x̄: 0.18% x̃: 0.18% HURT stats (abs) min: 0.015625 max: 0.046875 x̄: 0.03 x̃: 0 HURT stats (rel) min: 0.10% max: 4.44% x̄: 1.06% x̃: 0.79% 95% mean confidence interval for cvt value: 0.02 0.03 95% mean confidence interval for cvt %-change: 0.57% 1.36% Cvt are HURT. total quadwords in shared programs: 1462496 -> 1462528 (<.01%) quadwords in affected programs: 4632 -> 4664 (0.69%) helped: 0 HURT: 4 HURT stats (abs) min: 8.0 max: 8.0 x̄: 8.00 x̃: 8 HURT stats (rel) min: 0.35% max: 7.69% x̄: 4.03% x̃: 4.03% 95% mean confidence interval for quadwords value: 8.00 8.00 95% mean confidence interval for quadwords %-change: -2.71% 10.76% Inconclusive result (%-change mean confidence interval includes 0). Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17091> |
||
|---|---|---|
| .github/workflows | ||
| .gitlab/issue_templates | ||
| .gitlab-ci | ||
| android | ||
| bin | ||
| build-support | ||
| docs | ||
| include | ||
| src | ||
| subprojects | ||
| .dir-locals.el | ||
| .editorconfig | ||
| .gitattributes | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| .mailmap | ||
| CODEOWNERS | ||
| meson.build | ||
| meson_options.txt | ||
| README.rst | ||
| VERSION | ||
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.