mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2025-12-22 17:50:12 +01:00
ddf2aa3a4d
In the C23 standard unreachable() is now a predefined function-like macro in <stddef.h> See https://android.googlesource.com/platform/bionic/+/HEAD/docs/c23.md#is-now-a-predefined-function_like-macro-in And this causes build errors when building for C23: ----------------------------------------------------------------------- In file included from ../src/util/log.h:30, from ../src/util/log.c:30: ../src/util/macros.h:123:9: warning: "unreachable" redefined 123 | #define unreachable(str) \ | ^~~~~~~~~~~ In file included from ../src/util/macros.h:31: /usr/lib/gcc/x86_64-linux-gnu/14/include/stddef.h:456:9: note: this is the location of the previous definition 456 | #define unreachable() (__builtin_unreachable ()) | ^~~~~~~~~~~ ----------------------------------------------------------------------- So don't redefine it with the same name, but use the name UNREACHABLE() to also signify it's a macro. Using a different name also makes sense because the behavior of the macro was extending the one of __builtin_unreachable() anyway, and it also had a different signature, accepting one argument, compared to the standard unreachable() with no arguments. This change improves the chances of building mesa with the C23 standard, which for instance is the default in recent AOSP versions. All the instances of the macro, including the definition, were updated with the following command line: git grep -l '[^_]unreachable(' -- "src/**" | sort | uniq | \ while read file; \ do \ sed -e 's/\([^_]\)unreachable(/\1UNREACHABLE(/g' -i "$file"; \ done && \ sed -e 's/#undef unreachable/#undef UNREACHABLE/g' -i src/intel/isl/isl_aux_info.c Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36437>
83 lines
2.9 KiB
C++
83 lines
2.9 KiB
C++
/*
|
|
* Copyright © 2015 Connor Abbott
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*/
|
|
|
|
#include "util/half_float.h"
|
|
#include "brw_shader.h"
|
|
#include "brw_cfg.h"
|
|
#include "brw_builder.h"
|
|
|
|
bool
|
|
brw_lower_pack(brw_shader &s)
|
|
{
|
|
bool progress = false;
|
|
|
|
foreach_block_and_inst_safe(block, brw_inst, inst, s.cfg) {
|
|
if (inst->opcode != FS_OPCODE_PACK &&
|
|
inst->opcode != FS_OPCODE_PACK_HALF_2x16_SPLIT)
|
|
continue;
|
|
|
|
assert(inst->dst.file == VGRF);
|
|
assert(inst->saturate == false);
|
|
brw_reg dst = inst->dst;
|
|
|
|
const brw_builder ibld(inst);
|
|
/* The lowering generates 2 instructions for what was previously 1. This
|
|
* can trick the IR to believe we're doing partial writes, but the
|
|
* register is actually fully written. Mark it as undef to help the IR
|
|
* reduce the liveness of the register.
|
|
*/
|
|
if (!inst->is_partial_write())
|
|
ibld.emit_undef_for_dst(inst);
|
|
|
|
switch (inst->opcode) {
|
|
case FS_OPCODE_PACK:
|
|
for (unsigned i = 0; i < inst->sources; i++)
|
|
ibld.MOV(subscript(dst, inst->src[i].type, i), inst->src[i]);
|
|
break;
|
|
case FS_OPCODE_PACK_HALF_2x16_SPLIT:
|
|
assert(dst.type == BRW_TYPE_UD);
|
|
|
|
for (unsigned i = 0; i < inst->sources; i++) {
|
|
if (inst->src[i].file == IMM) {
|
|
const uint32_t half = _mesa_float_to_half(inst->src[i].f);
|
|
ibld.MOV(subscript(dst, BRW_TYPE_UW, i),
|
|
brw_imm_uw(half));
|
|
} else {
|
|
ibld.MOV(subscript(dst, BRW_TYPE_HF, i),
|
|
inst->src[i]);
|
|
}
|
|
}
|
|
break;
|
|
default:
|
|
UNREACHABLE("skipped above");
|
|
}
|
|
|
|
inst->remove();
|
|
progress = true;
|
|
}
|
|
|
|
if (progress)
|
|
s.invalidate_analysis(BRW_DEPENDENCY_INSTRUCTIONS);
|
|
|
|
return progress;
|
|
}
|