mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-05-22 02:18:10 +02:00
9c2a11430e
This commit completely rewrites the way we extract a structured CFG from
SPIR-V. The new approach is different in a few ways:
1. It does a breadth-first search instead of depth-first. This means
that we've visited the merge node for a construct before we visit
any of the nodes inside the construct. This makes it easier to
validate things like loop and switch nesting.
2. We record more information in the CFG. Earlier commits added a
parent pointer to vtn_cf_node but we now record all of the merge and
other special blocks for each CFG node. This lets us validate
things more precisely.
3. It makes heavy use of merge blocks for walking the CFG. Previously,
we sort of used them as hints for trying to guess the CFG structure
but things got dicey whenever a merge was missing. We had some
heuristics for how to handle short-circuiting if statements but it
was a bunch of special cases.
Now, we make them a fundamental part of walking the CFG. When we
encounter a control-flow construct, we add the body components of
the construct to the BFS work list and then jump to the merge block
if one exists to continue scanning the current CFG nesting level.
If no merge block exists, we assume that means that control-flow
never re-converges in a normal way and that the only way to get back
to normality is with a direct jump such as a loop break or continue.
This should make things far more robust when trying to deal with the
more creative placement (or lack thereof) of merge instructions.
Reviewed-by: Alan Baker <alanbaker@google.com>
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3820>
Closes: #2760
Acked-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4446>
|
||
|---|---|---|
| .. | ||
| gl_spirv.c | ||
| GLSL.ext.AMD.h | ||
| GLSL.std.450.h | ||
| meson.build | ||
| nir_spirv.h | ||
| OpenCL.std.h | ||
| spirv.core.grammar.json | ||
| spirv.h | ||
| spirv2nir.c | ||
| spirv_info.h | ||
| spirv_info_c.py | ||
| spirv_to_nir.c | ||
| vtn_alu.c | ||
| vtn_amd.c | ||
| vtn_cfg.c | ||
| vtn_gather_types_c.py | ||
| vtn_glsl450.c | ||
| vtn_opencl.c | ||
| vtn_private.h | ||
| vtn_subgroup.c | ||
| vtn_variables.c | ||