mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-05-26 12:28:12 +02:00
23c86c74cc
Add a new bool, _EGLSurface::Lost, and check it in eglMakeCurrent and eglSwapBuffers. The EGL 1.5 spec says that those functions emit errors when the native surface is no longer valid. This patch just updates core EGL. No driver sets _EGLSurface::Lost yet. I discovered that Mesa failed to detect lost surfaces while debugging an Android CTS camera test, android.hardware.camera2.cts.RobustnessTest#testAbandonRepeatingRequestSurface. This patch doesn't fix the test though, though, because the test expects EGL_BAD_SURFACE when the surface becomes lost, and this patch actually complies with the EGL spec. If I interpreted the EGL spec correctly, EGL_BAD_NATIVE_WINDOW or EGL_BAD_CURRENT_SURFACE is the correct error. Cc: mesa-stable@lists.freedesktop.org Cc: Tomasz Figa <tfiga@chromium.org> Cc: Tapani Pälli <tapani.palli@intel.com> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-by: Emil Velikov <emil.velikov@collabora.com> |
||
|---|---|---|
| .. | ||
| 50_mesa.json | ||
| egl.def | ||
| egl.pc.in | ||
| eglapi.c | ||
| eglapi.h | ||
| eglarray.c | ||
| eglarray.h | ||
| eglcompiler.h | ||
| eglconfig.c | ||
| eglconfig.h | ||
| eglcontext.c | ||
| eglcontext.h | ||
| eglcurrent.c | ||
| eglcurrent.h | ||
| egldefines.h | ||
| egldispatchstubs.c | ||
| egldispatchstubs.h | ||
| egldisplay.c | ||
| egldisplay.h | ||
| egldriver.c | ||
| egldriver.h | ||
| eglentrypoint.h | ||
| eglfallbacks.c | ||
| eglglobals.c | ||
| eglglobals.h | ||
| eglglvnd.c | ||
| eglimage.c | ||
| eglimage.h | ||
| egllog.c | ||
| egllog.h | ||
| eglsurface.c | ||
| eglsurface.h | ||
| eglsync.c | ||
| eglsync.h | ||
| egltypedefs.h | ||
| README.txt | ||
Notes about the EGL library: The EGL code here basically consists of two things: 1. An EGL API dispatcher. This directly routes all the eglFooBar() API calls into driver-specific functions. 2. Fallbacks for EGL API functions. A driver _could_ implement all the EGL API calls from scratch. But in many cases, the fallbacks provided in libEGL (such as eglChooseConfig()) will do the job. Bootstrapping: When the apps calls eglInitialize() a device driver is selected and loaded (look for _eglAddDrivers() and _eglLoadModule() in egldriver.c). The built-in driver's entry point function is then called. This driver function allocates, initializes and returns a new _EGLDriver object (usually a subclass of that type). As part of initialization, the dispatch table in _EGLDriver->API must be populated with all the EGL entrypoints. Typically, _eglInitDriverFallbacks() can be used to plug in default/fallback functions. Some functions like driver->API.Initialize and driver->API.Terminate _must_ be implemented with driver-specific code (no default/fallback function is possible). Shortly after, the driver->API.Initialize() function is executed. Any additional driver initialization that wasn't done in the driver entry point should be done at this point. Typically, this will involve setting up visual configs, etc. Special Functions: Certain EGL functions _must_ be implemented by the driver. This includes: eglCreateContext eglCreateWindowSurface eglCreatePixmapSurface eglCreatePBufferSurface eglMakeCurrent eglSwapBuffers Most of the EGLConfig-related functions can be implemented with the defaults/fallbacks. Same thing for the eglGet/Query functions. Teardown: When eglTerminate() is called, the driver->API.Terminate() function is called. The driver should clean up after itself. eglTerminate() will then close/unload the driver (shared library). Subclassing: The internal libEGL data structures such as _EGLDisplay, _EGLContext, _EGLSurface, etc should be considered base classes from which drivers will derive subclasses.