mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-05-24 23:38:10 +02:00
05e9e7767d
When I originally added vk_image_view, I was overly clever when it came
to the format field. I decided to make it only contain the bits of the
format contained in the selected aspects. However, this is confusing
(not generally a good thing) and it's also not always what you want.
The Vulkan 1.3.204 spec says:
"When using an image view of a depth/stencil image to populate a
descriptor set (e.g. for sampling in the shader, or for use as an
input attachment), the aspectMask must only include one bit, which
selects whether the image view is used for depth reads (i.e. using a
floating-point sampler or input attachment in the shader) or stencil
reads (i.e. using an unsigned integer sampler or input attachment in
the shader). When an image view of a depth/stencil image is used as
a depth/stencil framebuffer attachment, the aspectMask is ignored
and both depth and stencil image subresources are used."
So, while the restricted format makes sense for texturing, it doesn't
for when the image is being used as an attachment. What we probably
actually want is both versions of the format. We'll call the one given
by the VkImageViewCreateInfo vk_image_view::format and the restricted
one vk_image_view::view_format.
This is just the first commit which switches format to view_format so
the compiler will make sure we get them all. The next commit will
re-add vk_image_view::format but this time unmodified.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15007>
|
||
|---|---|---|
| .. | ||
| .dir-locals.el | ||
| .editorconfig | ||
| meson.build | ||
| v3dv_android.c | ||
| v3dv_bo.c | ||
| v3dv_bo.h | ||
| v3dv_cl.c | ||
| v3dv_cl.h | ||
| v3dv_cmd_buffer.c | ||
| v3dv_debug.c | ||
| v3dv_debug.h | ||
| v3dv_descriptor_set.c | ||
| v3dv_device.c | ||
| v3dv_formats.c | ||
| v3dv_image.c | ||
| v3dv_limits.h | ||
| v3dv_meta_clear.c | ||
| v3dv_meta_common.h | ||
| v3dv_meta_copy.c | ||
| v3dv_pass.c | ||
| v3dv_pipeline.c | ||
| v3dv_pipeline_cache.c | ||
| v3dv_private.h | ||
| v3dv_query.c | ||
| v3dv_queue.c | ||
| v3dv_uniforms.c | ||
| v3dv_wsi.c | ||
| v3dvx_cmd_buffer.c | ||
| v3dvx_descriptor_set.c | ||
| v3dvx_device.c | ||
| v3dvx_formats.c | ||
| v3dvx_image.c | ||
| v3dvx_meta_common.c | ||
| v3dvx_pipeline.c | ||
| v3dvx_private.h | ||
| v3dvx_queue.c | ||