mesa/src/compiler/glsl/opt_tree_grafting.cpp
Timothy Arceri e2e2c5abd2 glsl: calculate number of operands in an expression once
Extra validation is added to ir_validate to make sure this is
always updated to the correct numer of operands, as passes like
lower_instructions modify the instructions directly rather then
generating a new one.

The reduction in time is so small that it is not really
measurable. However callgrind was reporting this function as
being called just under 34 million times while compiling the
Deus Ex shaders (just pre-linking was profiled) with 0.20%
spent in this function.

v2:
 - make num_operands a unit8_t
 - fix unsigned/signed mismatches

Reviewed-by: Thomas Helland <thomashelland90@gmail.com>
2017-08-11 10:43:12 +10:00

419 lines
11 KiB
C++

/*
* Copyright © 2010 Intel Corporation
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
* to deal in the Software without restriction, including without limitation
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
* and/or sell copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice (including the next
* paragraph) shall be included in all copies or substantial portions of the
* Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
* DEALINGS IN THE SOFTWARE.
*/
/**
* \file opt_tree_grafting.cpp
*
* Takes assignments to variables that are dereferenced only once and
* pastes the RHS expression into where the variable is dereferenced.
*
* In the process of various operations like function inlining and
* tertiary op handling, we'll end up with our expression trees having
* been chopped up into a series of assignments of short expressions
* to temps. Other passes like ir_algebraic.cpp would prefer to see
* the deepest expression trees they can to try to optimize them.
*
* This is a lot like copy propagaton. In comparison, copy
* propagation only acts on plain copies, not arbitrary expressions on
* the RHS. Generally, we wouldn't want to go pasting some
* complicated expression everywhere it got used, though, so we don't
* handle expressions in that pass.
*
* The hard part is making sure we don't move an expression across
* some other assignments that would change the value of the
* expression. So we split this into two passes: First, find the
* variables in our scope which are written to once and read once, and
* then go through basic blocks seeing if we find an opportunity to
* move those expressions safely.
*/
#include "ir.h"
#include "ir_visitor.h"
#include "ir_variable_refcount.h"
#include "ir_basic_block.h"
#include "ir_optimization.h"
#include "compiler/glsl_types.h"
namespace {
static bool debug = false;
class ir_tree_grafting_visitor : public ir_hierarchical_visitor {
public:
ir_tree_grafting_visitor(ir_assignment *graft_assign,
ir_variable *graft_var)
{
this->progress = false;
this->graft_assign = graft_assign;
this->graft_var = graft_var;
}
virtual ir_visitor_status visit_leave(class ir_assignment *);
virtual ir_visitor_status visit_enter(class ir_call *);
virtual ir_visitor_status visit_enter(class ir_expression *);
virtual ir_visitor_status visit_enter(class ir_function *);
virtual ir_visitor_status visit_enter(class ir_function_signature *);
virtual ir_visitor_status visit_enter(class ir_if *);
virtual ir_visitor_status visit_enter(class ir_loop *);
virtual ir_visitor_status visit_enter(class ir_swizzle *);
virtual ir_visitor_status visit_enter(class ir_texture *);
ir_visitor_status check_graft(ir_instruction *ir, ir_variable *var);
bool do_graft(ir_rvalue **rvalue);
bool progress;
ir_variable *graft_var;
ir_assignment *graft_assign;
};
struct find_deref_info {
ir_variable *var;
bool found;
};
void
dereferences_variable_callback(ir_instruction *ir, void *data)
{
struct find_deref_info *info = (struct find_deref_info *)data;
ir_dereference_variable *deref = ir->as_dereference_variable();
if (deref && deref->var == info->var)
info->found = true;
}
static bool
dereferences_variable(ir_instruction *ir, ir_variable *var)
{
struct find_deref_info info;
info.var = var;
info.found = false;
visit_tree(ir, dereferences_variable_callback, &info);
return info.found;
}
bool
ir_tree_grafting_visitor::do_graft(ir_rvalue **rvalue)
{
if (!*rvalue)
return false;
ir_dereference_variable *deref = (*rvalue)->as_dereference_variable();
if (!deref || deref->var != this->graft_var)
return false;
if (debug) {
fprintf(stderr, "GRAFTING:\n");
this->graft_assign->fprint(stderr);
fprintf(stderr, "\n");
fprintf(stderr, "TO:\n");
(*rvalue)->fprint(stderr);
fprintf(stderr, "\n");
}
this->graft_assign->remove();
*rvalue = this->graft_assign->rhs;
this->progress = true;
return true;
}
ir_visitor_status
ir_tree_grafting_visitor::visit_enter(ir_loop *ir)
{
(void)ir;
/* Do not traverse into the body of the loop since that is a
* different basic block.
*/
return visit_stop;
}
/**
* Check if we can continue grafting after writing to a variable. If the
* expression we're trying to graft references the variable, we must stop.
*
* \param ir An instruction that writes to a variable.
* \param var The variable being updated.
*/
ir_visitor_status
ir_tree_grafting_visitor::check_graft(ir_instruction *ir, ir_variable *var)
{
if (dereferences_variable(this->graft_assign->rhs, var)) {
if (debug) {
fprintf(stderr, "graft killed by: ");
ir->fprint(stderr);
fprintf(stderr, "\n");
}
return visit_stop;
}
return visit_continue;
}
ir_visitor_status
ir_tree_grafting_visitor::visit_leave(ir_assignment *ir)
{
if (do_graft(&ir->rhs) ||
do_graft(&ir->condition))
return visit_stop;
/* If this assignment updates a variable used in the assignment
* we're trying to graft, then we're done.
*/
return check_graft(ir, ir->lhs->variable_referenced());
}
ir_visitor_status
ir_tree_grafting_visitor::visit_enter(ir_function *ir)
{
(void) ir;
return visit_continue_with_parent;
}
ir_visitor_status
ir_tree_grafting_visitor::visit_enter(ir_function_signature *ir)
{
(void)ir;
return visit_continue_with_parent;
}
ir_visitor_status
ir_tree_grafting_visitor::visit_enter(ir_call *ir)
{
foreach_two_lists(formal_node, &ir->callee->parameters,
actual_node, &ir->actual_parameters) {
ir_variable *sig_param = (ir_variable *) formal_node;
ir_rvalue *ir = (ir_rvalue *) actual_node;
ir_rvalue *new_ir = ir;
if (sig_param->data.mode != ir_var_function_in
&& sig_param->data.mode != ir_var_const_in) {
if (check_graft(ir, sig_param) == visit_stop)
return visit_stop;
continue;
}
if (do_graft(&new_ir)) {
ir->replace_with(new_ir);
return visit_stop;
}
}
if (ir->return_deref && check_graft(ir, ir->return_deref->var) == visit_stop)
return visit_stop;
return visit_continue;
}
ir_visitor_status
ir_tree_grafting_visitor::visit_enter(ir_expression *ir)
{
for (unsigned int i = 0; i < ir->num_operands; i++) {
if (do_graft(&ir->operands[i]))
return visit_stop;
}
return visit_continue;
}
ir_visitor_status
ir_tree_grafting_visitor::visit_enter(ir_if *ir)
{
if (do_graft(&ir->condition))
return visit_stop;
/* Do not traverse into the body of the if-statement since that is a
* different basic block.
*/
return visit_continue_with_parent;
}
ir_visitor_status
ir_tree_grafting_visitor::visit_enter(ir_swizzle *ir)
{
if (do_graft(&ir->val))
return visit_stop;
return visit_continue;
}
ir_visitor_status
ir_tree_grafting_visitor::visit_enter(ir_texture *ir)
{
if (do_graft(&ir->coordinate) ||
do_graft(&ir->projector) ||
do_graft(&ir->offset) ||
do_graft(&ir->shadow_comparator))
return visit_stop;
switch (ir->op) {
case ir_tex:
case ir_lod:
case ir_query_levels:
case ir_texture_samples:
case ir_samples_identical:
break;
case ir_txb:
if (do_graft(&ir->lod_info.bias))
return visit_stop;
break;
case ir_txf:
case ir_txl:
case ir_txs:
if (do_graft(&ir->lod_info.lod))
return visit_stop;
break;
case ir_txf_ms:
if (do_graft(&ir->lod_info.sample_index))
return visit_stop;
break;
case ir_txd:
if (do_graft(&ir->lod_info.grad.dPdx) ||
do_graft(&ir->lod_info.grad.dPdy))
return visit_stop;
break;
case ir_tg4:
if (do_graft(&ir->lod_info.component))
return visit_stop;
break;
}
return visit_continue;
}
struct tree_grafting_info {
ir_variable_refcount_visitor *refs;
bool progress;
};
static bool
try_tree_grafting(ir_assignment *start,
ir_variable *lhs_var,
ir_instruction *bb_last)
{
ir_tree_grafting_visitor v(start, lhs_var);
if (debug) {
fprintf(stderr, "trying to graft: ");
lhs_var->fprint(stderr);
fprintf(stderr, "\n");
}
for (ir_instruction *ir = (ir_instruction *)start->next;
ir != bb_last->next;
ir = (ir_instruction *)ir->next) {
if (debug) {
fprintf(stderr, "- ");
ir->fprint(stderr);
fprintf(stderr, "\n");
}
ir_visitor_status s = ir->accept(&v);
if (s == visit_stop)
return v.progress;
}
return false;
}
static void
tree_grafting_basic_block(ir_instruction *bb_first,
ir_instruction *bb_last,
void *data)
{
struct tree_grafting_info *info = (struct tree_grafting_info *)data;
ir_instruction *ir, *next;
for (ir = bb_first, next = (ir_instruction *)ir->next;
ir != bb_last->next;
ir = next, next = (ir_instruction *)ir->next) {
ir_assignment *assign = ir->as_assignment();
if (!assign)
continue;
ir_variable *lhs_var = assign->whole_variable_written();
if (!lhs_var)
continue;
if (lhs_var->data.mode == ir_var_function_out ||
lhs_var->data.mode == ir_var_function_inout ||
lhs_var->data.mode == ir_var_shader_out ||
lhs_var->data.mode == ir_var_shader_storage ||
lhs_var->data.mode == ir_var_shader_shared)
continue;
if (lhs_var->data.precise)
continue;
/* Do not graft sampler and image variables. This is a workaround to
* st/glsl_to_tgsi being unable to handle expression parameters to image
* intrinsics.
*
* Note that if this is ever fixed, we still need to skip grafting when
* any image layout qualifiers (including the image format) are set,
* since we must not lose those.
*/
if (lhs_var->type->is_sampler() || lhs_var->type->is_image())
continue;
ir_variable_refcount_entry *entry = info->refs->get_variable_entry(lhs_var);
if (!entry->declaration ||
entry->assigned_count != 1 ||
entry->referenced_count != 2)
continue;
/* Found a possibly graftable assignment. Now, walk through the
* rest of the BB seeing if the deref is here, and if nothing interfered with
* pasting its expression's values in between.
*/
info->progress |= try_tree_grafting(assign, lhs_var, bb_last);
}
}
} /* unnamed namespace */
/**
* Does a copy propagation pass on the code present in the instruction stream.
*/
bool
do_tree_grafting(exec_list *instructions)
{
ir_variable_refcount_visitor refs;
struct tree_grafting_info info;
info.progress = false;
info.refs = &refs;
visit_list_elements(info.refs, instructions);
call_for_basic_blocks(instructions, tree_grafting_basic_block, &info);
return info.progress;
}