Timothy Arceri d75a36a9ee glsl: remove do_copy_propagation_elements() optimisation pass ... Since 13b859de do_copy_propagation_elements() has a flaw where the time it takes to complete grows exponentially slowers as the number of nested loops increases. It can also hurt rather than help verses just letting NIR optimise the code. So if the NIR linker is enabled we let it handle it instead. shader-db results Iris (BDW): total instructions in shared programs: 11177181 -> 11199739 (0.20%) instructions in affected programs: 119424 -> 141982 (18.89%) helped: 109 HURT: 65 total cycles in shared programs: 368946819 -> 372277173 (0.90%) cycles in affected programs: 116539428 -> 119869782 (2.86%) total spills in shared programs: 3983 -> 8785 (120.56%) spills in affected programs: 2072 -> 6874 (231.76%) helped: 0 HURT: 6 total fills in shared programs: 2016 -> 6068 (200.99%) fills in affected programs: 230 -> 4282 (1761.74%) helped: 0 HURT: 6 LOST: 85 GAINED: 77 freedreno results: total instructions in shared programs: 11011122 -> 11011620 (<.01%) instructions in affected programs: 939829 -> 940327 (0.05%) total full in shared programs: 762725 -> 762674 (<.01%) full in affected programs: 1096 -> 1045 (-4.65%) total constlen in shared programs: 1772092 -> 1771596 (-0.03%) constlen in affected programs: 2780 -> 2284 (-17.84%) total stp in shared programs: 4040 -> 4058 (0.45%) stp in affected programs: 3656 -> 3674 (0.49%) total ldp in shared programs: 2160 -> 2178 (0.83%) ldp in affected programs: 1748 -> 1766 (1.03%) stp HURT: shaders/robclark-shaders/gfxbench5/gl_5_high_off/13.shader_test CL: 1231 -> 1234 (0.24%) stp HURT: shaders/robclark-shaders/gfxbench5/gl_5_normal_off/13.shader_test CL: 1231 -> 1234 (0.24%) stp HURT: shaders/robclark-shaders/gfxbench5/gl_5_high_off/15.shader_test CL: 453 -> 456 (0.66%) stp HURT: shaders/robclark-shaders/gfxbench5/gl_5_normal_off/15.shader_test CL: 453 -> 456 (0.66%) stp HURT: shaders/robclark-shaders/gfxbench5/gl_5_high_off/17.shader_test CL: 144 -> 147 (2.08%) stp HURT: shaders/robclark-shaders/gfxbench5/gl_5_normal_off/17.shader_test CL: 144 -> 147 (2.08%) however, those stp counts are misleading -- gfxbench gl-5-normal actually gets its scratch (ldp/stp) stored as 16 bits instead of 32 thanks to better NIR copy prop, and the result is 2.64398% +/- 0.0991923% perf improvement! i915 results: total instructions in shared programs: 510528 -> 510489 (<.01%) instructions in affected programs: 3303 -> 3264 (-1.18%) total tex_indirect in shared programs: 16708 -> 16717 (0.05%) tex_indirect in affected programs: 134 -> 143 (6.72%) total temps in shared programs: 30181 -> 30169 (-0.04%) temps in affected programs: 1268 -> 1256 (-0.95%) LOST: 0 GAINED: 1 i915 highlights: instructions HURT: shaders/closed/steam/legend-of-grimrock/47.shader_test FS: 141 -> 144 (2.13%) instructions HURT: shaders/closed/steam/steamworld-dig/22.shader_test FS: 84 -> 108 (28.57%) temps HURT: shaders/closed/steam/left-4-dead-2/medium/3682.shader_test FS: 7 -> 13 (85.71%) r300 results: total instructions in shared programs: 1340439 -> 1340845 (0.03%) instructions in affected programs: 32354 -> 32760 (1.25%) total temps in shared programs: 179394 -> 179329 (-0.04%) temps in affected programs: 1505 -> 1440 (-4.32%) total consts in shared programs: 1177742 -> 1177885 (0.01%) consts in affected programs: 1107 -> 1250 (12.92%) total lits in shared programs: 24992 -> 25019 (0.11%) lits in affected programs: 138 -> 165 (19.57%) instructions HURT: shaders/closed/steam/legend-of-grimrock/26.shader_test FS: 47 -> 52 (10.64%) instructions HURT: shaders/closed/steam/sanctum-2/6072.shader_test FS: 43 -> 48 (11.63%) instructions HURT: shaders/closed/steam/champions-of-regnum/2378.shader_test VS: 35 -> 40 (14.29%) Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13288>		2023-03-01 16:09:25 +00:00
..
clc	clc: Include opencl-c-base.h with LLVM 15 (using builtins)	2023-02-11 05:24:08 +00:00
glsl	glsl: remove do_copy_propagation_elements() optimisation pass	2023-03-01 16:09:25 +00:00
isaspec	ir3, isaspec: add raw instruction to assembler/disassembler.	2023-01-26 14:26:11 +00:00
nir	nir/split_64bit_vec3_and_vec4: Handle 64-bit matrix types.	2023-03-01 16:09:25 +00:00
spirv	spirv: Add skip_os_break_in_debug_build option to use in unit tests	2023-03-01 13:47:57 +00:00
builtin_type_macros.h	glsl: add texture subpass variants	2022-11-10 10:21:34 +00:00
glsl_types.cpp	compiler: Handle nested arrays correctly for computing CL size/alignment	2022-12-02 09:52:44 -08:00
glsl_types.h	glsl: Remove the need of _MTX_INITIALIZER_NP by using simple_mtx_t/SIMPLE_MTX_INITIALIZER	2022-11-09 04:38:28 +00:00
meson.build	spirv/tests: Add some basic control flow tests	2023-03-01 13:47:57 +00:00
nir_gl_types.h	mesa: #include "util/glheader.h" instead GL/gl.h in shared code	2022-11-03 16:07:31 +00:00
nir_types.cpp	nir/types: Add some asserts to glsl_get_struct_field()	2022-11-01 14:48:41 +00:00
nir_types.h	nir: Add a pass to lower mediump temps and shared mem.	2022-09-01 22:39:39 +00:00
shader_enums.c	nir+ir3: Rename load_size_ir3 to load_center_rhw_ir3.	2022-07-11 16:56:05 +00:00
shader_enums.h	nir: lower image add lower_to_fragment_mask_load_amd option	2022-12-19 09:22:16 +08:00
shader_info.h	spirv: Implement SPV_KHR_subgroup_rotate	2023-02-24 06:33:51 +00:00