mesa/bin
Vinson Lee 191e4b8fe0
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
bin/symbols-check: Fix undefined symbol detection on macOS
Commit e626636e90 ("bin/symbols-check: fix fields length condition
before accessing fields") changed the condition from `or` to `and`
to prevent potential IndexError when accessing fields[1].

However, this broke macOS because `nm -gP` outputs different field
counts for undefined symbols:
- Linux:  `_symbol U`           (2 fields)
- macOS:  `_symbol U 0 0`       (4 fields)

The condition `len(fields) == 2 and fields[1] == 'U'` only matched
the Linux format, causing undefined symbols like
_mesa_glapi_tls_Dispatch to be incorrectly reported as
"unknown symbol exported" on macOS.

Fix by using `len(fields) >= 2` to handle both platforms while still
guarding against IndexError.

Fixes: e626636e90 ("bin/symbols-check: fix fields length condition before accessing fields")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13451
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38983>
2025-12-20 02:05:15 +00:00
..
ci crnm: clean uncolored job status 2025-12-12 20:35:35 +00:00
pick pick-ui: add missing dependency 2025-04-22 19:20:09 +00:00
.editorconfig bin: use tabs for coding style on *.sh files 2017-05-09 14:05:00 +03:00
__init__.py scripts: Add a gen_release_notes.py script 2019-10-03 20:15:19 +00:00
commit_in_branch.py commit_in_branch.py: variables cleanup 2022-11-30 17:08:48 +00:00
commit_in_branch_test.py commit_in_branch.py: variables cleanup 2022-11-30 17:08:48 +00:00
flamegraph_map_lp_jit.py llvmpipe: FlameGraph profiling support 2024-09-05 14:19:20 +00:00
gen_calendar_entries.py bin: Fix typos 2023-03-30 21:37:00 +00:00
gen_calendar_entries_test.py bin: Fix typos 2023-03-30 21:37:00 +00:00
gen_release_notes.py bin/gen_release_notes: Remove duplicate bug entires 2025-11-17 22:45:13 +00:00
gen_release_notes_test.py bin/gen_release_notes: Remove duplicate bug entires 2025-11-17 22:45:13 +00:00
gen_vs_module_defs.py Remove osmesa 2025-03-04 00:40:39 +00:00
git_sha1_gen.py Revert "meson: use vcs_tag() instead of custom script" 2025-10-06 23:06:11 +00:00
install_megadrivers.py meson/megadriver: support various lib suffixes 2024-11-26 20:45:41 +00:00
khronos-update.py docs,ci: update mapi relocation 2025-08-06 20:35:26 +00:00
meson-cmd-extract.py bin/meson-cmd-extract: Also handle cross and native files 2019-01-18 09:37:01 -08:00
meson.build Revert "meson: use vcs_tag() instead of custom script" 2025-10-06 23:06:11 +00:00
nir-test-runner.py nir/tests: Do not rely on __LINE__ 2025-04-04 19:01:01 +00:00
people.csv people: Add Christoph Pillmayer to the list 2025-12-12 10:03:02 +01:00
perf-annotate-jit.py llvmpipe: improvements to JIT assembly dump 2024-09-05 14:19:20 +00:00
pick-ui.py bin/pick-ui: use asyncio.new_event_loop 2023-06-15 22:37:31 +00:00
pick-ui.sh bin/pick-ui: use venv wrapper 2023-08-03 23:21:32 +00:00
post_version.py gen_release_notes: include links in relnotes.rst when generating the new release note 2023-01-12 14:34:59 +00:00
post_version_test.py docs: store the release-calendar information in csv (and fix tests) 2021-01-07 00:07:56 +00:00
python-venv.sh bin: explicitly use python3 instead of python 2025-07-03 20:52:48 +00:00
rb.py bin/rb: update Alyssa's email address in test case 2025-09-02 15:57:17 +00:00
refcnt-log-helper.py bin: Add a script for filtering/sorting refcount logs 2022-05-02 16:58:20 +00:00
renderdoc-update.py renderdoc: Upgrade to v1.5 2025-08-08 19:38:54 +00:00
symbols-check.py bin/symbols-check: Fix undefined symbol detection on macOS 2025-12-20 02:05:15 +00:00
toml_lint.py ci: add check for misleading indentation in ci toml files 2024-08-22 20:25:32 +00:00
update-android-headers.sh android_stub: update platform headers to include atrace 2021-10-09 00:42:32 +00:00