mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-05-27 14:28:22 +02:00
0c5d772b71
This has one negative side-effect; we're no longer able to print validation errors without dxcompiler.dll. I doubt that's a real problem, but if it is, we should add this ability to dxil_validator instead of having a second implementation here. The reasons I didn't try adding this in the first place is: 1. This code seems a bit janky; it doesn't consult the "known"-variable to figure out if the encoding is OK, and it's lacking a fallback path in that case. 2. It seems unlikely that the compiler varies the encoding of the output in the first place; one of the two code-paths in here is probably untested. 3. Since dxil_validator leaves reporting to the call-site, we'd need to either add and output-encoding to the API (yuck), or re-encode the string to UTF-8 using WinAPI. Right now, it seems questionable if fixing all of the above is worth it. Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15751>
56 lines
1.7 KiB
C++
56 lines
1.7 KiB
C++
/*
|
|
* Copyright © 2021 Intel Corporation
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
|
* DEALINGS IN THE SOFTWARE.
|
|
*/
|
|
|
|
#include <cstdio>
|
|
|
|
#include "dxil_validation.h"
|
|
|
|
#if DETECT_OS_WINDOWS
|
|
|
|
#include "dxil_validator.h"
|
|
|
|
bool
|
|
validate_dxil(dxil_spirv_object *dxil_obj)
|
|
{
|
|
struct dxil_validator *val = dxil_create_validator(NULL);
|
|
|
|
char *err;
|
|
bool res = dxil_validate_module(val, dxil_obj->binary.buffer,
|
|
dxil_obj->binary.size, &err);
|
|
if (!res && err)
|
|
fprintf(stderr, "DXIL: %s\n\n", err);
|
|
|
|
dxil_destroy_validator(val);
|
|
return res;
|
|
}
|
|
|
|
#else
|
|
|
|
bool
|
|
validate_dxil(dxil_spirv_object *dxil_obj)
|
|
{
|
|
fprintf(stderr, "DXIL validation only available in Windows.\n");
|
|
return false;
|
|
}
|
|
|
|
#endif
|