mesa/src/amd/common/ac_nir_lower_global_access.c
Rhys Perry 5bc27e80c9 ac/nir: fix 32-bit offset global access optimization
Since 38cff03e58 ("radv: use nir_lower_conv64"), u2u64(a) is replaced
with pack_64_2x32_split(a, 0).

fossil-db (navi31):
Totals from 1203 (1.52% of 79330) affected shaders:
MaxWaves: 33685 -> 33813 (+0.38%)
Instrs: 1407031 -> 1374689 (-2.30%); split: -2.32%, +0.02%
CodeSize: 7088652 -> 6917320 (-2.42%); split: -2.43%, +0.01%
VGPRs: 69276 -> 68988 (-0.42%); split: -0.43%, +0.02%
SpillSGPRs: 982 -> 977 (-0.51%); split: -0.92%, +0.41%
Latency: 12536511 -> 12451605 (-0.68%); split: -0.94%, +0.27%
InvThroughput: 2456803 -> 2431241 (-1.04%); split: -1.09%, +0.05%
VClause: 27624 -> 27832 (+0.75%); split: -1.88%, +2.64%
SClause: 31757 -> 32702 (+2.98%); split: -0.53%, +3.51%
Copies: 90923 -> 91238 (+0.35%); split: -1.47%, +1.81%
Branches: 25127 -> 25128 (+0.00%); split: -0.00%, +0.01%
PreSGPRs: 46025 -> 46068 (+0.09%); split: -0.53%, +0.62%
PreVGPRs: 53944 -> 53488 (-0.85%)

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26402>
2023-11-30 21:50:21 +00:00

147 lines
5 KiB
C

/*
* Copyright © 2021 Valve Corporation
*
* SPDX-License-Identifier: MIT
*/
#include "ac_nir.h"
#include "nir.h"
#include "nir_builder.h"
static bool
is_u2u64(nir_scalar scalar)
{
if (nir_scalar_is_alu(scalar) && nir_scalar_alu_op(scalar) == nir_op_u2u64)
return true;
if (nir_scalar_is_alu(scalar) && nir_scalar_alu_op(scalar) == nir_op_pack_64_2x32_split) {
nir_scalar src1 = nir_scalar_chase_alu_src(scalar, 1);
return nir_scalar_is_const(src1) && nir_scalar_as_uint(src1) == 0;
}
return false;
}
static nir_def *
try_extract_additions(nir_builder *b, nir_scalar scalar, uint64_t *out_const,
nir_def **out_offset)
{
if (!nir_scalar_is_alu(scalar) || nir_scalar_alu_op(scalar) != nir_op_iadd)
return NULL;
nir_alu_instr *alu = nir_instr_as_alu(scalar.def->parent_instr);
nir_scalar src0 = nir_scalar_chase_alu_src(scalar, 0);
nir_scalar src1 = nir_scalar_chase_alu_src(scalar, 1);
for (unsigned i = 0; i < 2; ++i) {
nir_scalar src = i ? src1 : src0;
if (nir_scalar_is_const(src)) {
*out_const += nir_scalar_as_uint(src);
} else if (is_u2u64(src)) {
nir_scalar offset_scalar = nir_scalar_chase_alu_src(src, 0);
if (offset_scalar.def->bit_size != 32)
continue;
nir_def *offset = nir_channel(b, offset_scalar.def, offset_scalar.comp);
if (*out_offset)
*out_offset = nir_iadd(b, *out_offset, offset);
else
*out_offset = offset;
} else {
continue;
}
nir_def *replace_src =
try_extract_additions(b, i == 1 ? src0 : src1, out_const, out_offset);
return replace_src ? replace_src : nir_ssa_for_alu_src(b, alu, 1 - i);
}
nir_def *replace_src0 = try_extract_additions(b, src0, out_const, out_offset);
nir_def *replace_src1 = try_extract_additions(b, src1, out_const, out_offset);
if (!replace_src0 && !replace_src1)
return NULL;
replace_src0 = replace_src0 ? replace_src0 : nir_channel(b, src0.def, src0.comp);
replace_src1 = replace_src1 ? replace_src1 : nir_channel(b, src1.def, src1.comp);
return nir_iadd(b, replace_src0, replace_src1);
}
static bool
process_instr(nir_builder *b, nir_intrinsic_instr *intrin, void *_)
{
nir_intrinsic_op op;
switch (intrin->intrinsic) {
case nir_intrinsic_load_global:
case nir_intrinsic_load_global_constant:
op = nir_intrinsic_load_global_amd;
break;
case nir_intrinsic_global_atomic:
op = nir_intrinsic_global_atomic_amd;
break;
case nir_intrinsic_global_atomic_swap:
op = nir_intrinsic_global_atomic_swap_amd;
break;
case nir_intrinsic_store_global:
op = nir_intrinsic_store_global_amd;
break;
default:
return false;
}
unsigned addr_src_idx = op == nir_intrinsic_store_global_amd ? 1 : 0;
nir_src *addr_src = &intrin->src[addr_src_idx];
uint64_t off_const = 0;
nir_def *offset = NULL;
nir_scalar src = {addr_src->ssa, 0};
b->cursor = nir_after_instr(addr_src->ssa->parent_instr);
nir_def *addr = try_extract_additions(b, src, &off_const, &offset);
addr = addr ? addr : addr_src->ssa;
b->cursor = nir_before_instr(&intrin->instr);
if (off_const > UINT32_MAX) {
addr = nir_iadd_imm(b, addr, off_const);
off_const = 0;
}
nir_intrinsic_instr *new_intrin = nir_intrinsic_instr_create(b->shader, op);
new_intrin->num_components = intrin->num_components;
if (op != nir_intrinsic_store_global_amd)
nir_def_init(&new_intrin->instr, &new_intrin->def,
intrin->def.num_components, intrin->def.bit_size);
unsigned num_src = nir_intrinsic_infos[intrin->intrinsic].num_srcs;
for (unsigned i = 0; i < num_src; i++)
new_intrin->src[i] = nir_src_for_ssa(intrin->src[i].ssa);
new_intrin->src[num_src] = nir_src_for_ssa(offset ? offset : nir_imm_zero(b, 1, 32));
new_intrin->src[addr_src_idx] = nir_src_for_ssa(addr);
if (nir_intrinsic_has_access(intrin))
nir_intrinsic_set_access(new_intrin, nir_intrinsic_access(intrin));
if (nir_intrinsic_has_align_mul(intrin))
nir_intrinsic_set_align_mul(new_intrin, nir_intrinsic_align_mul(intrin));
if (nir_intrinsic_has_align_offset(intrin))
nir_intrinsic_set_align_offset(new_intrin, nir_intrinsic_align_offset(intrin));
if (nir_intrinsic_has_write_mask(intrin))
nir_intrinsic_set_write_mask(new_intrin, nir_intrinsic_write_mask(intrin));
if (nir_intrinsic_has_atomic_op(intrin))
nir_intrinsic_set_atomic_op(new_intrin, nir_intrinsic_atomic_op(intrin));
nir_intrinsic_set_base(new_intrin, off_const);
nir_builder_instr_insert(b, &new_intrin->instr);
if (op != nir_intrinsic_store_global_amd)
nir_def_rewrite_uses(&intrin->def, &new_intrin->def);
nir_instr_remove(&intrin->instr);
return true;
}
bool
ac_nir_lower_global_access(nir_shader *shader)
{
return nir_shader_intrinsics_pass(shader, process_instr,
nir_metadata_block_index | nir_metadata_dominance, NULL);
}