mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2025-12-24 06:40:11 +01:00
1d23cf192b
I dumped assembly generated by our driver with INTEL_DEBUG=shaders, copied and pasted it into a lua file, tried to run it with src/intel/executor, but the disassembler started telling me some instructions were invalid. This happened because we print the "compacted" flag in our assembly text, so when brw_gram.y parses our assembly flag, it sees the "compacted" flag and sets it to the instruction by calling add_instruction_option(). But the executor tool never sets the BRW_ASSEMBLE_COMPACT flag when it calls brw_assemble(), so when brw_assemble() calls dump_assembly(), which calls brw_disassbemble(), the disassembler gets confused and prints misinterpreted instructions and calls them invalid. It is not the job of brw_gram.y (our text assembly parser) to mark instructions as compacted. Whatever is later assembling the instruction is the entity that should decide if the instructions are compacted or not. So in this patch we just ignore this flag. Reviewed-by: Caio Oliveira <caio.oliveira@intel.com> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33614>
104 lines
2 KiB
C
104 lines
2 KiB
C
/*
|
|
* Copyright © 2018 Intel Corporation
|
|
* SPDX-License-Identifier: MIT
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
/* Assembler internal state and definitions used by the brw_gram/brw_lex. */
|
|
|
|
#include <inttypes.h>
|
|
#include <stdbool.h>
|
|
#include <assert.h>
|
|
|
|
#include "compiler/brw_reg.h"
|
|
#include "compiler/brw_reg_type.h"
|
|
#include "compiler/brw_eu_defines.h"
|
|
#include "compiler/brw_eu_inst.h"
|
|
#include "compiler/brw_eu.h"
|
|
#include "dev/intel_device_info.h"
|
|
#include "util/list.h"
|
|
|
|
/* glibc < 2.27 defines OVERFLOW in /usr/include/math.h. */
|
|
#undef OVERFLOW
|
|
|
|
int yyparse(void);
|
|
int yylex(void);
|
|
char *lex_text(void);
|
|
|
|
extern struct brw_codegen *p;
|
|
extern int errors;
|
|
extern bool compaction_warning_given;
|
|
extern const char *input_filename;
|
|
|
|
extern struct list_head instr_labels;
|
|
extern struct list_head target_labels;
|
|
|
|
struct condition {
|
|
unsigned cond_modifier:4;
|
|
unsigned flag_reg_nr:1;
|
|
unsigned flag_subreg_nr:1;
|
|
};
|
|
|
|
struct predicate {
|
|
unsigned pred_control:4;
|
|
unsigned pred_inv:1;
|
|
unsigned flag_reg_nr:1;
|
|
unsigned flag_subreg_nr:1;
|
|
};
|
|
|
|
enum instoption_type {
|
|
INSTOPTION_FLAG,
|
|
INSTOPTION_DEP_INFO,
|
|
INSTOPTION_CHAN_OFFSET,
|
|
};
|
|
|
|
struct instoption {
|
|
enum instoption_type type;
|
|
union {
|
|
unsigned uint_value;
|
|
struct tgl_swsb depinfo_value;
|
|
};
|
|
};
|
|
|
|
struct options {
|
|
uint8_t chan_offset;
|
|
unsigned access_mode:1;
|
|
unsigned compression_control:2;
|
|
unsigned thread_control:2;
|
|
unsigned branch_control:1;
|
|
unsigned no_dd_check:1; // Dependency control
|
|
unsigned no_dd_clear:1; // Dependency control
|
|
unsigned mask_control:1;
|
|
unsigned debug_control:1;
|
|
unsigned acc_wr_control:1;
|
|
unsigned end_of_thread:1;
|
|
unsigned compaction:1;
|
|
unsigned is_compr:1;
|
|
struct tgl_swsb depinfo;
|
|
};
|
|
|
|
struct msgdesc {
|
|
unsigned ex_bso:1;
|
|
unsigned src1_len:5;
|
|
};
|
|
|
|
enum instr_label_type {
|
|
INSTR_LABEL_JIP,
|
|
INSTR_LABEL_UIP,
|
|
};
|
|
|
|
struct instr_label {
|
|
struct list_head link;
|
|
|
|
char *name;
|
|
int offset;
|
|
enum instr_label_type type;
|
|
};
|
|
|
|
struct target_label {
|
|
struct list_head link;
|
|
|
|
char *name;
|
|
int offset;
|
|
};
|