fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-25 21:18:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1
mesa/src/panfrost
History
David Heidelberg 566a97ce4a panvk: clear dangling pointers 
Fixes:
```
[829/1646] Compiling C object src/panfrost/vulkan/libpanvk_v6.a.p/panvk_vX_meta_clear.c.o
In function 'panvk_meta_clear_zs_img',
    inlined from 'panvk_v6_CmdClearDepthStencilImage' at ../src/panfrost/vulkan/panvk_vX_meta_clear.c:457:7:
../src/panfrost/vulkan/panvk_vX_meta_clear.c:415:26: warning: storing the address of local variable 'view' in '((struct pan_fb_info *)((char *)commandBuffer + 144))[23].zs.view.zs' [-Wdangling-pointer=]
  415 |       fbinfo->zs.view.zs = &view;
      |       ~~~~~~~~~~~~~~~~~~~^~~~~~~
../src/panfrost/vulkan/panvk_vX_meta_clear.c: In function 'panvk_v6_CmdClearDepthStencilImage':
../src/panfrost/vulkan/panvk_vX_meta_clear.c:393:26: note: 'view' declared here
  393 |    struct pan_image_view view = {
      |                          ^~~~
../src/panfrost/vulkan/panvk_vX_meta_clear.c:393:26: note: 'commandBuffer' declared here
[844/1646] Compiling C object src/panfrost/vulkan/libpanvk_v7.a.p/panvk_vX_meta_clear.c.o
In function 'panvk_meta_clear_zs_img',
    inlined from 'panvk_v7_CmdClearDepthStencilImage' at ../src/panfrost/vulkan/panvk_vX_meta_clear.c:457:7:
../src/panfrost/vulkan/panvk_vX_meta_clear.c:415:26: warning: storing the address of local variable 'view' in '((struct pan_fb_info *)((char *)commandBuffer + 144))[23].zs.view.zs' [-Wdangling-pointer=]
  415 |       fbinfo->zs.view.zs = &view;
      |       ~~~~~~~~~~~~~~~~~~~^~~~~~~
../src/panfrost/vulkan/panvk_vX_meta_clear.c: In function 'panvk_v7_CmdClearDepthStencilImage':
../src/panfrost/vulkan/panvk_vX_meta_clear.c:393:26: note: 'view' declared here
  393 |    struct pan_image_view view = {
      |                          ^~~~
../src/panfrost/vulkan/panvk_vX_meta_clear.c:393:26: note: 'commandBuffer' declared here
```

Cc: mesa-stable

Suggested-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22829>
(cherry picked from commit 2b4ce498ee)
2023-05-05 19:07:11 +01:00
..
ci Uprev Piglit to 2391a83d1639a7ab7bbea02853b922878687b0e5 2023-04-04 15:37:14 +00:00
compiler pan/bi: Use nir_lower_mem_access_bit_sizes 2023-04-13 01:49:33 +00:00
drm-shim panfrost: clang-format the tree 2022-12-24 02:22:57 +00:00
ds panfrost: clang-format the tree 2022-12-24 02:22:57 +00:00
include panfrost: Re-run clang-format 2023-04-10 21:56:04 +00:00
lib pan/decode: Print compute job payloads 2023-04-13 01:49:33 +00:00
midgard nir: Combine if_uses with instruction uses 2023-04-07 23:48:03 +00:00
perf panfrost: clang-format the tree 2022-12-24 02:22:57 +00:00
shared meson: inline gtest_test_protocol now that it's always 'gtest' 2023-03-10 07:20:29 +00:00
tools panfrost: clang-format the tree 2022-12-24 02:22:57 +00:00
util nir: Combine if_uses with instruction uses 2023-04-07 23:48:03 +00:00
vulkan panvk: clear dangling pointers 2023-05-05 19:07:11 +01:00
.clang-format nir: Combine if_uses with instruction uses 2023-04-07 23:48:03 +00:00
meson.build panfrost: drop no-longer-needed libglsl 2023-02-10 14:09:37 +00:00