mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-06-20 23:28:23 +02:00
read-only mirror of https://gitlab.freedesktop.org/mesa/mesa
44b82c7576
When rematerializing defs in the preamble, we make sure to insert them
in a block dominated by all their sources. When inserting a def that
doesn't have any sources we have to make sure to insert them as early as
possible. This important for sequences like this:
32 %34 = load_const (0x00000007 = 0.000000)
...
if ... {
32 %184 = @load_preamble (base=8)
32 %185 = @bindless_resource_ir3 (%184) (desc_set=0)
32 %186 = @bindless_resource_ir3 (%34 (0x7)) (desc_set=1)
32x4 %187 = (float32)tex %186 (texture_handle), %185 (sampler_handle), ...
...
}
%185 has to be rematerialized in control flow since its source is
defined there. %186 does not as its source is defined outside control
flow. We used to insert %186 as late as possible
(nir_after_impl(preamble)) but this causes issues as we cannot find a
valid block (i.e., a block that is dominated by both) to insert the
descriptor prefetch for (%185, %186). Fix this by setting the default
block to insert rematerialized defs as the preamble's start block.
Totals from 520 (0.30% of 176258) affected shaders:
MaxWaves: 5796 -> 5794 (-0.03%)
Instrs: 715314 -> 715248 (-0.01%); split: -0.02%, +0.01%
CodeSize: 1547680 -> 1547182 (-0.03%); split: -0.17%, +0.14%
NOPs: 157057 -> 157005 (-0.03%); split: -0.07%, +0.04%
Full: 9399 -> 9415 (+0.17%)
(ss): 18718 -> 18715 (-0.02%); split: -0.03%, +0.01%
(sy): 8183 -> 8178 (-0.06%)
(ss)-stall: 79780 -> 79818 (+0.05%); split: -0.02%, +0.06%
(sy)-stall: 221660 -> 221591 (-0.03%); split: -0.05%, +0.02%
STPs: 232 -> 234 (+0.86%)
LDPs: 232 -> 234 (+0.86%)
Preamble Instrs: 242817 -> 242695 (-0.05%); split: -0.79%, +0.74%
Cat0: 176573 -> 176523 (-0.03%); split: -0.06%, +0.03%
Cat7: 18945 -> 18929 (-0.08%); split: -0.09%, +0.01%
Signed-off-by: Job Noorman <job@noorman.info>
Fixes:
|
||
|---|---|---|
| .ci-farms | ||
| .ci-farms-disabled | ||
| .github/workflows | ||
| .gitlab | ||
| .gitlab-ci | ||
| .marge/hooks | ||
| android | ||
| bin | ||
| build-support | ||
| docs | ||
| include | ||
| licenses | ||
| src | ||
| subprojects | ||
| .clang-format | ||
| .clang-format-ignore | ||
| .clang-format-include | ||
| .dir-locals.el | ||
| .editorconfig | ||
| .git-blame-ignore-revs | ||
| .gitattributes | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| .graphqlrc.yml | ||
| .mailmap | ||
| .mr-label-maker.yml | ||
| .shellcheckrc | ||
| clippy.toml | ||
| CODEOWNERS | ||
| meson.build | ||
| meson.options | ||
| README.rst | ||
| rustfmt.toml | ||
| VERSION | ||
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.