mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-06-03 04:38:17 +02:00
86bd2196b4
Prior to GLX 1.3 there was the glxMakeCurrent() function that took a single drawable handle. The Drawable could be either a bare XID for a Window or an XID for a glxpixmap. GLX 1.3 added glxMakeContextCurrent that takes 2 handles: one for reading, one for writing. Nowadays the old glxMakeCurrent call is implemented as a call to glxMakeContextCurrent with the single handle duplicated. Because of this it is allowed to use a plain-old Window ID as an argument to glxMakeContextCurrent, although nobody really documents this sort of thing. The manpage for the NEW call specifies the arguments as GLXPixmaps, but the actual code accepts Window XIDs too, and handles them correctly. Similarly, the glxSelectEvents function can also take a bare Window XID. The "piglit" tests all use GLXWindows and/or GLXPixmaps. You never tested swap events with a bare Window XID. That is what my app was doing. The swap_events code worked with Window XIDs in mesa 7.x.y. The new code added in versions 8, 9, and 10 assumes that all buffer swap events have a GLXPixmap associated with them. Because of the historical quirks above, this is not true. Swap events for bare Window XIDs do NOT have a glxpixmap resulting in a segfault. Any app that uses the old school glxMakeCurrent call with a Window XID while trying to use swap_events will crash when the libs try to lookup the nonexistent GLXPixmap associated with the incoming swap event. I believe that the people who wrote the spec overlooked this, because the "sbc" field comes from the OML_sync extension that is defined in terms of glxpixmaps only. v2 (idr): Formatting changes. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=54372 Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org> Cc: "10.1 10.2" <mesa-stable@lists.freedesktop.org> |
||
|---|---|---|
| .. | ||
| apple | ||
| tests | ||
| .gitignore | ||
| applegl_glx.c | ||
| clientattrib.c | ||
| clientinfo.c | ||
| compsize.c | ||
| create_context.c | ||
| dri2.c | ||
| dri2.h | ||
| dri2_glx.c | ||
| dri2_priv.h | ||
| dri2_query_renderer.c | ||
| dri3_glx.c | ||
| dri3_priv.h | ||
| dri_common.c | ||
| dri_common.h | ||
| dri_glx.c | ||
| drisw_glx.c | ||
| eval.c | ||
| glx_error.c | ||
| glx_error.h | ||
| glx_pbuffer.c | ||
| glx_query.c | ||
| glxclient.h | ||
| glxcmds.c | ||
| glxconfig.c | ||
| glxconfig.h | ||
| glxcurrent.c | ||
| glxext.c | ||
| glxextensions.c | ||
| glxextensions.h | ||
| glxhash.c | ||
| glxhash.h | ||
| indirect_glx.c | ||
| indirect_init.h | ||
| indirect_texture_compression.c | ||
| indirect_transpose_matrix.c | ||
| indirect_vertex_array.c | ||
| indirect_vertex_array.h | ||
| indirect_vertex_array_priv.h | ||
| indirect_vertex_program.c | ||
| indirect_window_pos.c | ||
| Makefile.am | ||
| packrender.h | ||
| packsingle.h | ||
| pixel.c | ||
| pixelstore.c | ||
| query_renderer.c | ||
| render2.c | ||
| renderpix.c | ||
| SConscript | ||
| single2.c | ||
| singlepix.c | ||
| vertarr.c | ||
| XF86dri.c | ||
| xf86dri.h | ||
| xf86dristr.h | ||
| xfont.c | ||