fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-24 12:48:13 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1
mesa/src/intel/compiler/brw/test_opt_saturate_propagation.cpp
Lionel Landwerlin efcba73b49 brw: switch to new sampler payload description scheme 
Instead of having abstracted opcodes, we target directly the HW format
at the NIR translation.

The payload description gives us the order of the payload sources (we
can use that for pretty printing) and we don't have to have a
complicated scheme in the logical send lowering for the ordering. All
we have to do is build the header if needed as well as the descriptors.

PTL Fossil-db stats:
 Totals from 66759 (13.54% of 492917) affected shaders:
 Instrs: 44289221 -> 43957404 (-0.75%); split: -0.81%, +0.06%
 Send messages: 2050378 -> 2042607 (-0.38%)
 Cycle count: 3878874713 -> 3712848434 (-4.28%); split: -4.44%, +0.16%
 Max live registers: 8773179 -> 8770104 (-0.04%); split: -0.06%, +0.03%
 Max dispatch width: 1677408 -> 1707952 (+1.82%); split: +1.85%, -0.03%
 Non SSA regs after NIR: 11407821 -> 11421041 (+0.12%); split: -0.03%, +0.15%
 GRF registers: 5686983 -> 5838785 (+2.67%); split: -0.24%, +2.91%

LNL Fossil-db stats:

 Totals from 57911 (15.72% of 368381) affected shaders:
 Instrs: 39448036 -> 38923650 (-1.33%); split: -1.41%, +0.08%
 Subgroup size: 1241360 -> 1241392 (+0.00%)
 Send messages: 1846696 -> 1845137 (-0.08%)
 Cycle count: 3834818910 -> 3784003027 (-1.33%); split: -2.33%, +1.00%
 Spill count: 21866 -> 22168 (+1.38%); split: -0.07%, +1.45%
 Fill count: 59324 -> 60339 (+1.71%); split: -0.00%, +1.71%
 Scratch Memory Size: 1479680 -> 1483776 (+0.28%)
 Max live registers: 7521376 -> 7447841 (-0.98%); split: -1.04%, +0.06%
 Non SSA regs after NIR: 9744605 -> 10113728 (+3.79%); split: -0.01%, +3.80%

Only 2 titles negatively impacted (spilling) :
  - Shadow of the Tomb Raider
  - Red Dead Redemption 2

All impacted shaders were already spilling.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37171>
2025-10-16 12:08:15 +00:00

329 lines
10 KiB
C++
Raw Blame History

/*
* Copyright © 2015 Intel Corporation
* SPDX-License-Identifier: MIT
*/
#include "test_helpers.h"
#include "brw_builder.h"
class saturate_propagation_test : public brw_shader_pass_test {};
TEST_F(saturate_propagation_test, basic)
{
brw_builder bld = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_builder exp = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_reg dst0 = vgrf(bld, exp, BRW_TYPE_F);
brw_reg dst1 = vgrf(bld, exp, BRW_TYPE_F);
brw_reg src0 = vgrf(bld, exp, BRW_TYPE_F);
brw_reg src1 = vgrf(bld, exp, BRW_TYPE_F);
bld.ADD(dst0, bld.LOAD_REG(src0), bld.LOAD_REG(src1));
bld.MOV(dst1, dst0)->saturate = true;
EXPECT_PROGRESS(brw_opt_saturate_propagation, bld);
exp.ADD(dst0, exp.LOAD_REG(src0), exp.LOAD_REG(src1))->saturate = true;
exp.MOV(dst1, dst0);
EXPECT_SHADERS_MATCH(bld, exp);
}
TEST_F(saturate_propagation_test, other_non_saturated_use)
{
brw_builder bld = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_reg dst0 = bld.vgrf(BRW_TYPE_F);
brw_reg dst1 = bld.vgrf(BRW_TYPE_F);
brw_reg dst2 = bld.vgrf(BRW_TYPE_F);
brw_reg src0 = bld.LOAD_REG(bld.vgrf(BRW_TYPE_F));
brw_reg src1 = bld.LOAD_REG(bld.vgrf(BRW_TYPE_F));
bld.ADD(dst0, src0, src1);
bld.MOV(dst1, dst0)->saturate = true;
bld.ADD(dst2, dst0, src0);
EXPECT_NO_PROGRESS(brw_opt_saturate_propagation, bld);
}
TEST_F(saturate_propagation_test, predicated_instruction)
{
brw_builder bld = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_reg dst0 = bld.vgrf(BRW_TYPE_F);
brw_reg dst1 = bld.vgrf(BRW_TYPE_F);
brw_reg src0 = bld.LOAD_REG(bld.vgrf(BRW_TYPE_F));
brw_reg src1 = bld.LOAD_REG(bld.vgrf(BRW_TYPE_F));
bld.ADD(dst0, src0, src1)->predicate = BRW_PREDICATE_NORMAL;
bld.MOV(dst1, dst0)->saturate = true;
EXPECT_NO_PROGRESS(brw_opt_saturate_propagation, bld);
}
TEST_F(saturate_propagation_test, neg_mov_sat)
{
brw_builder bld = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_reg dst1 = bld.vgrf(BRW_TYPE_F);
brw_reg src0 = bld.LOAD_REG(bld.vgrf(BRW_TYPE_F));
brw_reg dst0 = bld.RNDU(src0);
dst0.negate = true;
set_saturate(true, bld.MOV(dst1, dst0));
EXPECT_NO_PROGRESS(brw_opt_saturate_propagation, bld);
}
TEST_F(saturate_propagation_test, add_neg_mov_sat)
{
brw_builder bld = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_builder exp = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_reg dst0 = vgrf(bld, exp, BRW_TYPE_F);
brw_reg dst1 = vgrf(bld, exp, BRW_TYPE_F);
brw_reg src0 = vgrf(bld, exp, BRW_TYPE_F);
brw_reg src1 = vgrf(bld, exp, BRW_TYPE_F);
bld.ADD(dst0, bld.LOAD_REG(src0), bld.LOAD_REG(src1));
bld.MOV(dst1, negate(dst0))->saturate = true;
EXPECT_PROGRESS(brw_opt_saturate_propagation, bld);
exp.ADD(dst0, negate(exp.LOAD_REG(src0)), negate(exp.LOAD_REG(src1)))->saturate = true;
exp.MOV(dst1, dst0);
EXPECT_SHADERS_MATCH(bld, exp);
}
TEST_F(saturate_propagation_test, add_imm_float_neg_mov_sat)
{
brw_builder bld = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_builder exp = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_reg dst0 = vgrf(bld, exp, BRW_TYPE_F);
brw_reg dst1 = vgrf(bld, exp, BRW_TYPE_F);
brw_reg src0 = vgrf(bld, exp, BRW_TYPE_F);
bld.ADD(dst0, bld.LOAD_REG(src0), brw_imm_f(1.0f));
bld.MOV(dst1, negate(dst0))->saturate = true;
EXPECT_PROGRESS(brw_opt_saturate_propagation, bld);
exp.ADD(dst0, negate(exp.LOAD_REG(src0)), brw_imm_f(-1.0f))->saturate = true;
exp.MOV(dst1, dst0);
EXPECT_SHADERS_MATCH(bld, exp);
}
TEST_F(saturate_propagation_test, mul_neg_mov_sat)
{
brw_builder bld = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_builder exp = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_reg dst0 = vgrf(bld, exp, BRW_TYPE_F);
brw_reg dst1 = vgrf(bld, exp, BRW_TYPE_F);
brw_reg src0 = vgrf(bld, exp, BRW_TYPE_F);
brw_reg src1 = vgrf(bld, exp, BRW_TYPE_F);
bld.MUL(dst0, bld.LOAD_REG(src0), bld.LOAD_REG(src1));
bld.MOV(dst1, negate(dst0))->saturate = true;
EXPECT_PROGRESS(brw_opt_saturate_propagation, bld);
exp.MUL(dst0, negate(exp.LOAD_REG(src0)), exp.LOAD_REG(src1))->saturate = true;
exp.MOV(dst1, dst0);
EXPECT_SHADERS_MATCH(bld, exp);
}
TEST_F(saturate_propagation_test, mad_neg_mov_sat)
{
brw_builder bld = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_builder exp = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_reg dst0 = vgrf(bld, exp, BRW_TYPE_F);
brw_reg dst1 = vgrf(bld, exp, BRW_TYPE_F);
brw_reg src0 = vgrf(bld, exp, BRW_TYPE_F);
brw_reg src1 = vgrf(bld, exp, BRW_TYPE_F);
brw_reg src2 = vgrf(bld, exp, BRW_TYPE_F);
bld.MAD(dst0, bld.LOAD_REG(src0), bld.LOAD_REG(src1), bld.LOAD_REG(src2));
bld.MOV(dst1, negate(dst0))->saturate = true;
EXPECT_PROGRESS(brw_opt_saturate_propagation, bld);
exp.MAD(dst0, negate(exp.LOAD_REG(src0)), negate(exp.LOAD_REG(src1)), exp.LOAD_REG(src2))->saturate = true;
exp.MOV(dst1, dst0);
EXPECT_SHADERS_MATCH(bld, exp);
}
TEST_F(saturate_propagation_test, mad_imm_float_neg_mov_sat)
{
brw_builder bld = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_builder exp = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_reg dst0 = vgrf(bld, exp, BRW_TYPE_F);
brw_reg dst1 = vgrf(bld, exp, BRW_TYPE_F);
brw_reg src2 = vgrf(bld, exp, BRW_TYPE_F);
/* The builder for MAD tries to be helpful and not put immediates as direct
* sources. We want to test specifically that case.
*/
{
brw_reg def2 = bld.LOAD_REG(src2);
brw_inst *mad = bld.MAD(dst0, def2, def2, def2);
mad->src[0] = brw_imm_f(1.0f);
mad->src[1] = brw_imm_f(-2.0f);
bld.MOV(dst1, negate(dst0))->saturate = true;
}
EXPECT_PROGRESS(brw_opt_saturate_propagation, bld);
{
brw_reg def2 = exp.LOAD_REG(src2);
brw_inst *mad = exp.MAD(dst0, def2, def2, def2);
mad->saturate = true;
mad->src[0] = brw_imm_f(-1.0f);
mad->src[1] = brw_imm_f(2.0f);
exp.MOV(dst1, dst0);
}
EXPECT_SHADERS_MATCH(bld, exp);
}
TEST_F(saturate_propagation_test, mul_mov_sat_neg_mov_sat)
{
brw_builder bld = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_reg dst0 = bld.vgrf(BRW_TYPE_F);
brw_reg dst1 = bld.vgrf(BRW_TYPE_F);
brw_reg dst2 = bld.vgrf(BRW_TYPE_F);
brw_reg src0 = bld.LOAD_REG(bld.vgrf(BRW_TYPE_F));
brw_reg src1 = bld.LOAD_REG(bld.vgrf(BRW_TYPE_F));
bld.MUL(dst0, src0, src1);
bld.MOV(dst1, dst0)->saturate = true;
bld.MOV(dst2, negate(dst0))->saturate = true;
EXPECT_NO_PROGRESS(brw_opt_saturate_propagation, bld);
}
TEST_F(saturate_propagation_test, mul_neg_mov_sat_neg_mov_sat)
{
brw_builder bld = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_reg dst1 = bld.vgrf(BRW_TYPE_F);
brw_reg dst2 = bld.vgrf(BRW_TYPE_F);
brw_reg src0 = bld.LOAD_REG(bld.vgrf(BRW_TYPE_F));
brw_reg src1 = bld.LOAD_REG(bld.vgrf(BRW_TYPE_F));
brw_reg dst0 = bld.MUL(src0, src1);
bld.MOV(dst1, negate(dst0))->saturate = true;
bld.MOV(dst2, negate(dst0))->saturate = true;
EXPECT_NO_PROGRESS(brw_opt_saturate_propagation, bld);
}
TEST_F(saturate_propagation_test, abs_mov_sat)
{
brw_builder bld = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_reg dst1 = bld.vgrf(BRW_TYPE_F);
brw_reg src0 = bld.LOAD_REG(bld.vgrf(BRW_TYPE_F));
brw_reg src1 = bld.LOAD_REG(bld.vgrf(BRW_TYPE_F));
brw_reg dst0 = bld.ADD(src0, src1);
bld.MOV(dst1, brw_abs(dst0))->saturate = true;
EXPECT_NO_PROGRESS(brw_opt_saturate_propagation, bld);
}
TEST_F(saturate_propagation_test, producer_saturates)
{
brw_builder bld = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_builder exp = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_reg dst0 = vgrf(bld, exp, BRW_TYPE_F);
brw_reg dst1 = vgrf(bld, exp, BRW_TYPE_F);
brw_reg dst2 = vgrf(bld, exp, BRW_TYPE_F);
brw_reg src0 = vgrf(bld, exp, BRW_TYPE_F);
brw_reg src1 = vgrf(bld, exp, BRW_TYPE_F);
bld.ADD(dst0, bld.LOAD_REG(src0), bld.LOAD_REG(src1))->saturate = true;
bld.MOV(dst1, dst0)->saturate = true;
bld.MOV(dst2, dst0);
EXPECT_PROGRESS(brw_opt_saturate_propagation, bld);
exp.ADD(dst0, exp.LOAD_REG(src0), exp.LOAD_REG(src1))->saturate = true;
exp.MOV(dst1, dst0);
exp.MOV(dst2, dst0);
EXPECT_SHADERS_MATCH(bld, exp);
}
TEST_F(saturate_propagation_test, mul_neg_mov_sat_mov_sat)
{
brw_builder bld = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_reg dst0 = bld.vgrf(BRW_TYPE_F);
brw_reg dst1 = bld.vgrf(BRW_TYPE_F);
brw_reg dst2 = bld.vgrf(BRW_TYPE_F);
brw_reg src0 = bld.LOAD_REG(bld.vgrf(BRW_TYPE_F));
brw_reg src1 = bld.LOAD_REG(bld.vgrf(BRW_TYPE_F));
bld.MUL(dst0, src0, src1);
bld.MOV(dst1, negate(dst0))->saturate = true;
bld.MOV(dst2, dst0)->saturate = true;
EXPECT_NO_PROGRESS(brw_opt_saturate_propagation, bld);
}
TEST_F(saturate_propagation_test, smaller_exec_size_consumer)
{
brw_builder bld = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_reg dst0 = bld.vgrf(BRW_TYPE_F);
brw_reg dst1 = bld.vgrf(BRW_TYPE_F);
brw_reg src0 = bld.LOAD_REG(bld.vgrf(BRW_TYPE_F));
brw_reg src1 = bld.LOAD_REG(bld.vgrf(BRW_TYPE_F));
bld .ADD(src0, src1);
bld.group(8, 0).MOV(dst1, dst0)->saturate = true;
EXPECT_NO_PROGRESS(brw_opt_saturate_propagation, bld);
}
TEST_F(saturate_propagation_test, larger_exec_size_consumer)
{
brw_builder bld = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_reg dst0 = bld.vgrf(BRW_TYPE_F);
brw_reg dst1 = bld.vgrf(BRW_TYPE_F);
brw_reg src0 = bld.LOAD_REG(bld.vgrf(BRW_TYPE_F));
brw_reg src1 = bld.LOAD_REG(bld.vgrf(BRW_TYPE_F));
bld.group(8, 0).ADD(dst0, src0, src1);
bld .MOV(dst1, dst0)->saturate = true;
EXPECT_NO_PROGRESS(brw_opt_saturate_propagation, bld);
}
TEST_F(saturate_propagation_test, offset_source_barrier)
{
brw_builder bld = make_shader(MESA_SHADER_FRAGMENT, 16);
brw_reg dst0 = bld.vgrf(BRW_TYPE_F);
brw_reg dst1 = bld.vgrf(BRW_TYPE_F);
brw_reg dst2 = bld.vgrf(BRW_TYPE_F);
brw_reg src0 = bld.LOAD_REG(bld.vgrf(BRW_TYPE_F));
brw_reg src1 = bld.LOAD_REG(bld.vgrf(BRW_TYPE_F));
bld.group(16, 0).ADD(dst0, src0, src1);
bld.group(1, 0) .ADD(dst1, component(dst0, 8), brw_imm_f(1.0f));
bld.group(16, 0).MOV(dst2, dst0)->saturate = true;
EXPECT_NO_PROGRESS(brw_opt_saturate_propagation, bld);
}
Reference in a new issue View git blame Copy permalink