mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-05-18 00:48:07 +02:00
We add a bunch of new helpers to avoid the need to touch >parent_instr, including the full set of: * nir_def_is_* * nir_def_as_*_or_null * nir_def_as_* [assumes the right instr type] * nir_src_is_* * nir_src_as_* * nir_scalar_is_* * nir_scalar_as_* Plus nir_def_instr() where there's no more suitable helper. Also an existing helper is renamed to unify all the names, while we're churning the tree: * nir_src_as_alu_instr -> nir_src_as_alu ..and then we port the tree to use the helpers as much as possible, using nir_def_instr() where that does not work. Acked-by: Marek Olšák <maraeo@gmail.com> --- To eliminate nir_def::parent_instr we need to churn the tree anyway, so I'm taking this opportunity to clean up a lot of NIR patterns. Co-authored-by: Konstantin Seurer <konstantin.seurer@gmail.com> Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38313>
298 lines
10 KiB
C
298 lines
10 KiB
C
/*
|
|
* Copyright © 2015 Intel Corporation
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*/
|
|
|
|
#include "nir.h"
|
|
#include "nir_builder.h"
|
|
|
|
/*
|
|
* Implements a pass that lowers vector phi nodes to scalar phi nodes when
|
|
* we don't think it will hurt anything.
|
|
*/
|
|
|
|
struct lower_phis_to_scalar_state {
|
|
nir_shader *shader;
|
|
nir_builder builder;
|
|
|
|
nir_vectorize_cb cb;
|
|
const void *data;
|
|
};
|
|
|
|
static bool
|
|
nir_block_ends_in_continue(nir_block *block)
|
|
{
|
|
if (!exec_list_is_empty(&block->instr_list)) {
|
|
nir_instr *instr = nir_block_last_instr(block);
|
|
if (instr->type == nir_instr_type_jump)
|
|
return nir_instr_as_jump(instr)->type == nir_jump_continue;
|
|
}
|
|
|
|
nir_cf_node *parent = block->cf_node.parent;
|
|
return parent->type == nir_cf_node_loop &&
|
|
block == nir_cf_node_cf_tree_last(parent);
|
|
}
|
|
|
|
static bool
|
|
is_phi_src_scalarizable(nir_phi_src *src)
|
|
{
|
|
|
|
nir_instr *src_instr = nir_def_instr(src->src.ssa);
|
|
switch (src_instr->type) {
|
|
case nir_instr_type_alu: {
|
|
nir_alu_instr *src_alu = nir_instr_as_alu(src_instr);
|
|
|
|
/* ALU operations with output_size == 0 should be scalarized. We
|
|
* will also see a bunch of vecN operations from scalarizing ALU
|
|
* operations and, since they can easily be copy-propagated, they
|
|
* are ok too.
|
|
*/
|
|
return nir_op_infos[src_alu->op].output_size == 0 ||
|
|
nir_op_is_vec_or_mov(src_alu->op);
|
|
}
|
|
|
|
case nir_instr_type_phi:
|
|
/* If the src is another phi, scalarize it if we didn't visit it yet,
|
|
* which is the case for continue blocks. We are likely going to lower
|
|
* it anyway.
|
|
*/
|
|
return nir_block_ends_in_continue(src->pred);
|
|
|
|
case nir_instr_type_load_const:
|
|
/* These are trivially scalarizable */
|
|
return true;
|
|
|
|
case nir_instr_type_undef:
|
|
/* The caller of this function is going to OR the results and we don't
|
|
* want undefs to count so we return false.
|
|
*/
|
|
return false;
|
|
|
|
case nir_instr_type_intrinsic: {
|
|
nir_intrinsic_instr *src_intrin = nir_instr_as_intrinsic(src_instr);
|
|
|
|
switch (src_intrin->intrinsic) {
|
|
case nir_intrinsic_load_deref: {
|
|
/* Don't scalarize if we see a load of a local variable because it
|
|
* might turn into one of the things we can't scalarize.
|
|
*/
|
|
nir_deref_instr *deref = nir_src_as_deref(src_intrin->src[0]);
|
|
return !nir_deref_mode_may_be(deref, nir_var_function_temp |
|
|
nir_var_shader_temp);
|
|
}
|
|
|
|
case nir_intrinsic_interp_deref_at_centroid:
|
|
case nir_intrinsic_interp_deref_at_sample:
|
|
case nir_intrinsic_interp_deref_at_offset:
|
|
case nir_intrinsic_interp_deref_at_vertex:
|
|
case nir_intrinsic_load_uniform:
|
|
case nir_intrinsic_load_ubo:
|
|
case nir_intrinsic_load_ssbo:
|
|
case nir_intrinsic_load_global:
|
|
case nir_intrinsic_load_global_constant:
|
|
case nir_intrinsic_load_input:
|
|
case nir_intrinsic_load_per_primitive_input:
|
|
return true;
|
|
default:
|
|
break;
|
|
}
|
|
}
|
|
FALLTHROUGH;
|
|
|
|
default:
|
|
/* We can't scalarize this type of instruction */
|
|
return false;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Determines if the given phi node should be lowered. The only phi nodes
|
|
* we will scalarize at the moment are those where all of the sources are
|
|
* scalarizable, unless lower_all is set.
|
|
*
|
|
* The reason for this comes down to coalescing. Since phi sources can't
|
|
* swizzle, swizzles on phis have to be resolved by inserting a mov right
|
|
* before the phi. The choice then becomes between movs to pick off
|
|
* components for a scalar phi or potentially movs to recombine components
|
|
* for a vector phi. The problem is that the movs generated to pick off
|
|
* the components are almost uncoalescable. We can't coalesce them in NIR
|
|
* because we need them to pick off components and we can't coalesce them
|
|
* in the backend because the source register is a vector and the
|
|
* destination is a scalar that may be used at other places in the program.
|
|
* On the other hand, if we have a bunch of scalars going into a vector
|
|
* phi, the situation is much better. In this case, if the SSA def is
|
|
* generated in the predecessor block to the corresponding phi source, the
|
|
* backend code will be an ALU op into a temporary and then a mov into the
|
|
* given vector component; this move can almost certainly be coalesced
|
|
* away.
|
|
*/
|
|
static uint8_t
|
|
should_lower_phi(const nir_instr *instr, const void *data)
|
|
{
|
|
nir_phi_instr *phi = nir_instr_as_phi(instr);
|
|
|
|
nir_foreach_phi_src(src, phi) {
|
|
/* This loop ignores srcs that are not scalarizable because its likely
|
|
* still worth copying to temps if another phi source is scalarizable.
|
|
* This reduces register spilling by a huge amount in the i965 driver for
|
|
* Deus Ex: MD.
|
|
*/
|
|
if (is_phi_src_scalarizable(src))
|
|
return 1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static bool
|
|
lower_phis_to_scalar_block(nir_block *block,
|
|
struct lower_phis_to_scalar_state *state)
|
|
{
|
|
bool progress = false;
|
|
nir_phi_instr *last_phi = nir_block_last_phi_instr(block);
|
|
|
|
/* We have to handle the phi nodes in their own pass due to the way
|
|
* we're modifying the linked list of instructions.
|
|
*/
|
|
nir_foreach_phi_safe(phi, block) {
|
|
/* Already scalar */
|
|
if (phi->def.num_components == 1)
|
|
continue;
|
|
|
|
unsigned target_width = 0;
|
|
unsigned num_components = phi->def.num_components;
|
|
target_width = state->cb(&phi->instr, state->data);
|
|
|
|
if (target_width == 0 || num_components <= target_width)
|
|
continue;
|
|
|
|
/* Create a vecN operation to combine the results. Most of these
|
|
* will be redundant, but copy propagation should clean them up for
|
|
* us. No need to add the complexity here.
|
|
*/
|
|
nir_scalar vec_srcs[NIR_MAX_VEC_COMPONENTS];
|
|
|
|
for (unsigned chan = 0; chan < num_components; chan += target_width) {
|
|
unsigned components = MIN2(target_width, num_components - chan);
|
|
nir_phi_instr *new_phi = nir_phi_instr_create(state->shader);
|
|
nir_def_init(&new_phi->instr, &new_phi->def, components,
|
|
phi->def.bit_size);
|
|
|
|
nir_foreach_phi_src(src, phi) {
|
|
nir_def *def;
|
|
state->builder.cursor = nir_after_block_before_jump(src->pred);
|
|
|
|
if (nir_src_is_undef(src->src)) {
|
|
/* Just create an undef instead of moving out of the
|
|
* original one. This makes it easier for other passes to
|
|
* detect undefs without having to chase moves.
|
|
*/
|
|
def = nir_undef(&state->builder, components, phi->def.bit_size);
|
|
} else {
|
|
/* We need to insert a mov to grab the correct components of src. */
|
|
def = nir_channels(&state->builder, src->src.ssa,
|
|
nir_component_mask(components) << chan);
|
|
}
|
|
|
|
nir_phi_instr_add_src(new_phi, src->pred, def);
|
|
}
|
|
|
|
nir_instr_insert_before(&phi->instr, &new_phi->instr);
|
|
|
|
for (unsigned i = 0; i < components; i++)
|
|
vec_srcs[chan + i] = nir_get_scalar(&new_phi->def, i);
|
|
}
|
|
|
|
state->builder.cursor = nir_after_phis(block);
|
|
nir_def *vec = nir_vec_scalars(&state->builder, vec_srcs, phi->def.num_components);
|
|
|
|
nir_def_replace(&phi->def, vec);
|
|
|
|
progress = true;
|
|
|
|
/* We're using the safe iterator and inserting all the newly
|
|
* scalarized phi nodes before their non-scalarized version so that's
|
|
* ok. However, we are also inserting vec operations after all of
|
|
* the last phi node so once we get here, we can't trust even the
|
|
* safe iterator to stop properly. We have to break manually.
|
|
*/
|
|
if (phi == last_phi)
|
|
break;
|
|
}
|
|
|
|
return progress;
|
|
}
|
|
|
|
static bool
|
|
lower_phis_to_scalar_impl(nir_function_impl *impl, nir_vectorize_cb cb, const void *data)
|
|
{
|
|
struct lower_phis_to_scalar_state state;
|
|
bool progress = false;
|
|
|
|
state.shader = impl->function->shader;
|
|
state.builder = nir_builder_create(impl);
|
|
if (cb) {
|
|
state.cb = cb;
|
|
state.data = data;
|
|
} else {
|
|
state.cb = should_lower_phi;
|
|
state.data = NULL;
|
|
}
|
|
|
|
nir_foreach_block(block, impl) {
|
|
progress = lower_phis_to_scalar_block(block, &state) || progress;
|
|
}
|
|
|
|
nir_progress(true, impl, nir_metadata_control_flow);
|
|
|
|
return progress;
|
|
}
|
|
|
|
/** A pass that lowers vector phi nodes to scalar
|
|
*
|
|
* This pass loops through the blocks and lowers looks for vector phi nodes
|
|
* it can lower to scalar phi nodes. Not all phi nodes are lowered. For
|
|
* instance, if one of the sources is a non-scalarizable vector, then we
|
|
* don't bother lowering because that would generate hard-to-coalesce movs.
|
|
*/
|
|
bool
|
|
nir_lower_phis_to_scalar(nir_shader *shader, nir_vectorize_cb cb, const void *data)
|
|
{
|
|
bool progress = false;
|
|
|
|
nir_foreach_function_impl(impl, shader) {
|
|
progress = lower_phis_to_scalar_impl(impl, cb, data) || progress;
|
|
}
|
|
|
|
return progress;
|
|
}
|
|
|
|
static uint8_t
|
|
lower_all_phis(const nir_instr *phi, const void *_)
|
|
{
|
|
return 1;
|
|
}
|
|
|
|
bool
|
|
nir_lower_all_phis_to_scalar(nir_shader *shader)
|
|
{
|
|
return nir_lower_phis_to_scalar(shader, lower_all_phis, NULL);
|
|
}
|