mesa/src
Caio Oliveira 337641cfcc intel/compiler: Fix SIMD lowering when instruction needs a larger SIMD
When lower_simd_width() encounters an instruction that needs a larger
SIMD, for example SHADER_OPCODE_TXS_LOGICAL in Gfx4 needs at least
SIMD16.  In this case the builder needs to be at least as large as
max_width, otherwise the group() setup will assert.

Turns out this did not assert before "by accident", since it was
relying on the default fs_visitor builder that had a dispatch width of 64,
a bogus placeholder value, expected not to be used.

However, when we changed the code to remove that builder (and the bogus
value), we created a new builder in the pass shader dispatch_width --
which work fine except in the case where we want to "lower" the SIMD above
the shader dispatch width.  The fix is to also consider the already
calculated max_width when creating the builder.

Fixes: 5b8ec015f2 ("intel/compiler: Don't use fs_visitor::bld in remaining places")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10338
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27782>
2024-03-01 22:54:57 +00:00
..
amd meson,windows: Use relative paths in Vulkan ICD manifest files 2024-03-01 20:09:59 +00:00
android_stub
asahi agx: add "is helper program?" key bit 2024-02-14 21:02:32 +00:00
broadcom v3dv/ci: remove crashes from expected list 2024-02-27 10:07:17 +01:00
c11
compiler nir: add search helper is_only_used_by_if 2024-03-01 13:45:11 +00:00
drm-shim compiler,vulkan,drm-shim: Remove unused include directories from meson.build 2023-10-27 01:35:10 +00:00
egl egl/wayland: Remove EGL_WL_create_wayland_buffer_from_image 2024-02-29 18:26:53 +00:00
etnaviv ci/etnaviv: update expectations 2024-02-12 01:25:24 +01:00
freedreno freedreno/ci: Update pixmark-piano-v2 hash 2024-03-01 13:45:11 +00:00
gallium auxiliary/rtasm: fix unaligned stores 2024-03-01 21:44:52 +00:00
gbm gbm: Remove hardcoded color-channel data 2024-02-27 10:51:03 +00:00
getopt
glx glx: only print zink failure-to-load messages if explicitly requested 2024-02-29 13:13:09 +00:00
gtest
imagination vulkan: Rework vk_render_pass_state::attachments 2024-02-27 22:17:09 +00:00
imgui
intel intel/compiler: Fix SIMD lowering when instruction needs a larger SIMD 2024-03-01 22:54:57 +00:00
loader loader/wayland: Add named queue fallback 2024-02-28 11:01:31 +00:00
mapi glthread: generate packed versions of gl*Pointer/Offset calls 2024-02-23 18:03:59 +00:00
mesa st/dri: Store pipe_format in gl_config 2024-02-27 10:51:03 +00:00
microsoft microsoft/compiler: Remove deref load/store/atomic ops that statically go out of array bounds 2024-03-01 20:49:17 +00:00
nouveau meson,windows: Use relative paths in Vulkan ICD manifest files 2024-03-01 20:09:59 +00:00
panfrost panvk: do not handle illegal null 2024-03-01 12:34:27 +00:00
tool perfetto/pps-producer: add optimized cpu/gpu timestamp correlation support 2023-11-09 13:22:48 +00:00
util radv: enable radv_zero_vram for RAGE2 2024-03-01 16:49:16 +00:00
virtio venus: mandate a few venus capsets long required before 1.0 2024-02-29 00:05:13 +00:00
vulkan vulkan/runtime: Allow more than 8 DRM devices 2024-03-01 21:18:44 +00:00
.clang-format ir3: allow liveness calculation for different register types 2024-03-01 13:45:10 +00:00
meson.build loader/wayland: Add fallback wl_display_dispatch_queue_timeout 2024-02-27 13:10:13 +00:00