mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-05-17 22:38:06 +02:00
f53ebfb450
While ImageFormatProperties returns the number of internal descriptors,
it turns out that applications do not need to actually allocate more
descriptors in the descriptor pool.
So if we make descriptors with more planes larger we have to be
convervative and always allocate space for the larger descriptors
which is a waste given the low usage of this ext.
So let us make use of the fact that 3plane formats all have the
same formats & dimensions for the last two planes. This way we
only need the first half of the descriptor of the 3rd plane and
can share the second half of the second plane.
This allows us to use 16 bytes for the descriptor which nicely
fits into the 16 bytes that are unused right next to the sampler.
Fixes: 5564c38212 "radv: Update descriptor sets for multiple planes."
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
123 lines
4 KiB
C
123 lines
4 KiB
C
/*
|
|
* Copyright © 2016 Bas Nieuwenhuizen
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*/
|
|
|
|
#ifndef RADV_DESCRIPTOR_SET_H
|
|
#define RADV_DESCRIPTOR_SET_H
|
|
|
|
#include <vulkan/vulkan.h>
|
|
|
|
#define MAX_SETS 32
|
|
|
|
struct radv_descriptor_set_binding_layout {
|
|
VkDescriptorType type;
|
|
|
|
/* Number of array elements in this binding */
|
|
uint32_t array_size;
|
|
|
|
uint32_t offset;
|
|
uint32_t buffer_offset;
|
|
uint16_t dynamic_offset_offset;
|
|
|
|
uint16_t dynamic_offset_count;
|
|
/* redundant with the type, each for a single array element */
|
|
uint32_t size;
|
|
|
|
/* Offset in the radv_descriptor_set_layout of the immutable samplers, or 0
|
|
* if there are no immutable samplers. */
|
|
uint32_t immutable_samplers_offset;
|
|
bool immutable_samplers_equal;
|
|
};
|
|
|
|
struct radv_descriptor_set_layout {
|
|
/* The create flags for this descriptor set layout */
|
|
VkDescriptorSetLayoutCreateFlags flags;
|
|
|
|
/* Number of bindings in this descriptor set */
|
|
uint32_t binding_count;
|
|
|
|
/* Total size of the descriptor set with room for all array entries */
|
|
uint32_t size;
|
|
|
|
/* CPU size of this struct + all associated data, for hashing. */
|
|
uint32_t layout_size;
|
|
|
|
/* Shader stages affected by this descriptor set */
|
|
uint16_t shader_stages;
|
|
uint16_t dynamic_shader_stages;
|
|
|
|
/* Number of buffers in this descriptor set */
|
|
uint32_t buffer_count;
|
|
|
|
/* Number of dynamic offsets used by this descriptor set */
|
|
uint16_t dynamic_offset_count;
|
|
|
|
bool has_immutable_samplers;
|
|
bool has_variable_descriptors;
|
|
|
|
uint32_t ycbcr_sampler_offsets_offset;
|
|
|
|
/* Bindings in this descriptor set */
|
|
struct radv_descriptor_set_binding_layout binding[0];
|
|
};
|
|
|
|
struct radv_pipeline_layout {
|
|
struct {
|
|
struct radv_descriptor_set_layout *layout;
|
|
uint32_t size;
|
|
uint32_t dynamic_offset_start;
|
|
} set[MAX_SETS];
|
|
|
|
uint32_t num_sets;
|
|
uint32_t push_constant_size;
|
|
uint32_t dynamic_offset_count;
|
|
uint16_t dynamic_shader_stages;
|
|
|
|
unsigned char sha1[20];
|
|
};
|
|
|
|
static inline const uint32_t *
|
|
radv_immutable_samplers(const struct radv_descriptor_set_layout *set,
|
|
const struct radv_descriptor_set_binding_layout *binding) {
|
|
return (const uint32_t*)((const char*)set + binding->immutable_samplers_offset);
|
|
}
|
|
|
|
static inline unsigned
|
|
radv_combined_image_descriptor_sampler_offset(const struct radv_descriptor_set_binding_layout *binding)
|
|
{
|
|
return binding->size - ((!binding->immutable_samplers_equal) ? 16 : 0);
|
|
}
|
|
|
|
static inline const struct radv_sampler_ycbcr_conversion *
|
|
radv_immutable_ycbcr_samplers(const struct radv_descriptor_set_layout *set,
|
|
unsigned binding_index)
|
|
{
|
|
if (!set->ycbcr_sampler_offsets_offset)
|
|
return NULL;
|
|
|
|
const uint32_t *offsets = (const uint32_t*)((const char*)set + set->ycbcr_sampler_offsets_offset);
|
|
|
|
if (offsets[binding_index] == 0)
|
|
return NULL;
|
|
return (const struct radv_sampler_ycbcr_conversion *)((const char*)set + offsets[binding_index]);
|
|
}
|
|
#endif /* RADV_DESCRIPTOR_SET_H */
|