mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-05-25 01:48:18 +02:00
261d48fc9b
Even if we only mask a single component from the result of CSEL.vector, in our IR we treat its semantics as vector which causes trouble with when scheduled to a scalar unit. The problematic bundle looks like this: vmul.MOV.i32 R31, TMP0.xxxx, R0.yzww sadd.MAX.i32 TMP0.y, R0.y, #65408 smul.CSEL.vector.i32 R0.y, TMP0.y, #127 As the comment in midgard.h illuminates, these CSEL instructions are actually operating per-bit, lining up with the all-1's booleans in Midgard. The Bifrost analogue is MUX.i32.bit, not CSEL.i32. We should probably rename the Midgard instruction to make that clear. Anyhoo, on the scalar unit, CSEL/MUX operates on the bottom 32-bits of its source. That's ok for the usual r31.w case, because that's secretly replicating to its nonexistent register, I think? But that doesn't work with the CSEL.vector (MUX.vector) form, because the condition it's actually muxing on is r31.x, which here is R0.y, not the intended R0.x. Rather than adding more special cases to the already overcomplicated scheduler (for the dubious benefit of avoiding a small shaderdb regression), just avoid scheduling CSEL.vector to smul. With the next patch, fixes: dEQP-GLES31.functional.draw_buffers_indexed.random.max_required_draw_buffers.1 Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19763> |
||
|---|---|---|
| .. | ||
| compiler.h | ||
| disassemble.c | ||
| disassemble.h | ||
| helpers.h | ||
| meson.build | ||
| midgard.h | ||
| midgard_address.c | ||
| midgard_compile.c | ||
| midgard_compile.h | ||
| midgard_derivatives.c | ||
| midgard_emit.c | ||
| midgard_errata_lod.c | ||
| midgard_helper_invocations.c | ||
| midgard_liveness.c | ||
| midgard_nir.h | ||
| midgard_nir_algebraic.py | ||
| midgard_nir_lower_helper_writes.c | ||
| midgard_nir_lower_image_bitsize.c | ||
| midgard_ops.c | ||
| midgard_ops.h | ||
| midgard_opt_copy_prop.c | ||
| midgard_opt_dce.c | ||
| midgard_opt_perspective.c | ||
| midgard_print.c | ||
| midgard_print_constant.c | ||
| midgard_quirks.h | ||
| midgard_ra.c | ||
| midgard_ra_pipeline.c | ||
| midgard_schedule.c | ||
| mir.c | ||
| mir_promote_uniforms.c | ||
| mir_squeeze.c | ||
| nir_fuse_io_16.c | ||