mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-03-07 03:20:28 +01:00
read-only mirror of https://gitlab.freedesktop.org/mesa/mesa
1fd3cf990e
This fixes dEQP EGL tests when glthread is enabled: dEQP-EGL.functional.sharing.gles2.multithread.random.images.copyteximage2d.* dEQP-EGL.functional.sharing.gles2.multithread.random.images.texsubimage2d.* dEQP-EGL.functional.sharing.gles2.multithread.random_egl_server_sync.images.teximage2d.* dEQP-EGL.functional.sharing.gles2.multithread.random_egl_server_sync.images.texsubimage2d.* dEQP-EGL.functional.sharing.gles2.multithread.random_egl_sync.images.copyteximage2d.* dEQP-EGL.functional.sharing.gles2.multithread.random_egl_sync.images.texsubimage2d.* Deadlock happens when: Thread A: call EGL context functions which will involve _mesa_glthread_finish(), like eglMakeCurrent() and eglDestroyContext(). It will hold the EGLDisplay.Mutex and wait on glthread job queue empty (util_queue_fence_wait(&last->fence)). glthread job thread executes batch holding gl_context.Shared.TexMutex (glthread_unmarshal_batch()). Thread B: call EGLImage import functions like EGLImageTargetTexture2DOES() which will hold gl_context.Shared.TexMutex (egl_image_target_texture()) then validate EGLImage and hold EGLDisplay.Mutex (dri2_lookup_egl_image()). This fixes the deadlock by moving the EGLImage validation out of gl_context.Shared.TexMutex lock area. Reviewed-by: Marek Olšák <marek.olsak@amd.com> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com> Signed-off-by: Qiang Yu <yuq825@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12336> |
||
|---|---|---|
| .gitlab/issue_templates | ||
| .gitlab-ci | ||
| android | ||
| bin | ||
| build-support | ||
| docs | ||
| include | ||
| src | ||
| subprojects | ||
| .dir-locals.el | ||
| .editorconfig | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| .mailmap | ||
| .travis.yml | ||
| meson.build | ||
| meson_options.txt | ||
| README.rst | ||
| REVIEWERS | ||
| VERSION | ||
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.