mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-05-19 02:48:07 +02:00
1d23cf192b
I dumped assembly generated by our driver with INTEL_DEBUG=shaders, copied and pasted it into a lua file, tried to run it with src/intel/executor, but the disassembler started telling me some instructions were invalid. This happened because we print the "compacted" flag in our assembly text, so when brw_gram.y parses our assembly flag, it sees the "compacted" flag and sets it to the instruction by calling add_instruction_option(). But the executor tool never sets the BRW_ASSEMBLE_COMPACT flag when it calls brw_assemble(), so when brw_assemble() calls dump_assembly(), which calls brw_disassbemble(), the disassembler gets confused and prints misinterpreted instructions and calls them invalid. It is not the job of brw_gram.y (our text assembly parser) to mark instructions as compacted. Whatever is later assembling the instruction is the entity that should decide if the instructions are compacted or not. So in this patch we just ignore this flag. Reviewed-by: Caio Oliveira <caio.oliveira@intel.com> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33614> |
||
|---|---|---|
| .. | ||
| blorp | ||
| ci | ||
| common | ||
| compiler | ||
| decoder | ||
| dev | ||
| ds | ||
| executor | ||
| genxml | ||
| isl | ||
| nullhw-layer | ||
| perf | ||
| shaders | ||
| tools | ||
| vulkan | ||
| vulkan_hasvk | ||
| meson.build | ||