mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2025-12-29 23:10:11 +01:00
read-only mirror of https://gitlab.freedesktop.org/mesa/mesa
1c1aa579ff
On non-Windows OSes, align_realloc is the os_realloc_aligned() from src/util/os_memory_aligned.h, which doesn't use realloc internally. Instead, it uses os_malloc_aligned() and memcpy's over the old data, which is why it needs an "old size" (unlike normal realloc). In _mesa_reserve_parameter_storage, the call to align_realloc above passes (oldValNum * sizeof(gl_constant_value)) as the old size, which is all the actual data. The actual allocation size of the array may be larger (in fact, we allocate 16 extra components), which is tracked in SizeValues. After realloc, we memset to zero starting at the old allocation size, to the new allocation size. This would work if it were a real realloc. However, because we actually malloc + memcpy and only copy the previous /data/, not the allocated size, and then memset from the old /allocated size/, our new copy will have the spaces between the old data and the old allocation size neither copied nor memset, leaving them as uninitialized garbage memory. These values then get written to the shader cache, meaning that if you compile the same shader multiple times, you may get different shader cache entries. This is bad for reproducible, deterministic compiles. While at it, we also memset to zero in _mesa_add_parameter, as this looks like another place where memset-to-zero is missing. To reproduce this error, one can run shader-db: $ MESA_SHADER_CACHE_DIR=a ./run -b shaders/godot3.4/49-28.shader_test $ MESA_SHADER_CACHE_DIR=b ./run -b shaders/godot3.4/49-28.shader_test and see an occasional difference in the end of the ParameterValues array, where there's a padding gap between the last two elements that was never zero-initialized. Thanks to Mark Janes for discovering this and tracking it down together! Cc: mesa-stable Reviewed-by: Mark Janes <markjanes@swizzler.org> Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25316> |
||
|---|---|---|
| .ci-farms | ||
| .ci-farms-disabled | ||
| .github/workflows | ||
| .gitlab | ||
| .gitlab-ci | ||
| android | ||
| bin | ||
| build-support | ||
| docs | ||
| include | ||
| src | ||
| subprojects | ||
| .clang-format | ||
| .clang-format-ignore | ||
| .clang-format-include | ||
| .dir-locals.el | ||
| .editorconfig | ||
| .git-blame-ignore-revs | ||
| .gitattributes | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| .graphqlrc.yml | ||
| .mailmap | ||
| CODEOWNERS | ||
| meson.build | ||
| meson_options.txt | ||
| README.rst | ||
| VERSION | ||
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.