mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-05-27 18:48:14 +02:00
110f14d4b4
The idea is that for repeated use of the same uniform, we could avoid loading it on each consumer. The results look pretty good. total instructions in shared programs: 6413571 -> 6521464 (1.68%) total threads in shared programs: 154214 -> 154000 (-0.14%) total uniforms in shared programs: 2393604 -> 2119629 (-11.45%) total spills in shared programs: 4960 -> 4984 (0.48%) total fills in shared programs: 6350 -> 6418 (1.07%) Once we do scheduling at the NIR level, the register pressure (and thus also instructions) issues we see here will drop back down.
108 lines
4.3 KiB
C
108 lines
4.3 KiB
C
/*
|
|
* Copyright © 2014 Broadcom
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*/
|
|
|
|
/**
|
|
* @file v3d_opt_small_immediates.c
|
|
*
|
|
* Turns references to small constant uniform values into small immediates
|
|
* fields.
|
|
*/
|
|
|
|
#include "v3d_compiler.h"
|
|
|
|
static bool debug;
|
|
|
|
bool
|
|
vir_opt_small_immediates(struct v3d_compile *c)
|
|
{
|
|
bool progress = false;
|
|
|
|
vir_for_each_inst_inorder(inst, c) {
|
|
if (inst->qpu.type != V3D_QPU_INSTR_TYPE_ALU)
|
|
continue;
|
|
|
|
/* The small immediate value sits in the raddr B field, so we
|
|
* can't have 2 small immediates in one instruction (unless
|
|
* they're the same value, but that should be optimized away
|
|
* elsewhere).
|
|
*/
|
|
bool uses_small_imm = false;
|
|
for (int i = 0; i < vir_get_nsrc(inst); i++) {
|
|
if (inst->src[i].file == QFILE_SMALL_IMM)
|
|
uses_small_imm = true;
|
|
}
|
|
if (uses_small_imm)
|
|
continue;
|
|
|
|
for (int i = 0; i < vir_get_nsrc(inst); i++) {
|
|
if (inst->src[i].file != QFILE_TEMP)
|
|
continue;
|
|
|
|
/* See if it's a uniform load. */
|
|
struct qinst *src_def = c->defs[inst->src[i].index];
|
|
if (!src_def || !src_def->qpu.sig.ldunif)
|
|
continue;
|
|
int uniform = src_def->uniform;
|
|
|
|
if (c->uniform_contents[uniform] != QUNIFORM_CONSTANT)
|
|
continue;
|
|
|
|
/* Check if the uniform is suitable as a small
|
|
* immediate.
|
|
*/
|
|
uint32_t imm = c->uniform_data[uniform];
|
|
uint32_t packed;
|
|
if (!v3d_qpu_small_imm_pack(c->devinfo, imm, &packed))
|
|
continue;
|
|
|
|
/* Check that we don't have any other signals already
|
|
* that would be incompatible with small_imm.
|
|
*/
|
|
struct v3d_qpu_sig new_sig = inst->qpu.sig;
|
|
uint32_t sig_packed;
|
|
new_sig.small_imm = true;
|
|
if (!v3d_qpu_sig_pack(c->devinfo, &new_sig, &sig_packed))
|
|
continue;
|
|
|
|
if (debug) {
|
|
fprintf(stderr, "opt_small_immediate() from: ");
|
|
vir_dump_inst(c, inst);
|
|
fprintf(stderr, "\n");
|
|
}
|
|
inst->qpu.sig.small_imm = true;
|
|
inst->qpu.raddr_b = packed;
|
|
|
|
inst->src[i].file = QFILE_SMALL_IMM;
|
|
inst->src[i].index = imm;
|
|
if (debug) {
|
|
fprintf(stderr, "to: ");
|
|
vir_dump_inst(c, inst);
|
|
fprintf(stderr, "\n");
|
|
}
|
|
progress = true;
|
|
break;
|
|
}
|
|
}
|
|
|
|
return progress;
|
|
}
|