mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-02-02 02:20:25 +01:00
0c5d772b71
This has one negative side-effect; we're no longer able to print validation errors without dxcompiler.dll. I doubt that's a real problem, but if it is, we should add this ability to dxil_validator instead of having a second implementation here. The reasons I didn't try adding this in the first place is: 1. This code seems a bit janky; it doesn't consult the "known"-variable to figure out if the encoding is OK, and it's lacking a fallback path in that case. 2. It seems unlikely that the compiler varies the encoding of the output in the first place; one of the two code-paths in here is probably untested. 3. Since dxil_validator leaves reporting to the call-site, we'd need to either add and output-encoding to the API (yuck), or re-encode the string to UTF-8 using WinAPI. Right now, it seems questionable if fixing all of the above is worth it. Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15751> |
||
|---|---|---|
| .. | ||
| ci | ||
| clc | ||
| compiler | ||
| resource_state_manager | ||
| spirv_to_dxil | ||
| vulkan | ||
| meson.build | ||