mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-04-21 14:10:37 +02:00
read-only mirror of https://gitlab.freedesktop.org/mesa/mesa
03df494ea4
Let's be slightly more defensive here. If a texture image doesn't have an associated pipe_resource allocated, then render_texture() will pass that along to _mesa_update_renderbuffer_surface(), which will crash on a NULL pointer dereference. So, if there isn't a pipe_resource, then we should just skip this altogteher. Today, this isn't an issue, because each gl_texture_image always allocates a pipe_resource up front. On a branch of mine, I prototyped some improvements to the compressed texture fallback handling, where it would defer resource allocation, examine the source image's block data, and dynamically select a format based on that, then allocate it later. With that prototype in place, we saw crashes the Android "My Talking Tom" series of games, which appear to be attaching ASTC textures to a framebuffer color attachment. That FBO would be incomplete anyway, as ASTC textures aren't renderable, but we got into a situation where the render-to-texture code was crashing due to the lack of pt before it could properly signal that it was incomplete and bailing. Technically, we don't need this now, but I figure that being defensive won't hurt and this would probably save whoever encounters such an issue in the future a bunch of frustrating debugging. Reviewed-by: Marek Olšák <marek.olsak@amd.com> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17508> |
||
|---|---|---|
| .github/workflows | ||
| .gitlab/issue_templates | ||
| .gitlab-ci | ||
| android | ||
| bin | ||
| build-support | ||
| docs | ||
| include | ||
| src | ||
| subprojects | ||
| .dir-locals.el | ||
| .editorconfig | ||
| .gitattributes | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| .mailmap | ||
| CODEOWNERS | ||
| meson.build | ||
| meson_options.txt | ||
| README.rst | ||
| VERSION | ||
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.