Tomeu Vizoso
da77188d7d
etnaviv/ml: Implement FullyConnected
...
Lower FullyConnected to a regular convolution so it executes in the NN
cores.
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32510 >
2024-12-06 16:03:05 +00:00
Tomeu Vizoso
ad82a7c388
teflon: Add tests for FullyConnected
...
Same as we do with convolutions and additions.
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32510 >
2024-12-06 16:03:05 +00:00
Tomeu Vizoso
3d8f108514
teflon: Add support for FullyConnected
...
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32510 >
2024-12-06 16:03:05 +00:00
Tomeu Vizoso
3e74234450
etnaviv/ml: Add support for tensor padding operations
...
Just one more TP operation, at least for the pad modes supported.
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32509 >
2024-12-06 15:09:52 +00:00
Tomeu Vizoso
02e92bbcea
teflon: Add support for tensor padding operations
...
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32509 >
2024-12-06 15:09:52 +00:00
Tomeu Vizoso
6c70b10f03
etna/ml: Write out the size of the requested tensor
...
Instead of the size of its backing resource.
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32498 >
2024-12-06 13:29:11 +00:00
Tomeu Vizoso
fe08834004
teflon: Limit support for Add to two unpopulated tensors
...
As the only implementations depend of both inputs coming from
convolutions.
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32498 >
2024-12-06 13:29:11 +00:00
Tomeu Vizoso
c2d1f08116
etnaviv/ml: Add support for tensor split and concatenation operations
...
Just point previous and further operations to offsets in a combined
tensor.
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32498 >
2024-12-06 13:29:11 +00:00
Tomeu Vizoso
4ced6480ea
teflon: Add support for tensor split and concatenation operations
...
These are often use to reuse the output from a previous operation, or to
implement convolution groups.
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32498 >
2024-12-06 13:29:11 +00:00
Tomeu Vizoso
418f864ae4
etnaviv/ml: Take offsets into account in TP operations
...
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32498 >
2024-12-06 13:29:11 +00:00
Tomeu Vizoso
566166b0aa
etnaviv/ml: Fix in_image_slice in transposes when width != height
...
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32498 >
2024-12-06 13:29:11 +00:00
Tomeu Vizoso
10bd5c23c6
etnaviv/ml: Specify which of the input tensors need transposing.
...
In preparation for operations that have more than one input that may
need transposing, such as Add.
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32498 >
2024-12-06 13:29:11 +00:00
Georg Lehmann
d47deba142
zink: spec@ext_framebuffer_multisample@blit-mismatched-formats was fixed
...
Fixed in https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31378
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32522 >
2024-12-06 12:58:47 +00:00
David Rosca
3dd6ddde3b
radeonsi/vcn: Cleanup JPEG supported formats
...
Stop reporting L8_UNORM as supported.
Remove unsupported IYUV, YV12, P010 and P016 formats from list,
add rest of the supported formats and add assert.
Reviewed-by: David (Ming Qiang) Wu <David.Wu3@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32504 >
2024-12-06 11:24:53 +00:00
David Rosca
22ced06ee6
radeonsi/vcn: Make sure JPEG target buffer format matches sampling factor
...
Reviewed-by: David (Ming Qiang) Wu <David.Wu3@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32504 >
2024-12-06 11:24:53 +00:00
David Rosca
1a7d956c75
radeonsi/vcn: Gracefully handle decode errors and report to frontend
...
Previously it would print error message and then most likely crash later.
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32504 >
2024-12-06 11:24:53 +00:00
David Rosca
9a3a1027a6
radeonsi/vcn: Unmap bitstream buffer in radeon_dec_destroy
...
If an error occured, the bitstream buffer may still be mapped when
calling radeon_dec_destroy and this would trigger assert when destroying
the bo.
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32504 >
2024-12-06 11:24:53 +00:00
David Rosca
ed5794c5e3
radeonsi/vcn: Remove code handling buffer_get_virtual_address failure
...
buffer_get_virtual_address can't return zero.
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32504 >
2024-12-06 11:24:53 +00:00
David Rosca
5f3a93dacf
frontends/va: Move mjpeg sampling_factor to pipe_mjpeg_picture_desc
...
Reviewed-by: David (Ming Qiang) Wu <David.Wu3@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32504 >
2024-12-06 11:24:53 +00:00
David Rosca
1a90c3102b
radeonsi/vcn: Don't allow encoding H264 B-frame references
...
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12242
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32479 >
2024-12-06 10:00:47 +00:00
David Rosca
cd8ad03364
frontends/va: Store picture type for buffers in encode DPB
...
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32479 >
2024-12-06 10:00:47 +00:00
Eric R. Smith
a2f96667e2
mesa: update more drivers to handle pipe_blit_info swizzle_enable
...
Handle swizzling by falling through to the software path. Swizzle
should be rarely enabled, so this shouldn't affect performance in
most cases.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31378 >
2024-12-05 18:27:37 +00:00
Eric R. Smith
3da4a404ae
aux: add support for dumping the swizzle in pipe_blit_info
...
Just some additional debug code for the new blit swizzle feature.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31378 >
2024-12-05 18:27:37 +00:00
Eric R. Smith
b81aefcc19
mesa: when blitting between formats clear any unused components
...
If the state tracker chooses to implement one format with a more
general one (e.g. GL_ALPHA implemented with GL_RGBA) we end up
in a situation where some components should be ignored. Readpix
handles this correctly, but blit does not, which means that if
we blit between different formats we can end up writing garbage
into some components. Work around this by adding an explicit
swizzle to the pipe_blit_info struct, which can re-arrange elements
and/or put 0 or 1 into appropriate channels, and use this to
set the appropriate values into unused channels via the sampler
view.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31378 >
2024-12-05 18:27:37 +00:00
Tomeu Vizoso
3aad0afc30
teflon/tests: Also use the cache for models in the test suite
...
To speed things up now that we have more models under testing.
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32485 >
2024-12-05 17:02:27 +00:00
Tomeu Vizoso
74239aeb77
teflon/tests: Add support for models with float inputs and outputs
...
Ended up deciding to drop C++ collections and use instead C pointers
because the template use was starting to get ridiculous.
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32485 >
2024-12-05 17:02:27 +00:00
Tomeu Vizoso
f21d8af43a
teflon: Don't crash when a tensor isn't quantized
...
We don't support yet hardware that can deal with floats, but it is
better not to crash.
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32485 >
2024-12-05 17:02:27 +00:00
Tomeu Vizoso
a548b17b4e
teflon: Rename model tests so they aren't skipped by gtest-runner
...
The regular expression engine in gtest-runner was matching more tests
than we wanted, so we weren't testing all we thought.
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32485 >
2024-12-05 17:02:26 +00:00
Tomeu Vizoso
1e117478d4
teflon: Support tests with inputs with less than 4 dims
...
Needed in models such as YOLOX.
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32485 >
2024-12-05 17:02:26 +00:00
Tomeu Vizoso
140150083e
teflon: Add tests for the YOLOX model
...
The model was generated from:
https://github.com/Megvii-BaseDetection/YOLOXa (Apache License 2.0)
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32485 >
2024-12-05 17:02:26 +00:00
David Rosca
8d3d35bf05
frontends/va: Add support for VA_SURFACE_ATTRIB_MEM_TYPE_DRM_PRIME_3
...
Reviewed-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32113 >
2024-12-05 16:34:09 +00:00
Eric R. Smith
aba90c1523
panfrost: check afbc status in panfrost_query_compression_modifiers
...
In panfrost_query_compression_modifiers we need to ignore AFBC
modifiers if the device does not support AFBC. In order to avoid
duplicating code, we do this by calling panfrost_walk_dmabuf_modifiers
with a flag that indicates we do not want AFRC modifiers.
Reviewed-by: Louis-Francis Ratté-Boulianne <lfrb@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32406 >
2024-12-05 14:54:09 +00:00
Marek Olšák
dfc2f054b6
radeonsi/ci: update navi31 failures
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32288 >
2024-12-05 12:07:06 +00:00
Marek Olšák
ed4606a062
radeonsi/ci: remove --slow
...
The tests were split or reduced in glcts.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32288 >
2024-12-05 12:07:06 +00:00
Marek Olšák
c0ccae84a7
radeonsi/ci: remove most flakes and some skips, update navi31 failures
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32288 >
2024-12-05 12:07:06 +00:00
Marek Olšák
af618dd907
radeonsi/ci: stop using a global flakes list, only use a per-chip flakes list
...
We need to start treating flakes as fails and they are likely different
between chips.
I removed the gfx9 flakes file and renamed the original flakes file
to gfx6-tahiti-flakes.csv, but it would be better to add a new flakes
file for each generation we test.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32288 >
2024-12-05 12:07:06 +00:00
Marek Olšák
3ff8111fc6
radeonsi/ci: handle glinfo errors better
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32288 >
2024-12-05 12:07:06 +00:00
Marek Olšák
738a501e92
radeonsi: don't compute total_direct_count in si_draw if it's unused
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32288 >
2024-12-05 12:07:06 +00:00
Marek Olšák
ed372d4b7c
radeonsi: try to fix Navi14 regression in debug builds
...
Assertion failure:
../src/gallium/drivers/radeonsi/si_state_shaders.cpp:1369: unsigned int si_get_input_prim(const
si_shader_selector*, const si_shader_key*, bool): Assertion `gs->stage == MESA_SHADER_VERTEX' failed.
Fixes: 7e959864b2 ("radeonsi: enable NGG culling for non-monolithic TES and GS")
Tested-by: Michel Dänzer <mdaenzer@redhat.com>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32288 >
2024-12-05 12:07:06 +00:00
Marek Olšák
a3c293cdcd
radeonsi: revert to always returning true for load_cull_any_enabled_amd
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32288 >
2024-12-05 12:07:06 +00:00
Marek Olšák
511a637a5c
radeonsi: pass cull face state via user SGPRs for shader culling
...
The culling code always computes the determinant for culling zero-area
triangles, so passing the state via user SGPRs doesn't really add much
shader code to justify having shader variants for front/back face
culling that uses the same determinant.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32288 >
2024-12-05 12:07:06 +00:00
Pavel Ondračka
ecc4d5da67
i915/ci: update CI expectations
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32494 >
2024-12-05 09:35:43 +00:00
Boris Brezillon
7e78aa73dd
panfrost: Use nir_shader_intrinsics_pass() for the line_smooth lowering pass
...
We have a helper function to iterate only on intrinsics, so let's use it.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com>
Reviewed-by: Chia-I Wu <olvaffe@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32480 >
2024-12-05 08:49:45 +00:00
Boris Brezillon
34beb93635
panfrost: s/NIR_PASS_V/NIR_PASS/
...
Move away from NIR_PASS_V() like other drivers have done long ago.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com>
Reviewed-by: Chia-I Wu <olvaffe@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32480 >
2024-12-05 08:49:45 +00:00
Kai Wasserbäch
8a453669e2
fix(FTBFS): clc/clover: pass a VFS instance explicitly
...
This just replicates what upstream did before breaking mesa with commit
df9a14d7bbf and requiring a VFS instance.
Reported-by: @Lone_Wolf
Reference: <df9a14d7bb >
Closes: <https://gitlab.freedesktop.org/mesa/mesa/-/issues/12223 >
Signed-off-by: Kai Wasserbäch <kai@dev.carbon-project.org>
Tested-by: Dieter Nützel <Dieter@nuetzel-hh.de>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32439 >
2024-12-04 19:55:56 +00:00
Karol Herbst
12752228db
rusticl/util: rename Properties::from_ptr to new
...
Reviewed-by: @LingMan
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32268 >
2024-12-04 16:20:08 +00:00
Karol Herbst
d791135df1
rusticl/api: remove Option around Properties
...
It already has the right semantics we are looking for.
Reviewed-by: @LingMan
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32268 >
2024-12-04 16:20:08 +00:00
Karol Herbst
825936b3f8
rusticl/util: make Properties::from_ptr unsafe
...
Reviewed-by: @LingMan
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32268 >
2024-12-04 16:20:07 +00:00
Karol Herbst
86453fe053
rusticl/api: use Properties for 0 terminated arrays consistently
...
Now that the semantics of Properties match exactly what we need here,
let's use it for all queries with 0 terminated arrays.
Reviewed-by: @LingMan
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32268 >
2024-12-04 16:20:07 +00:00
Karol Herbst
976dd83a7a
rusticl/api: simplify CLProp implementation of Properties
...
Reviewed-by: @LingMan
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32268 >
2024-12-04 16:20:07 +00:00