Rob Clark
9b2780dcaf
freedreno/a6xx: Re-work fd6_emit_shader
...
Shuffle around a bit of the state emit, so that it more closely matches
tu_emit_xs().
Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24999 >
2023-09-11 19:45:19 +00:00
Rob Clark
a11e3f35df
freedreno/a6xx: Drop unused screen args
...
Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24999 >
2023-09-11 19:45:19 +00:00
Pavel Ondračka
38694b7386
r300: reduce number of iterations for vertex shader loops
...
Using the default value leads to occasional hangs on RV516 for unknown
reasons. Set it to 128 insted of 255.
dEQP and piglit are still happy and I don't expect any real app to hit
this, but lets see. As a side effect this boosts fps in the apps that
have non-unrollable vertex shaders (as the shaders now effectivelly run
almost two times faster) and ~5% dEQP runtime decrease.
Reviewed-by: Filip Gawin <filip.gawin@collabora.com>
Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7934
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20873 >
2023-09-11 19:30:52 +00:00
Chia-I Wu
ccd3bb4548
winsys/radeon: fix a race between bo import and destroy
...
This is similar to commit 85e74944c6 ("winsys/amdgpu: fix a race
between import and destroy") but for winsys/radeon. In short, we need
to check the reference count again after bo_handles_mutex is held.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25133 >
2023-09-11 19:11:29 +00:00
Mike Blumenkrantz
39aa483760
zink: set optimal_keys for turnip jobs
...
nobody cares about stipple on turnip for real world scenarios, so
testing it instead of the thing that people will actually want is pointless
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25037 >
2023-09-11 14:48:31 +00:00
Mike Blumenkrantz
cf66ed2dec
zink: imply ZINK_DEBUG=quiet if ZINK_DEBUG=optimal_keys is set on turnip
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25037 >
2023-09-11 14:48:31 +00:00
Mike Blumenkrantz
1e1f58c1ac
zink: add ZINK_DEBUG=quiet
...
mainly for use with ZINK_DEBUG=optimal_keys on turnip since spamming
a warning like that constantly is pointless
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25037 >
2023-09-11 14:48:31 +00:00
Daniel Stone
cb76e90793
ci/zink: Add new zink-lvp flakes
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25149 >
2023-09-11 14:10:23 +00:00
Daniel Stone
077e2da21e
ci/d3d12: Add new flake
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25149 >
2023-09-11 14:10:23 +00:00
Alba Mendez
e3aab80d4f
meson: support installation tags
...
the only thing missing is to tag custom install targets, namely:
- ICDs (vulkan, glvnd, OpenCL, VA-API, VDPAU)
- Vulkan layers
- custom install script for megadrivers
- drirc file
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24911 >
2023-09-11 13:00:45 +00:00
Connor Abbott
252aee2634
freedreno, ir3, tu: Constify various uses of ir3_shader_variant
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25076 >
2023-09-11 10:34:10 +00:00
Connor Abbott
5666758820
tu, freedreno/a6xx: Don't use VS for PrimID passthru state
...
Emit the registers solely based on whether FS reads PrimID, and assume
the HW will do the right thing and disable PrimID passthru when GS is
enabled. This untangles these registers so we can set them from the FS
draw state in the future.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25076 >
2023-09-11 10:34:10 +00:00
Connor Abbott
b312155cc5
tu: Rename PrimID-related registers
...
It turns out that the hardware automatically selects whether PrimID
passthrough needs to happen based on whether GS is enabled, which means
that it's safe to always set these registers based whether PrimID is
read by the FS and the hardware will ignore them when GS is enabled. Use
the real names for these registers to make it less confusing when we
start to do that.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25076 >
2023-09-11 10:34:10 +00:00
Ganesh Belgur Ramachandra
51773d135d
radeonsi: sets OPTIMAL_BIN_SELECTION to 0 if using bottom_edge_rule
...
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24725 >
2023-09-11 04:24:41 -05:00
Ganesh Belgur Ramachandra
86b4fe5d68
radeonsi: stores bottom_edge_rule option in the rasterizer state
...
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24725 >
2023-09-11 04:23:59 -05:00
Dave Airlie
2d4fe5f229
clover/llvm: move to modern pass manager.
...
This seems like it should work, but I haven't tested it yet.
Tested-by: Dieter Nützel <Dieter@nuetzel-hh.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24879 >
2023-09-11 13:04:07 +10:00
Erico Nunes
cb1c88d41f
lima: fix plbu block stride calculation
...
For some specific texture sizes, notably some texture sizes with width
4096, block stride calculation could end up calculating stride 256 which
is an invalid value.
In those specific cases, this could cause rendering artifacts or
application/driver crashes.
Cc: mesa-stable
Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25084 >
2023-09-10 20:41:24 +00:00
Mike Blumenkrantz
94941de25b
zink: delete all psiz=1.0 stores if maintenance5 is present
...
this frees up an output location woooo
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24782 >
2023-09-09 15:44:45 +00:00
Mike Blumenkrantz
23df2bf41b
zink: slightly refactor psiz deletion during linking
...
no functional changes
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24782 >
2023-09-09 15:44:45 +00:00
Mike Blumenkrantz
6d5174974a
zink: use HIC for image subdata when possible
...
this has a lot of caveats:
* extension must be supported
* resource must have usage bit set
* resource must not have any pending batch usage
* resource must be in supported layout
if all of these conditionals pass, then HIC can be used for direct image subdata
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24775 >
2023-09-09 13:02:44 +00:00
Mike Blumenkrantz
f24891269d
zink: check/use suboptimal HIC during ici init
...
this allows implicit use of HIC where possible while rejecting it when
it would cause performance loss
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24775 >
2023-09-09 13:02:44 +00:00
Mike Blumenkrantz
e006a3d8bc
zink: use some return codes for check_ici errors
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24775 >
2023-09-09 13:02:44 +00:00
Mike Blumenkrantz
4feb37d629
zink: fix some off-by-one indentation
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24775 >
2023-09-09 13:02:44 +00:00
Mike Blumenkrantz
9907573d98
zink: add a fixup method for extra driver props
...
some extensions have "extra" props which need the get_count -> get_prop_array
dance, and codegen is too stupid to figure this out (and probably always will be)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24775 >
2023-09-09 13:02:44 +00:00
Mike Blumenkrantz
9ff5026100
zink: disable HIC without resizable BAR
...
this otherwise ooms the system
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24775 >
2023-09-09 13:02:44 +00:00
Mike Blumenkrantz
f95134468a
zink: move mem type detection up in file
...
no functional changes
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24775 >
2023-09-09 13:02:44 +00:00
Mike Blumenkrantz
521800cf59
zink: hook up VK_EXT_host_image_copy
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24775 >
2023-09-09 13:02:44 +00:00
Mike Blumenkrantz
5edcab3385
lavapipe: don't advertise UNDEFINED layout for HIC
...
this is illegal
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24775 >
2023-09-09 13:02:44 +00:00
Mike Blumenkrantz
943909514e
lavapipe: handle VkHostImageCopyDevicePerformanceQueryEXT
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24775 >
2023-09-09 13:02:44 +00:00
Mike Blumenkrantz
87fa46c10d
zink: use VkFormatProperties3
...
but wrap it in a smaller type to save some space
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24775 >
2023-09-09 13:02:44 +00:00
Mike Blumenkrantz
e02441b000
zink: simplify redundant is_buffer check
...
it's in the params
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24775 >
2023-09-09 13:02:43 +00:00
Kenneth Graunke
fb3e37a014
virgl, nir_to_tgsi: Add a hack for promoting partial memory barriers
...
Most drivers will want nir_opt_barrier_modes() to optimize out
unnecessary memory barrier modes. However, virgl has to translate
back to GLSL, which means it can really only handle partial memory
barriers in compute shaders today, because there isn't a proper
way to express them otherwise. Just ask nir_to_tgsi to promote
these back to full barriers as a workaround.
See KHR-GL43.shader_storage_buffer_object.advanced-readWrite-case1
on virpipe-on-gl as a case where this hack is needed.
Acked-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24842 >
2023-09-09 04:41:24 +00:00
Kenneth Graunke
dd92fd8fcc
lavapipe: Don't delete control barriers
...
Control barriers still need to do synchronization even if there are no
associated memory barrier modes.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24842 >
2023-09-09 04:41:24 +00:00
Mike Blumenkrantz
17a35412dc
zink: re-rework i/o variable handling to make having variables entirely optional
...
old variables are now only used for copying names if possible, which should
make it possible for zink to process shaders which have no variables at all
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24950 >
2023-09-09 04:15:44 +00:00
Mike Blumenkrantz
8b4904405e
zink: use right function to get src_type in eliminate_io_wrmasks
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24950 >
2023-09-09 04:15:44 +00:00
Mike Blumenkrantz
459b49a174
zink: add a new linker pass to handle mismatched i/o components
...
this is the inverted version of rewrite_read_as_0 which tests for mismatched
component i/o on a given location and rewrites the inputs to zero if the
producer shader didn't write to the component
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24950 >
2023-09-09 04:15:44 +00:00
Mike Blumenkrantz
9af2f17937
zink: create new vars without copying existing ones
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24950 >
2023-09-09 04:15:44 +00:00
Mike Blumenkrantz
86668052dd
zink: use explicit sizing for builtins when creating variables
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24950 >
2023-09-09 04:15:44 +00:00
Mike Blumenkrantz
53dab1cf40
zink: use MAX_PATCH_VERTICES directly for arrayed io var sizing
...
no functional changes
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24950 >
2023-09-09 04:15:44 +00:00
Mike Blumenkrantz
e81048a0e2
zink: use explicit stride from types instead of copying old_var stride
...
should be no functional changes
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24950 >
2023-09-09 04:15:44 +00:00
Mike Blumenkrantz
3c422ba518
zink: simplify an arrayed io check during variable creation
...
no functional changes
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24950 >
2023-09-09 04:15:44 +00:00
Mike Blumenkrantz
dcc1d115f9
zink: use nir_io_semantics::num_slots for indirect var creation
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24950 >
2023-09-09 04:15:43 +00:00
Mike Blumenkrantz
a91d920a63
zink: delete some bindless io lowering code
...
now that variables are pre-converted this is no longer necessary
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24950 >
2023-09-09 04:15:43 +00:00
Mike Blumenkrantz
7fdc74b078
zink: fix typing on bindless io lowering
...
with lowered io this should always be an ivec2
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24950 >
2023-09-09 04:15:43 +00:00
Mike Blumenkrantz
a3ce422a99
zink: reorder bindless io lowering
...
should be no functional changes
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24950 >
2023-09-09 04:15:43 +00:00
Mike Blumenkrantz
e87b24719f
zink: set is_xfb=false for all i/o variables
...
this can affect streamout generation, even though it so far hasn't
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24950 >
2023-09-09 04:15:43 +00:00
Mike Blumenkrantz
20cbc6b9a0
zink: ci updates
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24962 >
2023-09-09 03:44:05 +00:00
Mike Blumenkrantz
39b814b2a6
zink: handle multi-plane implicit sync
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24962 >
2023-09-09 03:44:05 +00:00
Mike Blumenkrantz
d4f8ad27f2
zink: handle implicit sync for dmabufs
...
this adds explicit queue transitions to FOREIGN at the end of the batch
for all written-to dmabufs, then also adds signal/wait semaphores
using the dmabuf fds
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24962 >
2023-09-09 03:44:05 +00:00
Mike Blumenkrantz
4932e65f1e
zink: hook up cached fd semaphore usage for batch signal/waits
...
not yet used, matches handling of normal semaphores
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24962 >
2023-09-09 03:44:05 +00:00