6 commits

Author	SHA1	Message	Date
Alyssa Rosenzweig	190b1fdc64	nir: Convert to nir_foreach_function_impl ... Done by hand at each call site but going very quickly with funny Vim motions and common regexes. This is a very common idiom in NIR. Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23807>	2023-06-27 22:44:04 +00:00
Alyssa Rosenzweig	99a00e2247	treewide: Use nir_trim_vector more ... Via Coccinelle patches @@ expression a, b, c; @@ -nir_channels(b, a, (1 << c) - 1) +nir_trim_vector(b, a, c) @@ expression a, b, c; @@ -nir_channels(b, a, BITFIELD_MASK(c)) +nir_trim_vector(b, a, c) @@ expression a, b; @@ -nir_channels(b, a, 3) +nir_trim_vector(b, a, 2) @@ expression a, b; @@ -nir_channels(b, a, 7) +nir_trim_vector(b, a, 3) Plus a fixup for pointless trimming an immediate in RADV and radeonsi. Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23352>	2023-06-06 18:52:25 +00:00
Thomas H.P. Andersen	a18a51a708	nir/nir_lower_vec3_to_vec4: Use the nir_shader_instructions_pass() helper ... Extracts some per-impl code to nir_lower_vec3_to_vec4 and then converts to use the nir_shader_instructions_pass helper. Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11683>	2023-04-22 23:35:37 +00:00
Jason Ekstrand	e20e85f01e	nir: Make nir_ssa_def_rewrite_uses_after take an SSA value ... This replaces the new_src parameter of nir_ssa_def_rewrite_uses_after() with an SSA def, and rewrites all the users as needed. Acked-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Eric Anholt <eric@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9383>	2021-03-08 16:59:55 +00:00
Jason Ekstrand	379d535480	nir/vec3_to_vec4: Use nir_deref_must_be ... We use the same nir_deref_mode_is_in_set helper that we use in nir_lower_vars_to_explicit_types for the same reason. If there are any generic pointers in play, we have to lower all generic pointer modes at the same time or else we risk types getting out-of-sync. Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6332>	2020-11-03 22:18:28 +00:00
Jason Ekstrand	b2e1fc8976	nir: Add a pass to lower vec3s to vec4s ... LLVM loves take advantage of the fact that vec3s in OpenCL are 16B aligned and so it can just read/write them as vec4s. This results in a LOT of vec4->vec3 casts on loads and stores. One solution to this problem is to get rid of all vec3 variables. Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6871>	2020-10-02 07:30:49 +00:00