Commit graph

70720 commits

Author SHA1 Message Date
Julia Zhang
3fa212c4f5 virgl: Small fix of converting format
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Convert pipe format to virgl format since virglrenderer will convert it
back from virgl format to pip format when create pipe_resource.

According to the call stack, only if vflags include flag:
PIPE_RESOURCE_FLAG_MAP_PERSISTENT or PIPE_RESOURCE_FLAG_MAP_COHERENT
will make it call into virgl_drm_winsys_resource_create_blob() so here
remove redundant if condition in virgl_drm_winsys_resource_create_blob().

Signed-off-by: Julia Zhang <julia.zhang@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36672>
2025-08-08 13:47:03 +00:00
Karol Herbst
9d8c95f8d3 zink: fix data race in descriptor_util_pool_key_get
Two threads could end up creating a pool_key for the same hash and end up
overwriting the earlier one.

Fixes flaky image kernel_read_write CL CTS tests.

Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36652>
2025-08-08 10:26:52 +00:00
Alyssa Rosenzweig
1ef97241d7 asahi: reduce ppp alignment
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36633>
2025-08-08 10:10:58 +00:00
Alyssa Rosenzweig
7297a699f7 asahi: clang-format
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36633>
2025-08-08 10:10:57 +00:00
Valentine Burley
d2a1acaa2c zink/ci: Document flakes on ANV
Signed-off-by: Valentine Burley <valentine.burley@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36662>
2025-08-08 09:54:12 +02:00
Valentine Burley
b2eba071c5 zink/ci: Skip flaky tests on CML due to HW deficiency
This is a known hardware limitation on Gfx9 that can cause intermittent
failures. See https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36348#note_3037412.

Signed-off-by: Valentine Burley <valentine.burley@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36662>
2025-08-08 09:02:28 +02:00
Konstantin Seurer
38db7119cc lavapipe: Mask invalid shader stage flags
lvp_execute.c iterates over all set bits which can cause oob access.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13512
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36371>
2025-08-07 20:46:24 +00:00
Marek Olšák
1ddbe7e818 radeonsi/gfx12: print swizzle modes for AMD_TEST=imagecopy
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36578>
2025-08-07 18:12:53 +00:00
Mike Blumenkrantz
d476a8c07b zink: stop always syncing threaded flushes
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
async flushes are meant to be async here, and the other ones are manually
synced later in the function

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36643>
2025-08-07 16:00:54 +00:00
Mike Blumenkrantz
f5f7a5f801 zink: don't access ctx in submit_queue
this can be executed from a thread

Fixes: 63e17ccc0a ("zink: rework sparse semaphore waits")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36643>
2025-08-07 16:00:54 +00:00
Gert Wollny
fa2bd65171 r600/sfn: Move RA helper class declaration into implementation file
There is no need that these types are exposed.

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36586>
2025-08-07 14:23:25 +00:00
Gert Wollny
2bb3e5c265 r60/sfn: Update .clang-format
* Short inline methods in headers may stay on one line.
* Include system headers last to avoid hidden dependencies.

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36542>
2025-08-07 14:08:46 +00:00
Karol Herbst
45c28a20a4 rusticl/gl: flush and wait on gl objects inside clEnqueueAcquireGLObjects
This fixes flakes in the gl/gles OpenCL CTS tests on radeonsi and zink.

Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36249>
2025-08-07 12:58:33 +00:00
Karol Herbst
f6b844e239 rusticl/gl: only flush objects on import if we get a valid fd
If no context is current we might not get anything to wait on.

Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36249>
2025-08-07 12:58:33 +00:00
Karol Herbst
2e1fff8e5d rusticl/gl: store the mesa_glinterop_export_in
We need it later for proper flushing and waiting.

Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36249>
2025-08-07 12:58:32 +00:00
Karol Herbst
8617cf46d6 rusticl/mesa: wire up fence_server
We need this to wait on imported fences.

Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36249>
2025-08-07 12:58:32 +00:00
Alyssa Rosenzweig
94a2740cab panvk: rewrite pan_nir_lower_static_noperspective
Really this should be using the common code I added in
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36501 but one thing at
a time.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Olivia Lee <olivia.lee@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36600>
2025-08-07 10:33:36 +00:00
Samuel Pitoiset
dad0c7e6d4 zink/ci: make zink-radv-navi31-valve a pre-merge job
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Otherwise, it's regularly broken and a waste of time for everyone.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13501
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36594>
2025-08-07 09:14:00 +00:00
Samuel Pitoiset
06338ccf9e zink/ci: reduce timeout of zink-radv-navi31-valve
It usually runs in ~5 minutes, and it's important to reduce it for
pre-merge testing.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36594>
2025-08-07 09:14:00 +00:00
Karol Herbst
cfd8b9d3b3 rusticl: use pipe_sampler_view_release
Fixes: a245ed462a ("rusticl/mesa: use pipe_sampler_view_reference")
Suggested-by: Seán de Búrca <leftmostcat@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36613>
2025-08-07 08:05:55 +00:00
Kenneth Graunke
dc2c3cf06b intel: Disable 16x MSAA support on Xe3
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
16x MSAA isn't supported at all on certain Xe3 variants, and on its way
out on the rest.  Most vendors choose not to support it, and many apps
offer more modern multisampling and upscaling techniques these days.

Only 2/4/8x are supported going forward.

Cc: mesa-stable
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36592>
2025-08-07 07:30:35 +00:00
Kenneth Graunke
f7def1ac1e crocus: Fix a comment about supporting 16x MSAA
The mask here was already 0xff (8-bits) because only 8x MSAA is
supported, but the comment was copy-pasted from iris which did 16x.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36592>
2025-08-07 07:30:35 +00:00
Kenneth Graunke
d098b3b973 crocus: Drop 16X MSAA code remnants
No platforms supported by crocus actually support 16X MSAA, so this is
just copy-pasted from iris without actually offering any benefit.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36592>
2025-08-07 07:30:35 +00:00
Samuel Pitoiset
418a335626 zink/ci: skip spec@arb_fragment_program@fog-modes on RADV
This test seems to hang.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36611>
2025-08-07 07:08:14 +00:00
Marek Olšák
91cee75e63 mesa: stop using inc_mesa in most places that have nothing to do with GL
Acked-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36562>
2025-08-06 20:35:26 +00:00
Marek Olšák
ebdecb8d45 mesa: remove inc_mapi
We don't need this to be in include dirs.

Acked-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36562>
2025-08-06 20:35:26 +00:00
Marek Olšák
8f2532453c mesa: move src/mapi to src/mesa/glapi
Acked-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36562>
2025-08-06 20:35:26 +00:00
Eric Engestrom
16e38f6596 lavapipe/ci: document recent flakes
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36612>
2025-08-06 16:15:08 +00:00
Eric Engestrom
455b324827 zink+radv/ci: document recent flakes
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36612>
2025-08-06 16:15:08 +00:00
Rob Clark
3ddcf8ab92 freedreno/a6xx: Convert gallium to new cs builders
Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36589>
2025-08-06 12:24:59 +00:00
Rob Clark
4fe255b14d freedreno/a6xx: Rename compute state to cp
So it doesn't conflict with the new cs builders.

Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36589>
2025-08-06 12:24:59 +00:00
Rob Clark
3864d1c209 freedreno/a6xx: Remove compute state user_consts_cmdstream_size
Unused.

Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36589>
2025-08-06 12:24:58 +00:00
Rob Clark
c1aaef71da freedreno/a6xx: Make tex/samp descriptors a normal BO
This way the descriptor upload is simply memcpy().

Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36589>
2025-08-06 12:24:58 +00:00
Rob Clark
b17c34326d freedreno/a6xx: Make samp descriptor an array
So that we can use plain memcpy in the next patch.

Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36589>
2025-08-06 12:24:58 +00:00
Rob Clark
49e5d83d31 freedreno/a6xx: Bake iova's into descriptors
a6xx+ has long since used FD_BO_NO_HARDPIN, with BO tracking integrated
with resource tracking.  So we don't really need OUT_RELOC() for
building texture descriptors.  We had already dropped that for UVA
descriptors, now cleanup tex descriptors to match.

Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36589>
2025-08-06 12:24:58 +00:00
Rob Clark
dec7022d1a freedreno/a6xx: Separate out blit setup
With the upcoming NCRB conversion, it is easier if all the setup reg
writes happen in their own scope, so the NCRB builder goes out of scope
and flushes the packet(s).  So re-arrange things a bit so we don't have
to add artificial {}'s

Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36589>
2025-08-06 12:24:58 +00:00
Rob Clark
5dce5891d2 freedreno/a6xx: Drop orval/shift
These where always zero for a6xx, and not really supported by the reg
packers.

Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36589>
2025-08-06 12:24:58 +00:00
Rob Clark
2a7f70f697 freedreno: Drop unused emit_const_asserts() param
Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36589>
2025-08-06 12:24:58 +00:00
Rob Clark
fc61827688 freedreno/registers: Add some reg64 to pm4
Some pm4 packets still describe 64b addresses as _HI and _LO reg32.
We'll need the reg64 type="address" (or "waddress") definitions in
order to emit these packets via fd_reg_pair with the new cs builders.

Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36589>
2025-08-06 12:24:58 +00:00
Rob Clark
fa8e84a175 freedreno/registers: Fix array reg names
We shouldn't suffix them with the array index, as that is redundant with
<array/> descriptions.

Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36589>
2025-08-06 12:24:58 +00:00
Rob Clark
50921081c0 freedreno: Add debug option to crash on context fault
Makes debugging easier.

Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36589>
2025-08-06 12:24:57 +00:00
Rob Clark
f10217a6a3 freedreno: Remove obsolete comment
This hasn't been quite true for quite a while.

Fixes: 78c8a8af80 ("freedreno: Generate device-info tables at build time")
Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36589>
2025-08-06 12:24:57 +00:00
Alyssa Rosenzweig
20dab5f819 asahi: enable virtgpu support
this updates our virtgpu support to match the upstream protocol, and enables. it
is marked for backport since the older Mesa releases already had virtgpu
support, just gated off to allow for breaking wire protocol changes (of which
there was 1 at the last moment).

Upstream virglrenderer MR assigned to marge:
https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/1541

Backport-to: 25.1
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36580>
2025-08-06 11:11:06 +00:00
Eric Engestrom
7f5d1b1350 zink+nvk/ci: give piglit tests a display to use
The run time has not changed, it's still 22 min for ad106 and 22.5 min
for ga106.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36574>
2025-08-06 10:16:23 +00:00
Eric Engestrom
159a92947a zink+nvk/ci: sort ad106 fails
This is only moving the lines, no contents change other than adding
newlines between groups.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36574>
2025-08-06 10:16:23 +00:00
Christoph Neuhauser
acbb2d018c egl: Fix DRI utility function compilation on macOS
Signed-off-by: Christoph Neuhauser <christoph.neuhauser@intel.com>
Tested-by: Yurii Kolesnykov <root@yurikoles.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13556
Fixes: e99446fc5e ("egl: Add EGL_EXT_device_query_name and EGL_EXT_device_persistent_id")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36495>
2025-08-06 08:46:52 +00:00
Valentine Burley
d5c413a30d virgl/ci: Use Weston's Xwayland instead of Xvfb
Signed-off-by: Valentine Burley <valentine.burley@collabora.com>
Acked-by: Corentin Noël <corentin.noel@collabora.com>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36567>
2025-08-06 07:33:32 +00:00
Valentine Burley
cb0315bcd7 softpipe/ci: Use Weston's Xwayland instead of Xvfb
Signed-off-by: Valentine Burley <valentine.burley@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36567>
2025-08-06 07:33:32 +00:00
Valentine Burley
5742f6f2db zink/ci: Use Weston's Xwayland instead of Xvfb
Signed-off-by: Valentine Burley <valentine.burley@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36567>
2025-08-06 07:33:32 +00:00
Qiang Yu
b22806705c compiler,gallium: remove PIPE_SHADER_* and adjust some macro usage
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Acked-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Acked-by: Yonggang Luo <luoyonggang@gmail.com>
Acked-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36569>
2025-08-06 10:28:41 +08:00