20134 commits

Author	SHA1	Message	Date
Benjamin Cheng	cef8eff74d	radv/video: Override H265 SPS unaligned resolutions ... VCN requires 64x16 alignment for HEVC. When the app requests non-aligned resolutions, make up for it with conformance window cropping. Reviewed-by: Ruijing Dong <ruijing.dong@amd.com> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38061>	2025-10-28 08:53:35 +00:00
Benjamin Cheng	84b6d8e0d7	radv/video: Override H265 SPS block size parameters ... VCN only supports this set of parameters. Reviewed-by: Ruijing Dong <ruijing.dong@amd.com> Cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38061>	2025-10-28 08:53:35 +00:00
Samuel Pitoiset	45affb0e53	radv: advertise VK_EXT_shader_uniform_buffer_unsized_array ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38047>	2025-10-28 07:55:40 +01:00
Samuel Pitoiset	a31d3c764c	amd,radv,radeonsi: move GFX12 push SH REGS helpers to common code ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38000>	2025-10-27 08:30:02 +00:00
Samuel Pitoiset	bddd7919d3	amd,radv,radeonsi: add ac_buffered_sh_regs ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38000>	2025-10-27 08:30:02 +00:00
Samuel Pitoiset	91bd46d34e	amd,radv,radeonsi: add ac_{gfx11_reg_pair,gfx12_reg} ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38000>	2025-10-27 08:30:01 +00:00
Samuel Pitoiset	846b707045	amd,radv,radeonsi: move some GFX12 emit helpers to common code ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38000>	2025-10-27 08:30:00 +00:00
Samuel Pitoiset	2009815d61	radv: add radv_wait_for_vm_map_updates drirc and enable for Forza Horizon 5 ... Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13321 Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38031>	2025-10-27 07:56:45 +00:00
Samuel Pitoiset	fc0cfaae1c	radv/amdgpu: add a way to wait for VM updates at alloc time ... RADEON_FLAG_VM_UPDATE_WAIT can be passed to wait for VM updates at allocation time instead of delaying them at submit time. There is no reason to delay the waiting when the memory is bound to images/buffers because in DX12 ressources are allocated and bound immediately. This flag will be used to workaround an use-before-alloc in FH5 (game bug) which causes GPU hangs. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38031>	2025-10-27 07:56:44 +00:00
Samuel Pitoiset	bbaffa22ff	radv/amdgpu: use radv_amdgpu_bo_va_op() for BOs from pointer ... No logical changes because ac_drm_bo_va_op() sets AMDGPU_VM_PAGE_{READABLE,EXECUTABLE,WRITEABLE}. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38031>	2025-10-27 07:56:44 +00:00
Samuel Pitoiset	f9af7f7b2a	radv: use radv_buffer_get_va() more ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38031>	2025-10-27 07:56:44 +00:00
jglrxavpok	09e091fbdf	radv/aco: Print source location debug info inside ACO disassembly if we have the information ... Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36443>	2025-10-26 15:12:58 +00:00
Collabora's Gfx CI Team	8d37098deb	Uprev ANGLE to e9626fbced6841d804e7eaf48bb078770822032b ... 8ed16003f2...e9626fbced Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37858>	2025-10-26 00:08:20 +00:00
Konstantin Seurer	95a89f7b33	radv: Report smaller bvh sizes when possible ... Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37830>	2025-10-24 21:17:10 +00:00
Konstantin Seurer	7809af5e46	radv: Always use compact bvh encoding ... The compact encoding will make it possible to allocate less space for internal nodes Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37830>	2025-10-24 21:17:10 +00:00
Alyssa Rosenzweig	b824ef83ab	util/dynarray: infer type in append ... Most of the time, we can infer the type to append in util_dynarray_append using __typeof__, which is standardized in C23 and support in Jesse's MSMSVCV. This patch drops the type argument most of the time, making util_dynarray a little more ergonomic to use. This is done in four steps. First, rename util_dynarray_append -> util_dynarray_append_typed bash -c "find . -type f -exec sed -i -e 's/util_dynarray_append(/util_dynarray_append_typed(/g' \{} \;" Then, add a new append that infers the type. This is much more ergonomic for what you want most of the time. Next, use type-inferred append as much as possible, via Coccinelle patch (plus manual fixup): @@ expression dynarray, element; type type; @@ -util_dynarray_append_typed(dynarray, type, element); +util_dynarray_append(dynarray, element); Finally, hand fixup cases that Coccinelle missed or incorrectly translated, of which there were several because we can't used the untyped append with a literal (since the sizeof won't do what you want). All four steps are squashed to produce a single patch changing every util_dynarray_append call site in tree to either drop a type parameter (if possible) or insert a _typed suffix (if we can't infer). As such, the final patch is best reviewed by hand even though it was tool-assisted. No Long Linguine Meals were involved in the making of this patch. Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com> Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38038>	2025-10-24 18:32:07 +00:00
Samuel Pitoiset	849d41dbf8	radv: implement a new descriptor sets allocator ... The previous implementation was horribly slow with a larger number of descriptor sets. The new approach uses util_vma_heap (like ANV) which is a perfect fit. This fixes stuttering in Indiana Jones because that games seems to use a huge number of descriptor sets which can also be freed. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13901 Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37976>	2025-10-24 06:25:17 +00:00
Samuel Pitoiset	9b6d89f4ca	radv: use a linked-list for storing descriptor pool sets ... Only when pool entries aren't freed yet. This will make the new allocation strategy much simpler. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37976>	2025-10-24 06:25:17 +00:00
Samuel Pitoiset	4d33d3f507	radv: add radv_bind_{graphics,rt,compute}_pipeline() helpers ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38004>	2025-10-24 05:59:06 +00:00
Samuel Pitoiset	54a6c81d3a	radv: dirty dynamic descriptors when required ... The user SGPRS might be different and dynamic descriptors need to be re-emitted again This fixes a regression with ANGLE, and VCKTS is currently missing coverage. Fixes: a47952d495 ("radv: upload and emit dynamic descriptors separately from push constants") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14146 Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38004>	2025-10-24 05:59:06 +00:00
Samuel Pitoiset	3440272406	radv/ci: update comments around video failures ... They are expected failures and they will always fail unless we have new firmwares (which is unlikely to happen). Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38021>	2025-10-23 16:56:26 +02:00
Samuel Pitoiset	f5384df105	radv/ci: stop skipping dEQP-VK.descriptor_indexing.* on Cezanne ... The fix is included in VKCTS now. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38021>	2025-10-23 16:56:26 +02:00
Rhys Perry	f3ff2375ec	ac/nir: don't consider quads incomplete inside loops ... We move terminates to outside loops, so this doesn't matter anymore. fossil-db (gfx1201): Totals from 145 (0.18% of 79839) affected shaders: Instrs: 174693 -> 174389 (-0.17%); split: -0.18%, +0.01% CodeSize: 917068 -> 915692 (-0.15%); split: -0.16%, +0.01% VGPRs: 8340 -> 8184 (-1.87%) Latency: 2528888 -> 2521006 (-0.31%); split: -0.48%, +0.16% InvThroughput: 502383 -> 504082 (+0.34%); split: -0.44%, +0.78% Copies: 15968 -> 15632 (-2.10%); split: -2.14%, +0.04% PreVGPRs: 5918 -> 5858 (-1.01%) VALU: 92802 -> 92484 (-0.34%); split: -0.35%, +0.01% SALU: 29437 -> 29430 (-0.02%) Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Georg Lehmann <dadschoorse@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37561>	2025-10-23 11:22:02 +00:00
Rhys Perry	9babec1366	radv,radeonsi: use optimize_txd ... Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Georg Lehmann <dadschoorse@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37561>	2025-10-23 11:22:01 +00:00
Rhys Perry	7d552d71e9	ac/nir: optimize txd(coord, ddx/ddy(coord)) ... This is done in ac_nir_lower_tex so that we can optimize derivative calculations with a different exec mask than the texture sample by using the nir_strict_wqm_coord_amd path. It's also more aware of divergence than nir_lower_tex is. fossil-db (gfx1201): Totals from 103 (0.13% of 79839) affected shaders: MaxWaves: 2610 -> 2620 (+0.38%) Instrs: 347283 -> 345912 (-0.39%); split: -0.40%, +0.00% CodeSize: 1892380 -> 1883824 (-0.45%); split: -0.46%, +0.00% VGPRs: 8028 -> 7824 (-2.54%) Latency: 3942575 -> 3939623 (-0.07%); split: -0.08%, +0.01% InvThroughput: 867147 -> 865281 (-0.22%); split: -0.24%, +0.02% VClause: 6230 -> 6221 (-0.14%); split: -0.19%, +0.05% SClause: 3910 -> 3914 (+0.10%); split: -0.26%, +0.36% Copies: 16091 -> 15721 (-2.30%); split: -2.74%, +0.44% PreSGPRs: 4651 -> 4658 (+0.15%) PreVGPRs: 6389 -> 6320 (-1.08%); split: -1.17%, +0.09% VALU: 228715 -> 227490 (-0.54%); split: -0.54%, +0.01% SALU: 32763 -> 32767 (+0.01%); split: -0.06%, +0.07% VMEM: 9027 -> 9024 (-0.03%) Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Georg Lehmann <dadschoorse@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37561>	2025-10-23 11:22:00 +00:00
Rhys Perry	309ac1f0c0	ac/nir: refactor move_coords_from_divergent_cf a bit ... Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Georg Lehmann <dadschoorse@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37561>	2025-10-23 11:21:59 +00:00
Rhys Perry	241bbb4977	radv: remove NIR_PASS in insert_rt_case ... When NIR_DEBUG=serialize or NIR_DEBUG=clone is used, NIR_PASS recreates nir_function_impl and nir_variable objects, causing use-after-free since insert_rt_case() keeps pointers to those in local variables and var_remap. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Marek Olšák <maraeo@gmail.com> Reviewed-by: Georg Lehmann <dadschoorse@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37573>	2025-10-23 10:44:38 +00:00
Rhys Perry	55018df38d	radv: stop rallocing objects which don't belong to the shader under it ... This doesn't work with NIR_DEBUG=serialize or NIR_DEBUG=clone. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Marek Olšák <maraeo@gmail.com> Reviewed-by: Georg Lehmann <dadschoorse@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37573>	2025-10-23 10:44:38 +00:00
Rhys Perry	762a803aa7	radv: remove NIR_PASS in radv_nir_lower_rt_abi ... When NIR_DEBUG=serialize or NIR_DEBUG=clone is used, NIR_PASS recreates nir_function_impl and nir_variable objects, causing use-after-free since radv_nir_lower_rt_abi() keeps pointers to those in local variables. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Marek Olšák <maraeo@gmail.com> Reviewed-by: Georg Lehmann <dadschoorse@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37573>	2025-10-23 10:44:38 +00:00
Rhys Perry	42bb81137e	ac/nir: stop using NIR_PASS in ac_nir_lower_ngg_nogs() ... When NIR_DEBUG=serialize or NIR_DEBUG=clone is used, NIR_PASS recreates nir_function_impl and nir_variable objects, causing use-after-free since ac_nir_lower_ngg_nogs() keeps pointers to those in local variables. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13946 Reviewed-by: Marek Olšák <maraeo@gmail.com> Reviewed-by: Georg Lehmann <dadschoorse@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37573>	2025-10-23 10:44:38 +00:00
Samuel Pitoiset	457d8926e1	amd,radv,radeonsi: add ac_emit_cp_release_mem() ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37956>	2025-10-23 08:29:27 +00:00
Samuel Pitoiset	22d73fc077	amd,radv,radeonsi: add ac_emit_spm_setup() ... This moves all SPM emit code to common code. This likely also fixes SPM on GFX11+ for RadeonSI. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37956>	2025-10-23 08:29:27 +00:00
Samuel Pitoiset	202f8db793	amd,radv,radeonsi: add ac_emit_cp_spi_config_cntl() ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37956>	2025-10-23 08:29:27 +00:00
Samuel Pitoiset	5cb400a97b	amd,radv,radeonsi: add ac_emit_cp_inhibit_clockgating() ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37956>	2025-10-23 08:29:26 +00:00
Samuel Pitoiset	bc1080e27f	amd,radv,radeonsi: add and use more ac_cmdbuf_XXX helpers ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37956>	2025-10-23 08:29:26 +00:00
Samuel Pitoiset	a4a834859e	radv/amdgpu: remove now unused radeon_emit helpers ... Keep radeon_emit_unchecked() for now because it's special. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37956>	2025-10-23 08:29:25 +00:00
Samuel Pitoiset	0fb21e2299	amd,radv: add ac_emit_cp_indirect_buffer() ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37956>	2025-10-23 08:29:25 +00:00
Samuel Pitoiset	3efe8ec16b	radv/amdgpu: use common emit helpers in radv_amdgpu_cs_chain_dgc_ib() ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37956>	2025-10-23 08:29:25 +00:00
Samuel Pitoiset	50ec03054c	amd,radv,radeonsi: add ac_pm4_emit_commands() ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37956>	2025-10-23 08:29:24 +00:00
Samuel Pitoiset	22cb7b5fe2	radv: bump image limit properties on GFX12 ... Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14150 Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37974>	2025-10-23 07:56:39 +00:00
Samuel Pitoiset	002ebb4fe5	radv: configure the screen scissor to the maximum image dimension ... The framebuffer dimension exposed to apps is still 16k but since the driver allows 32k image on GFX12+, meta operations might perform operations (like a copy) using graphics. While we are at it, use the correct bitfield for setting BR_X/BR_Y on GFX12. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37974>	2025-10-23 07:56:38 +00:00
Samuel Pitoiset	bcde1a6650	radv: initialize image properties earlier ... This is less error prone and it removes redundant code. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37974>	2025-10-23 07:56:37 +00:00
Samuel Pitoiset	3678437ca0	radv: bump maxImageDimension3D to 8192 on GFX10+ ... This was missing and it aligns to VkImageFormatProperties. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37974>	2025-10-23 07:56:36 +00:00
Samuel Pitoiset	5c71ffbc3d	radv: bump maxImageArrayLayers to 8192 on GFX10+ ... This was missing and it aligns to VkImageFormatProperties. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37974>	2025-10-23 07:56:36 +00:00
Konstantin Seurer	47ffe2ecd4	aco: Fixup out_launch_size_y in the RT prolog for 1D dispatch ... launch_size_y is set to ACO_RT_CONVERTED_2D_LAUNCH_SIZE for 1D dispatches. The prolog needs to set it to 1 so that the app shader loads the correct value. cc: mesa-stable Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37974>	2025-10-23 07:56:35 +00:00
Samuel Pitoiset	067b05d5b9	radv: remove radv_pipeline_layout::push_constant_size ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37769>	2025-10-23 07:25:41 +00:00
Samuel Pitoiset	d15b411262	radv: remove radv_shader_layout::push_constant_size ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37769>	2025-10-23 07:25:41 +00:00
Samuel Pitoiset	2985322ed1	radv: gather push constant size from shaders for pipelines ... Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37769>	2025-10-23 07:25:41 +00:00
Samuel Pitoiset	97dbf7b895	radv/rt: radv: gather push constant size from shaders for RT ... And store the total push constant size to the RT prolog. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37769>	2025-10-23 07:25:41 +00:00
Samuel Pitoiset	aa44a5a4ae	radv: gather push constant size from shaders for ESO ... Instead of using the shader layout which won't exist anymore with heap. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37769>	2025-10-23 07:25:41 +00:00