From fef8a4befdc7f980e4da875cf80bc892cbaf7ed4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Sch=C3=BCrmann?= Date: Fri, 23 Oct 2020 16:04:33 +0200 Subject: [PATCH] radv: remove call to nir_lower_pack() The pack_* instructions are now lowered via nir_lower_alu_to_scalar() and unpack_* are not lowered anymore. These bitcasts are no-ops, and lowering prevents some optimizations like vectorization. Note: There are still some *_split variations remaining from different other NIR passes. Reviewed-by: Samuel Pitoiset Part-of: --- src/amd/vulkan/radv_shader.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index f48438d3461..7804cd1438e 100644 --- a/src/amd/vulkan/radv_shader.c +++ b/src/amd/vulkan/radv_shader.c @@ -183,7 +183,6 @@ radv_optimize_nir(struct nir_shader *shader, bool optimize_conservatively, NIR_PASS(progress, shader, nir_shrink_vec_array_vars, nir_var_function_temp); NIR_PASS_V(shader, nir_lower_vars_to_ssa); - NIR_PASS_V(shader, nir_lower_pack); if (allow_copies) { /* Only run this pass in the first call to