From fe36cf6cad9b226dff993a8f1f8f0bf451f095c5 Mon Sep 17 00:00:00 2001 From: Lionel Landwerlin Date: Wed, 1 Nov 2023 02:13:08 +0200 Subject: [PATCH] anv: add missing data flush out of L3 for transform feedback writes Fixes zink's piglit.spec.arb_shader_image_load_store.host-mem-barrier on TGL Signed-off-by: Lionel Landwerlin Cc: mesa-stable Reviewed-by: Francisco Jerez Part-of: --- src/gallium/drivers/zink/ci/zink-anv-tgl-fails.txt | 4 ---- src/intel/vulkan/genX_cmd_buffer.c | 1 + 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/drivers/zink/ci/zink-anv-tgl-fails.txt b/src/gallium/drivers/zink/ci/zink-anv-tgl-fails.txt index dcaf69fa070..c5b580c4f18 100644 --- a/src/gallium/drivers/zink/ci/zink-anv-tgl-fails.txt +++ b/src/gallium/drivers/zink/ci/zink-anv-tgl-fails.txt @@ -449,10 +449,6 @@ spec@arb_sample_shading@samplemask 8@sample mask_in_one,Fail spec@arb_shader_image_load_store@early-z,Fail spec@arb_shader_image_load_store@early-z@occlusion query test/early-z pass,Fail -spec@arb_shader_image_load_store@host-mem-barrier,Fail -spec@arb_shader_image_load_store@host-mem-barrier@Transform feedback/WaW/one bit barrier test/16x16,Fail -spec@arb_shader_image_load_store@host-mem-barrier@Transform feedback/WaW/one bit barrier test/4x4,Fail -spec@arb_shader_image_load_store@host-mem-barrier@Transform feedback/WaW/one bit barrier test/64x64,Fail spec@arb_shader_texture_lod@execution@arb_shader_texture_lod-texgradcube,Fail diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 60cb36d62e4..119b9e53126 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/intel/vulkan/genX_cmd_buffer.c @@ -3604,6 +3604,7 @@ anv_pipe_invalidate_bits_for_access_flags(struct anv_cmd_buffer *cmd_buffer, * tile cache flush to make sure any previous write is not going to * create WaW hazards. */ + pipe_bits |= ANV_PIPE_DATA_CACHE_FLUSH_BIT; pipe_bits |= ANV_PIPE_TILE_CACHE_FLUSH_BIT; break; case VK_ACCESS_2_SHADER_STORAGE_READ_BIT: