fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-07 07:08:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

jay/ra: only use stride=4 temps
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
Details
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Details

Browse source 
SIMD16:

   Totals from 56 (2.12% of 2647) affected shaders:
   Instrs: 541831 -> 542004 (+0.03%); split: -0.40%, +0.44%
   CodeSize: 8597680 -> 8597248 (-0.01%); split: -0.45%, +0.44%

SIMD32:

   Totals:
   Instrs: 4858179 -> 4734713 (-2.54%); split: -2.78%, +0.24%
   CodeSize: 78651424 -> 76667440 (-2.52%); split: -2.76%, +0.24%

   Totals from 1108 (41.86% of 2647) affected shaders:
   Instrs: 4241312 -> 4117846 (-2.91%); split: -3.18%, +0.27%
   CodeSize: 68753152 -> 66769168 (-2.89%); split: -3.16%, +0.27%

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41064>
This commit is contained in:
Alyssa Rosenzweig 2026-04-20 13:57:12 -04:00 • committed by Marge Bot
parent 1f62da938b
commit fd46a48ccc
1 changed files with 18 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

45
src/intel/compiler/jay/jay_register_allocate.c
View file

@ -375,7 +375,6 @@ static jay_def
push_temp(jay_builder *b,
struct jay_temp_regs t,
enum jay_file file,
bool stride4,
bool outer,
jay_def *backing,
jay_def avoid1,
@ -385,8 +384,7 @@ push_temp(jay_builder *b,
jay_reg reg = file == GPR ? t.gpr : t.ugpr;
jay_def tmp = reg == NO_REG ? jay_null() : def_from_reg(reg);
if (!jay_is_null(tmp) &&
(!stride4 || jay_def_stride(b->shader, tmp) == JAY_STRIDE_4)) {
if (!jay_is_null(tmp)) {
return tmp;
}
@ -429,13 +427,11 @@ mov(jay_builder *b, jay_def dst, jay_def src, struct jay_temp_regs temps)
jay_def temp = jay_null(), backing = jay_null();
if (dst.file == MEM && src.file == MEM) {
temp = push_temp(b, temps, GPR, true /* stride4 */, false, &backing,
jay_null(), jay_null());
temp = push_temp(b, temps, GPR, false, &backing, jay_null(), jay_null());
jay_MOV(b, temp, src);
jay_MOV(b, dst, temp);
} else if (dst.file == UMEM && src.file == UMEM) {
temp = push_temp(b, temps, UGPR, false, false, &backing, jay_null(),
jay_null());
temp = push_temp(b, temps, UGPR, false, &backing, jay_null(), jay_null());
jay_MOV(b, def_from_reg(temps.ugpr), src);
jay_MOV(b, dst, def_from_reg(temps.ugpr));
} else if (dst.file == GPR &&
@ -445,8 +441,7 @@ mov(jay_builder *b, jay_def dst, jay_def src, struct jay_temp_regs temps)
jay_def_stride(b->shader, dst) != JAY_STRIDE_4 &&
jay_def_stride(b->shader, src) != JAY_STRIDE_4) {
temp = push_temp(b, temps, GPR, true /* stride4 */, false, &backing,
jay_null(), jay_null());
temp = push_temp(b, temps, GPR, false, &backing, jay_null(), jay_null());
jay_MOV(b, temp, src);
jay_MOV(b, dst, temp);
} else {
@ -610,8 +605,7 @@ jay_emit_parallel_copies(jay_builder *b,
jay_def temp_backing = jay_null();
jay_def temp =
push_temp(b, temps, file == GPR || file == MEM ? GPR : UGPR,
file == MEM /* stride4 */, true /* outer */,
&temp_backing, dst, src);
true /* outer */, &temp_backing, dst, src);
mov(b, temp, dst, t);
mov(b, dst, src, t);
mov(b, src, temp, t);
@ -697,24 +691,20 @@ register_demand(jay_ra_state *ra, enum jay_file f)
}
static jay_reg
try_find_free_reg(jay_ra_state *ra, enum jay_file file, unsigned except)
try_find_free_reg(jay_ra_state *ra,
enum jay_file file,
unsigned except,
bool stride4)
{
unsigned i;
/* Prefer stride 4 temporaries, since they are more compatible and thus
* should reduce swapping on average.
*/
if (file == GPR) {
BITSET_FOREACH_SET(i, ra->available_regs[file], ra->num_regs[file]) {
if (i != except &&
jay_gpr_to_stride(&ra->b.shader->partition, i) == JAY_STRIDE_4) {
return make_reg(file, i);
}
}
}
BITSET_FOREACH_SET(i, ra->available_regs[file], ra->num_regs[file]) {
if (i != except) {
if (i != except &&
(!stride4 ||
jay_gpr_to_stride(&ra->b.shader->partition, i) == JAY_STRIDE_4)) {
return make_reg(file, i);
}
}
@ -725,7 +715,7 @@ try_find_free_reg(jay_ra_state *ra, enum jay_file file, unsigned except)
static jay_reg
find_free_reg(jay_ra_state *ra, enum jay_file file, unsigned except)
{
jay_reg reg = try_find_free_reg(ra, file, except);
jay_reg reg = try_find_free_reg(ra, file, except, false);
if (reg == NO_REG) {
fprintf(stderr, "file %u, current demand %u, target %u\n", file,
@ -739,14 +729,15 @@ find_free_reg(jay_ra_state *ra, enum jay_file file, unsigned except)
static inline struct jay_temp_regs
find_temp_regs(jay_ra_state *ra)
{
jay_reg gpr = try_find_free_reg(ra, GPR, ~0);
jay_reg ugpr = try_find_free_reg(ra, UGPR, ~0);
/* For efficiency we only bother using stride=4 temporaries */
jay_reg gpr = try_find_free_reg(ra, GPR, ~0, true);
jay_reg ugpr = try_find_free_reg(ra, UGPR, ~0, true);
return (struct jay_temp_regs) {
.gpr = gpr,
.ugpr = ugpr,
.gpr2 = try_find_free_reg(ra, GPR, gpr),
.ugpr2 = try_find_free_reg(ra, UGPR, ugpr),
.gpr2 = try_find_free_reg(ra, GPR, gpr, true),
.ugpr2 = try_find_free_reg(ra, UGPR, ugpr, true),
};
}