From fd284526312194100777459c75b107ebba57a7c9 Mon Sep 17 00:00:00 2001 From: Emma Anholt Date: Wed, 1 Feb 2023 15:23:00 -0800 Subject: [PATCH] turnip: Make the tiling-impossible case have an impossible tile layout. This helped me catch inappropriate tiling work being done in this case. Part-of: --- src/freedreno/vulkan/tu_util.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/freedreno/vulkan/tu_util.c b/src/freedreno/vulkan/tu_util.c index 4ba7df7bfbb..3ac4de4a7c7 100644 --- a/src/freedreno/vulkan/tu_util.c +++ b/src/freedreno/vulkan/tu_util.c @@ -164,11 +164,11 @@ tu_tiling_config_update_tile_layout(struct tu_framebuffer *fb, */ if (!pass->gmem_pixels[gmem_layout]) { tiling->possible = false; - /* Some parts of the code do conditional gmem setup even when gmem is not - * possible. Give them a dummy tiling layout. + /* Put in dummy values that will assertion fail in register setup using + * them, since you shouldn't be doing gmem work if gmem is not possible. */ tiling->tile_count = (VkExtent2D) { 1, 1 }; - tiling->tile0 = (VkExtent2D) { tile_align_w, tile_align_h }; + tiling->tile0 = (VkExtent2D) { ~0, ~0 }; return; }