fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-01 10:18:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

panfrost: Assert that blend shaders are nontrivial

Browse source 
Even if the driver doesn't *use* trivial blend shaders, building and compiling
blend shaders is expensive. We shouldn't be building blend shaders that should
never be used.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17841>
This commit is contained in:
Alyssa Rosenzweig 2022-08-01 18:57:55 -04:00 • committed by Marge Bot
parent 1d5aad9db4
commit fcae7cfd27
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/panfrost/lib/pan_blend.c
View file

@ -799,6 +799,10 @@ GENX(pan_blend_get_shader_locked)(const struct panfrost_device *dev,
.equation = state->rts[rt].equation,
};
/* Blend shaders should only be used for blending on Bifrost onwards */
assert(dev->arch <= 5 || !pan_blend_is_opaque(state->rts[rt].equation));
assert(state->rts[rt].equation.color_mask != 0);
struct hash_entry *he = _mesa_hash_table_search(dev->blend_shaders.shaders, &key);
struct pan_blend_shader *shader = he ? he->data : NULL;