fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-04 20:38:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

i915g: Fix writing of undefined depth value if not writing any outputs.

Browse source 
This was showing up as flakes in CI on tests that didn't write any outputs
but did check the depth result.

Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10874>
This commit is contained in:
Emma Anholt 2021-05-18 12:19:45 -07:00 • committed by Marge Bot
parent 8b0901c707
commit fc3d5bebf2
2 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/gallium/drivers/i915/ci/piglit-i915-g33-flakes.txt
View file

@ -1,2 +1 @@
spec@glsl-1.10@execution@discard@glsl-fs-discard-03
spec@glsl-1.10@glsl-fs-discard-only

2
src/gallium/drivers/i915/i915_fpc_translate.c
View file

@ -1187,7 +1187,7 @@ static void
i915_fixup_depth_write(struct i915_fp_compile *p)
{
/* XXX assuming pos/depth is always in output[0] */
if (p->shader->info.output_semantic_name[0] == TGSI_SEMANTIC_POSITION) {
if (p->shader->info.num_outputs != 0 && p->shader->info.output_semantic_name[0] == TGSI_SEMANTIC_POSITION) {
const uint depth = UREG(REG_TYPE_OD, 0);
i915_emit_arith(p,