fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-03-14 17:20:42 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

util/bitset: add an assert for big BITSET_EXTRACT

Browse source 
This just bit me. Add an assert to catch the next person who doesn't
read the function signature and tries to extract 64-bits out and wonders
why things are silently broken.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39892>
This commit is contained in:
Alyssa Rosenzweig 2026-02-13 10:58:42 -05:00 • committed by Marge Bot
parent f55e87db93
commit fc3951cfde
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/util/bitset.h
View file

@ -282,6 +282,7 @@ __bitset_clear_range(BITSET_WORD *r, int start, int end)
static inline unsigned
__bitset_extract(const BITSET_WORD *r, unsigned start, unsigned count)
{
assert(count <= BITSET_WORDBITS);
unsigned shift = start % BITSET_WORDBITS;
BITSET_WORD lower = r[BITSET_BITWORD(start)] >> shift;
BITSET_WORD upper = shift ? r[BITSET_BITWORD(start + count - 1)] << (BITSET_WORDBITS - shift) : 0;