fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-21 05:00:09 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

panvk: Handle IUBs in decoder

Browse source 
When we encode inline uniform data into the descriptor table, we should
skip the descriptors that are actually data instead of real descriptors.
Let's do that and also print the inlined data for convenience.

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35831>
This commit is contained in:
Christoph Pillmayer 2025-06-30 09:21:43 +00:00 • committed by Marge Bot
parent 54c967cb76
commit fb38f10240
1 changed files with 33 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
src/panfrost/genxml/decode.c
View file

@ -563,6 +563,37 @@ GENX(pandecode_shader)(struct pandecode_context *ctx, uint64_t addr,
return desc.binary;
}
static unsigned
pandecode_buffer(struct pandecode_context *ctx,
const struct mali_buffer_packed *cl, uint64_t addr)
{
pan_unpack(cl, BUFFER, buffer)
;
DUMP_UNPACKED(ctx, BUFFER, buffer, "Buffer @%" PRIx64 ":\n", addr);
/* If the address is the following descriptor, this descriptor is an IUB. */
if (buffer.address == (addr + 0x20)) {
assert((buffer.size % 0x20) == 0);
const uint8_t *cl_bytes = (uint8_t *)cl;
const uint32_t *words = (uint32_t *)(cl_bytes + 0x20);
unsigned count = buffer.size / (2 * sizeof(uint32_t));
ctx->indent++;
pandecode_log(ctx, "IUB @%" PRIx64 ":\n", buffer.address);
ctx->indent++;
for (unsigned i = 0; i < count; ++i)
pandecode_log(ctx, "%08X %08X\n", words[2 * i], words[2 * i + 1]);
ctx->indent--;
ctx->indent--;
pandecode_log(ctx, "\n");
return buffer.size;
}
return 0;
}
static void
pandecode_resources(struct pandecode_context *ctx, uint64_t addr, unsigned size)
{
@ -589,7 +620,8 @@ pandecode_resources(struct pandecode_context *ctx, uint64_t addr, unsigned size)
DUMP_CL(ctx, ATTRIBUTE, cl + i, "Attribute @%" PRIx64 ":\n", addr + i);
break;
case MALI_DESCRIPTOR_TYPE_BUFFER:
DUMP_CL(ctx, BUFFER, cl + i, "Buffer @%" PRIx64 ":\n", addr + i);
i += pandecode_buffer(ctx, (const struct mali_buffer_packed *)&cl[i],
addr + i);
break;
default:
fprintf(ctx->dump_stream, "Unknown descriptor type %X\n", header.type);