fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-20 08:50:25 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

brw/emit: Fix typo in recently added ADD3 assertion

Browse source 
The current assertion fails as soon as a MAD with src0 and src2 being
immediate is detected.

The assertion was supposted to catch, "If it's ADD3, only one of src0
and src2 can be immediate." The detect this, the opcode test should have
been !=.

Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
Fixes: c1c09e3c4a ("brw/emit: Add correct 3-source instruction assertions for each platform")
(cherry picked from commit c52ce6157f)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32730>
This commit is contained in:
Ian Romanick 2024-11-18 09:25:53 -08:00 • committed by Dylan Baker
parent f05bcf460a
commit fa6e9e6587
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -464,7 +464,7 @@
"description": "brw/emit: Fix typo in recently added ADD3 assertion",
"nominated": true,
"nomination_type": 2,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "c1c09e3c4a0fedd777442828efefb672e99b8dbc",
"notes": null

2
src/intel/compiler/brw_eu_emit.c
View file

@ -562,7 +562,7 @@ brw_alu3(struct brw_codegen *p, unsigned opcode, struct brw_reg dest,
/* Having two immediate sources is allowed, but this should have been
* converted to a regular ADD by brw_fs_opt_algebraic.
*/
assert(opcode == BRW_OPCODE_ADD3 ||
assert(opcode != BRW_OPCODE_ADD3 ||
!(src0.file == IMM && src2.file == IMM));
}