fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-22 12:50:35 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

mesa/fbo: do not assign a value that is never read later on

Browse source 
The issue has been detected by coverty.

v2:
- move the declaration of obj to the else clause (Brian Paul)

v3: Review by Brian Paul
- get rid of the obj declaration in favor of a direct reference

Reviewed-by: Brian Paul <brianp@vmware.com>
Signed-off-by: Martin Peres <martin.peres@linux.intel.com>
This commit is contained in:
Martin Peres 2015-03-25 16:28:03 +02:00
parent 8f7338f284
commit fa38321551
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/mesa/main/fbobject.c
View file

@ -1400,7 +1400,6 @@ create_render_buffers(struct gl_context *ctx, GLsizei n, GLuint *renderbuffers,
bool dsa)
{
const char *func = dsa ? "glCreateRenderbuffers" : "glGenRenderbuffers";
struct gl_renderbuffer *obj;
GLuint first;
GLint i;
@ -1419,13 +1418,11 @@ create_render_buffers(struct gl_context *ctx, GLsizei n, GLuint *renderbuffers,
renderbuffers[i] = name;
if (dsa) {
obj = allocate_renderbuffer(ctx, name, func);
allocate_renderbuffer(ctx, name, func);
} else {
obj = &DummyRenderbuffer;
/* insert the object into the hash table */
/* insert a dummy renderbuffer into the hash table */
mtx_lock(&ctx->Shared->Mutex);
_mesa_HashInsert(ctx->Shared->RenderBuffers, name, obj);
_mesa_HashInsert(ctx->Shared->RenderBuffers, name, &DummyRenderbuffer);
mtx_unlock(&ctx->Shared->Mutex);
}
}