fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-25 21:40:08 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

panfrost: Make instrs_equal check res table/index

Browse source 
Add resource table and index check to instruction equality function.
This prevents CSE from mistakenly eliminating LEA_BUF_IMM instructions
that load from different resources, but with the same buffer offset.

Cc: mesa-stable
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37007>
(cherry picked from commit 00b5275fe8)
This commit is contained in:
Ludvig Lindau 2025-08-26 11:39:22 +00:00 • committed by Eric Engestrom
parent 7b5bda3fcc
commit f9e034bf26
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -1134,7 +1134,7 @@
"description": "panfrost: Make instrs_equal check res table/index",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": null,
"notes": null

6
src/panfrost/compiler/bi_opt_cse.c
View file

@ -117,6 +117,12 @@ instrs_equal(const void *_i1, const void *_i2)
return false;
}
if (i1->table != i2->table)
return false;
if (i1->index != i2->index)
return false;
return true;
}