fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 19:40:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

i965: Mark error annotation on correct SIMD16 inst.

Browse source 
inst, whose assignment can be seen in the last line of context pointed
to the correct instruction in the SIMD16 program, but src_offset was the
offset from the beginning of the SIMD16 program.

So if an instruction at offset 0x100 in the SIMD16 program was illegal,
we would mark an error on the instruction at offset 0x100 (which is
likely in the SIMD8 program).

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
This commit is contained in:
Matt Turner 2016-11-19 19:20:02 -08:00
parent 59003f3447
commit f9a4fc9b15
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/mesa/drivers/dri/i965/brw_eu_validate.c
View file

@ -135,10 +135,10 @@ brw_validate_instructions(const struct brw_codegen *p, int start_offset,
struct annotation_info *annotation)
{
const struct gen_device_info *devinfo = p->devinfo;
const void *store = p->store + start_offset / 16;
const void *store = p->store;
bool valid = true;
for (int src_offset = 0; src_offset < p->next_insn_offset - start_offset;
for (int src_offset = start_offset; src_offset < p->next_insn_offset;
src_offset += sizeof(brw_inst)) {
struct string error_msg = { .str = NULL, .len = 0 };
const brw_inst *inst = store + src_offset;